<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 6, 2014 at 4:54 PM, Summers Pittman <span dir="ltr"><<a href="mailto:supittma@redhat.com" target="_blank">supittma@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On Tue 06 May 2014 10:42:10 AM EDT, Bruno Oliveira wrote:<br>
> Option 2 sounds like a plan to me<br>
><br>
<br>
</div>Sweet.<br>
<br>
RestProvider throws httpexception (status:302)<br>
Registrar catches it and logs a warning.<br>
Retries with new location.<br>
if OK then onSuccess<br>
else then onError.<br>
<br>
IE We will only follow ONE redirect.<br></blockquote><div><br></div><div>yes :) no need to join a redirect party </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div class="h5"><br>
> On 2014-05-06, Daniel Passos wrote:<br>
>> Talking with Summers about what is the best options to solved that, we have<br>
>> some options:<br>
>><br>
>> 1) Catch the 302 and handle it inside of the rest provider. [1]<br>
>><br>
>> 2) We can fix the IOException which is being thrown, throw the<br>
>> HttpException correctly, and in the registrar check for 30x and then rerun<br>
>> the operation [2]<br>
>><br>
>> 3) We let the HttpException escape to the callback handler<br>
>><br>
>> We don't like the option 1, because increases complexity in the<br>
>> HttpRestProvider class and it hides the 30x messages from the developers<br>
>> should they want to handle them. Furthermore, Summers argues that since<br>
>> the registration code is being called often it would be better for the<br>
>> developer to be aware of them and have to handle them in her code instead<br>
>> of ours. In short, if there are redirects then the developer should be<br>
>> made aware so she can update her URL and make fewer HTTP requests (this is<br>
>> important on mobile for battery life, data caps, etc).<br>
>><br>
>> [1]<br>
>> <a href="https://github.com/aerogear/aerogear-android/blob/master/src/org/jboss/aerogear/android/impl/http/HttpRestProvider.java#L256" target="_blank">https://github.com/aerogear/aerogear-android/blob/master/src/org/jboss/aerogear/android/impl/http/HttpRestProvider.java#L256</a><br>
>> [2]<br>
>> <a href="https://github.com/aerogear/aerogear-android/blob/master/src/org/jboss/aerogear/android/impl/unifiedpush/AeroGearGCMPushRegistrar.java#L139-L144" target="_blank">https://github.com/aerogear/aerogear-android/blob/master/src/org/jboss/aerogear/android/impl/unifiedpush/AeroGearGCMPushRegistrar.java#L139-L144</a><br>
>><br>
>> So, wdyt?<br>
>><br>
>><br>
>><br>
>> On Tue, May 6, 2014 at 6:47 AM, Sebastien Blanc <<a href="mailto:scm.blanc@gmail.com">scm.blanc@gmail.com</a>> wrote:<br>
>><br>
>>> Hi !<br>
>>> I just gave it a test with the Push HelloWorld :<br>
>>><br>
>>> - <a href="https://issues.jboss.org/browse/AGPUSH-627" target="_blank">https://issues.jboss.org/browse/AGPUSH-627</a> is fixed , I'm getting a<br>
>>> nice error notification on the device<br>
>>><br>
>>> - <a href="https://issues.jboss.org/browse/AGDROID-214" target="_blank">https://issues.jboss.org/browse/AGDROID-214</a> -> I'm getting exactly the<br>
>>> same issue as Matzew , looks like the redirect is not working.<br>
>>><br>
>>> Sebi<br>
>>><br>
>>><br>
>>><br>
>>> On Fri, May 2, 2014 at 5:06 PM, Daniel Passos <<a href="mailto:daniel@passos.me">daniel@passos.me</a>> wrote:<br>
>>><br>
>>>> We have found a bug[1] in the AeroGear Android Push 0.1. It was fixed and<br>
>>>> the new version (0.1.1) was already sent to nexus[2].<br>
>>>><br>
>>>> We'd like to ship it to Maven central next wednesday.<br>
>>>><br>
>>>> [1] <a href="https://issues.jboss.org/browse/AGDROID-214" target="_blank">https://issues.jboss.org/browse/AGDROID-214</a><br>
>>>> [2]<br>
>>>> <a href="http://repository.jboss.org/nexus/content/repositories/jboss_releases_staging_profile-3139/" target="_blank">http://repository.jboss.org/nexus/content/repositories/jboss_releases_staging_profile-3139/</a><br>
>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> aerogear-dev mailing list<br>
>>>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
>>>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
>>>><br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> aerogear-dev mailing list<br>
>>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
>>><br>
><br>
>> _______________________________________________<br>
>> aerogear-dev mailing list<br>
>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
><br>
><br>
> --<br>
><br>
> abstractj<br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
<br>
<br>
</div></div>--<br>
Summers Pittman<br>
>>Phone:404 941 4698<br>
>>Java is my crack.<br>
<div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>