<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 6, 2014 at 4:19 PM, Daniel Passos <span dir="ltr"><<a href="mailto:daniel@passos.me" target="_blank">daniel@passos.me</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Talking with Summers about what is the best options to solved that, we have some options:<br></div>
<div><br></div><div>1) Catch the 302 and handle it inside of the rest provider. [1]</div><div><br></div>
<div>2) We can fix the IOException which is being thrown, throw the HttpException correctly, and in the registrar check for 30x and then rerun the operation [2]</div></div></blockquote><div><br></div><div>yes! </div><div>
<br></div><div>+ add a (fatal/warning) log message</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>3) We let the HttpException escape to the callback handler </div>
<div><br></div><div>We don't like the option 1, because increases complexity in the HttpRestProvider class and it hides the 30x messages from the developers should they want to handle them. Furthermore, Summers argues that since the registration code is being called often it would be better for the developer to be aware of them and have to handle them in her code instead of ours. </div>
</div></blockquote><div><br></div><div>sure, but IMO a 30x should be respected. Let's add a warning, so their logcat tells them when they are testing</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div> In short, if there are redirects then the developer should be made aware so she can update her URL and make fewer HTTP requests (this is important on mobile for battery life, data caps, etc).</div>
<div><br></div><div>[1] <a href="https://github.com/aerogear/aerogear-android/blob/master/src/org/jboss/aerogear/android/impl/http/HttpRestProvider.java#L256" target="_blank">https://github.com/aerogear/aerogear-android/blob/master/src/org/jboss/aerogear/android/impl/http/HttpRestProvider.java#L256</a></div>
<div>[2] <a href="https://github.com/aerogear/aerogear-android/blob/master/src/org/jboss/aerogear/android/impl/unifiedpush/AeroGearGCMPushRegistrar.java#L139-L144" target="_blank">https://github.com/aerogear/aerogear-android/blob/master/src/org/jboss/aerogear/android/impl/unifiedpush/AeroGearGCMPushRegistrar.java#L139-L144</a></div>
<div><br></div><div>So, wdyt?</div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, May 6, 2014 at 6:47 AM, Sebastien Blanc <span dir="ltr"><<a href="mailto:scm.blanc@gmail.com" target="_blank">scm.blanc@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi ! <div>I just gave it a test with the Push HelloWorld : </div><div><br></div><div>- <a href="https://issues.jboss.org/browse/AGPUSH-627" target="_blank">https://issues.jboss.org/browse/AGPUSH-627</a> is fixed , I'm getting a nice error notification on the device</div>
<div><br></div><div>- <a href="https://issues.jboss.org/browse/AGDROID-214" style="font-family:monospace;font-size:12px;line-height:16px" target="_blank">https://issues.jboss.org/browse/AGDROID-214</a> -> I'm getting exactly the same issue as Matzew , looks like the redirect is not working. </div>
<div><br></div><div>Sebi</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Fri, May 2, 2014 at 5:06 PM, Daniel Passos <span dir="ltr"><<a href="mailto:daniel@passos.me" target="_blank">daniel@passos.me</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div style="margin:0px;padding:0px"><div style="margin:0px;padding:0px">
<font color="#000000" face="monospace"><span style="font-size:12px;line-height:16px">We have found a bug[1] in the AeroGear Android Push 0.1. It was fixed and the new version (0.1.1) was already sent to nexus[2]. </span></font></div>
<div style="margin:0px;padding:0px"><font color="#000000" face="monospace"><span style="font-size:12px;line-height:16px"><br></span></font></div><div style="margin:0px;padding:0px">
<font color="#000000" face="monospace"><span style="font-size:12px;line-height:16px">We'd like to ship it to Maven central next wednesday.</span></font></div><div style="margin:0px;padding:0px">
<font color="#000000" face="monospace"><span style="font-size:12px;line-height:16px"><br></span></font></div><div style="margin:0px;padding:0px"><font color="#000000" face="monospace"><span style="font-size:12px;line-height:16px">[1] <a href="https://issues.jboss.org/browse/AGDROID-214" target="_blank">https://issues.jboss.org/browse/AGDROID-214</a></span></font></div>
<div style="margin:0px;padding:0px"><font color="#000000" face="monospace"><span style="font-size:12px;line-height:16px">[2] <a href="http://repository.jboss.org/nexus/content/repositories/jboss_releases_staging_profile-3139/" target="_blank">http://repository.jboss.org/nexus/content/repositories/jboss_releases_staging_profile-3139/</a></span></font></div>
<div style="color:rgb(0,0,0);font-family:monospace;font-size:12px;line-height:16px"><br></div></div></div>
<br></div></div>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>