<div dir="ltr"><div class="gmail_extra">Answer inline<br><br><div class="gmail_quote">On Fri, Jun 6, 2014 at 7:05 AM, Karel Piwko <span dir="ltr"><<a href="mailto:kpiwko@redhat.com" target="_blank">kpiwko@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi All,<br>
<br>
I went through Android demo (and JBDS) and created following PR:<br>
<br>
<a href="https://github.com/aerogear/aerogear-push-helloworld/pull/18" target="_blank">https://github.com/aerogear/aerogear-push-helloworld/pull/18</a><br>
<br>
Let me know if you want to have separate PRs per commit. Goal was to have<br>
example working in Eclipse/JBDS + ADT. There is still manual steps to do and<br>
an error I was not able to fix it completely, investigating.<br>
<br>
As per commit:<br>
<br>
1/ Fixes Eclipse error marker for maven-android-plugin. AAR is not used, so it<br>
is fine.<br>
<br>
2/ Quickstart/demos should not have any parent, Maven best practice. Check JDF<br>
quickstarts. Quickstart is an example and it is used to by user to scaffold<br>
their own apps. We don't want them to use ag-parent but just ag-bom.<br></blockquote><div><br></div><div><div>Not sure why it's so bad. parent-pom is releases in maven central so, the community can use it. I think a notice in the README explaining why we are using it is good.</div>
<div><br></div><div>parent-pom has some nice plugins like formatter, license header, etc... Should we do it manually or put this plugins in the project pom? </div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
3/ If project.properties is missing, Eclipse is not able to add Android SDK to<br>
build path. I've set it to API 19. This means that user has to point ADT to<br>
Android SDK with API 19 installed. This is also version Eclipse will use for<br>
code suggestion/autocompletion/build in IDE. Should have been API 10, I'm not<br>
sure here.<br></blockquote><div><br></div><div>Always use the same of targetSdkVersion. So, it's correctly ;)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
4/ Dependencies in <dependencyManagement> should not define any scope with<br>
exception of *import*. Maven best practice.<br></blockquote><div><br></div><div>+1 Good catch.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
5/ If user don't provide UNIFIED_PUSH_URL, application fails due to<br>
RuntimeException. I've added catch for IAE and Toast, however I believe there<br>
should be a better way how to indicate that to user. IAE is quite generic and<br>
fired from URLUtils in GCM registar. I'll file an issue to improve that.<br></blockquote><div><br></div><div>+1</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
6/ /bin directory is used by default by Eclipse to host temporary build<br></blockquote><div> </div><div>+1 Maybe is a good ideia copy the cookbook .gitignore </div><div><a href="https://github.com/aerogear/aerogear-android-cookbook/blob/master/.gitignore">https://github.com/aerogear/aerogear-android-cookbook/blob/master/.gitignore</a></div>
<div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
After these steps, I needed to follow these manual steps:<br>
<br>
a/ Import android-support-v7-appcompat from Android SDK into workspace as<br>
Android project<br>
b/ Import hellopush/android as Maven project<br>
c/ Add android-support-v7-appcompat as library in Android tab of project<br>
properties<br>
<br>
Now, I can edit the code. However, I can't use Run As/Android<br>
Application still, likely due to <a href="http://tinypic.com/r/260ejpl/8" target="_blank">http://tinypic.com/r/260ejpl/8</a></blockquote><div><br></div><div>Not sure what is going on, but I'll take a look at it next week. Could you fire a jira for me? </div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
I'd appreciate if somebody could verify it is still working with AndroidStudio.<br></blockquote><div><br></div><div>I just run it in Android Studio and IntelliJ. I don't know how, but all still working :P</div><div>
<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Thanks,<br>
<br>
Karel</blockquote></div></div></div>