<div dir="ltr">+1 on that!<div><br></div><div>Should we do that for the 0.11 ? Or after? </div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 11, 2014 at 3:38 PM, Karel Piwko <span dir="ltr"><<a href="mailto:kpiwko@redhat.com" target="_blank">kpiwko@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1 on not having separate table per variant type and using different<br>
inheritance model here - for instance a discriminator column.<br>
<br>
Karel<br>
<div><div class="h5"><br>
On Wed, 11 Jun 2014 15:14:21 +0200<br>
Erik Jan de Wit <<a href="mailto:edewit@redhat.com">edewit@redhat.com</a>> wrote:<br>
<br>
> Hi,<br>
><br>
> Right now the domain model of the UnifiedPush Server has the variants split<br>
> into separate collections.<br>
><br>
> <a href="https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/PushApplication.java#L44-L50" target="_blank">https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/PushApplication.java#L44-L50</a><br>
><br>
> This could be improved to only use one collection, we’ll get more<br>
> extendibility (adding another variant type for instance) and remove code like<br>
> this:<br>
><br>
> <a href="https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/jpa/src/main/java/org/jboss/aerogear/unifiedpush/jpa/dao/impl/JPAPushApplicationDao.java#L93-L96" target="_blank">https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/jpa/src/main/java/org/jboss/aerogear/unifiedpush/jpa/dao/impl/JPAPushApplicationDao.java#L93-L96</a><br>
><br>
> In places where you only want the iOS variants for instance you could either<br>
> query them, or have a getter that collects them by type.<br>
><br>
> What do you think?<br>
><br>
> Cheers,<br>
> Erik Jan<br>
><br>
<br>
</div></div>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>