<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi,<div><br></div><div>Right now the domain model of the UnifiedPush Server has the variants split into separate collections. </div><div><br></div><div><a href="https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/PushApplication.java#L44-L50">https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/PushApplication.java#L44-L50</a></div><div><br></div><div>This could be improved to only use one collection, we’ll get more extendibility (adding another variant type for instance) and remove code like this:</div><div><br></div><div><a href="https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/jpa/src/main/java/org/jboss/aerogear/unifiedpush/jpa/dao/impl/JPAPushApplicationDao.java#L93-L96">https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/jpa/src/main/java/org/jboss/aerogear/unifiedpush/jpa/dao/impl/JPAPushApplicationDao.java#L93-L96</a></div><div><br></div><div>In places where you only want the iOS variants for instance you could either query them, or have a getter that collects them by type.</div><div><br></div><div>What do you think?</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>Cheers,</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>Erik Jan</div><div><br></div></body></html>