<div dir="ltr">Fix has been merged <a href="https://github.com/aerogear/aerogear-unifiedpush-server/commit/422ce476b2c95b63a47a43f6495a02ef7780049a">https://github.com/aerogear/aerogear-unifiedpush-server/commit/422ce476b2c95b63a47a43f6495a02ef7780049a</a><br>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 1, 2014 at 8:55 AM, Sebastien Blanc <span dir="ltr"><<a href="mailto:scm.blanc@gmail.com" target="_blank">scm.blanc@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">
<div class="">On Tue, Jul 1, 2014 at 8:42 AM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br>
</div><div class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Sebi,<div class="gmail_extra">
<br><br><div class="gmail_quote"><div>On Tue, Jul 1, 2014 at 1:20 AM, Sebastien Blanc <span dir="ltr"><<a href="mailto:scm.blanc@gmail.com" target="_blank">scm.blanc@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">
<div>On Mon, Jun 30, 2014 at 6:14 PM, Bruno Oliveira <span dir="ltr"><<a href="mailto:bruno@abstractj.org" target="_blank">bruno@abstractj.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi Matthias, I think we're in a good shape. We have 3 PR to be reviewed:<br>
<br>
- <a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/154" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/pull/154</a><br>
I would vote to postpone it for further releases<br></blockquote></div><div>+1 </div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
- <a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/250" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/pull/250</a><br>
It seems like ready to go<br></blockquote></div><div>+1 (just a small ui thing that could be better but we can see that later) </div></div></div></div></blockquote><div><br></div></div><div>can you send a PR for that change ? </div>
</div></div></div></blockquote></div><div>Apparently, Erik, aka Flash Gordon, as already a PR for that ;) </div><div><div class="h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">
<div class="gmail_extra"><div class="gmail_quote"><div><div>
<div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">
<div class="gmail_extra"><div class="gmail_quote"><div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
- <a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/253" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/pull/253</a><br>
Need some feedback<br></blockquote></div><div>feedback given </div><div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Regarding the Keycloak integration, I reasssigned AGPUSH-568 to myself,<br>
but let me know if you want to be in charge of it.<br>
<div><div><br>
On 2014-06-30, Matthias Wessendorf wrote:<br>
> Hello,<br>
><br>
> while waiting for my flight back home I was looking over the open PRs and<br>
> added a few comments:<br>
> * <a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/250" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/pull/250</a><br>
> * <a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/249" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/pull/249</a><br>
> * <a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/244" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/pull/244</a><br>
> * <a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/243" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/pull/243</a><br>
><br>
><br>
> Besides those, there are three open tickets, which I'd like to see fixed<br>
> for the 0.11:<br>
> <a href="https://issues.jboss.org/browse/AGPUSH/fixforversion/12321883/?selectedTab=com.atlassian.jira.jira-projects-plugin:version-issues-panel" target="_blank">https://issues.jboss.org/browse/AGPUSH/fixforversion/12321883/?selectedTab=com.atlassian.jira.jira-projects-plugin:version-issues-panel</a><br>
><br>
> Any thoughts?<br>
> -Matthias<br>
><br>
><br>
><br>
><br>
> --<br>
> Matthias Wessendorf<br>
><br>
> blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
> sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
> twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a><br>
><br>
><br>
> --<br>
> Sent from Gmail Mobile<br>
<br>
</div></div><div>> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
<br>
</div>--<br>
<br>
abstractj<br>
<div><div>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</div></div></blockquote></div></div></div><br></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div></div></div><div><div><br><br clear="all"><div><br>
</div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>