<div dir="ltr">Hi Erik!<div><br></div><div>this JIRA:</div><div><a href="https://issues.jboss.org/browse/AGPUSH-629">https://issues.jboss.org/browse/AGPUSH-629</a><br></div><div><br></div><div>and its PR (<a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/271">https://github.com/aerogear/aerogear-unifiedpush-server/pull/271</a>) are related here, right ? </div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 11, 2014 at 3:14 PM, Erik Jan de Wit <span dir="ltr"><<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hi,<div><br></div><div>Right now the domain model of the UnifiedPush Server has the variants split into separate collections. </div>
<div><br></div><div><a href="https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/PushApplication.java#L44-L50" target="_blank">https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/PushApplication.java#L44-L50</a></div>
<div><br></div><div>This could be improved to only use one collection, we’ll get more extendibility (adding another variant type for instance) and remove code like this:</div><div><br></div><div><a href="https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/jpa/src/main/java/org/jboss/aerogear/unifiedpush/jpa/dao/impl/JPAPushApplicationDao.java#L93-L96" target="_blank">https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/jpa/src/main/java/org/jboss/aerogear/unifiedpush/jpa/dao/impl/JPAPushApplicationDao.java#L93-L96</a></div>
<div><br></div><div>In places where you only want the iOS variants for instance you could either query them, or have a getter that collects them by type.</div><div><br></div><div>What do you think?</div><div><br></div><div>
<span style="white-space:pre-wrap"> </span>Cheers,</div><div><span style="white-space:pre-wrap"> </span>Erik Jan</div><div><br></div></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>