<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jul 16, 2014 at 5:32 PM, Bruno Oliveira <span dir="ltr"><<a href="mailto:bruno@abstractj.org" target="_blank">bruno@abstractj.org</a>></span> wrote:</div>
<div class="gmail_quote"><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">but I can't understand why we need to build<br>
the admin-ui on CI if we don't have any tests on it, is pretty much npm<br>
install + bower install and grunt tasks copying files.<br></blockquote><div><br></div><div>IMO that's part of the build - without the copying and node tools, the produced WAR is useless</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thoughts?<br>
<div><div class="h5"><br>
On 2014-07-15, Sebastien Blanc wrote:<br>
> Ok,<br>
> Some extra info :<br>
> As suggested I tried to update Bower to 1.3.8 :<br>
> -<br>
> <a href="https://github.com/aerogear/aerogear-unifiedpush-server/commit/87dadc04ab2c0bfbb482706ecba5ab55d04ae30c" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/commit/87dadc04ab2c0bfbb482706ecba5ab55d04ae30c</a><br>
> But that did not helped , maybe the maven frontend pugin overides the Bower<br>
> version, looking at this now<br>
><br>
> BUT, on twitter someone suggested this :<br>
> <a href="https://twitter.com/chrisfrancis27/status/488701380207448064" target="_blank">https://twitter.com/chrisfrancis27/status/488701380207448064</a><br>
><br>
> Basically adding a "temp" dependencies to package.json , o_0 => indeed but<br>
> it WORKS :<br>
><br>
> <a href="https://travis-ci.org/aerogear/aerogear-unifiedpush-server/builds/29953927" target="_blank">https://travis-ci.org/aerogear/aerogear-unifiedpush-server/builds/29953927</a><br>
> !<br>
><br>
> So good news , with this "temp" dep we can build again and in the same time<br>
> let's find out how we can update bower<br>
><br>
><br>
> On Tue, Jul 15, 2014 at 9:21 AM, Matthias Wessendorf <<a href="mailto:matzew@apache.org">matzew@apache.org</a>><br>
> wrote:<br>
><br>
> ><br>
> ><br>
> > On Tuesday, July 15, 2014, tolis emmanouilidis <<a href="mailto:tolisemm@gmail.com">tolisemm@gmail.com</a>> wrote:<br>
> ><br>
> >> +1 Sebi<br>
> >><br>
> >> The builds started failing 3 days ago. 3 days ago bower (<br>
> >> <a href="https://www.npmjs.org/package/bower" target="_blank">https://www.npmjs.org/package/bower</a>) was updated to v1.3.8.<br>
> >><br>
> >> The last successful Travis UPS build logs contains bower@1.3.7<br>
> >> node_modules/bower.<br>
> >> The rest failed successful Travis UPS build logs contain bower@1.3.8<br>
> >> node_modules/bower<br>
> >><br>
> >> Maybe enforcing bower version 1.3.7 will resolve the issue.<br>
> >><br>
> ><br>
> ><br>
> > +9001<br>
> > We should lock all versions :-)<br>
> ><br>
> ><br>
> >><br>
> >><br>
> >> 2014-07-15 9:50 GMT+03:00 Sebastien Blanc <<a href="mailto:scm.blanc@gmail.com">scm.blanc@gmail.com</a>>:<br>
> >><br>
> >>> Looks like Bower is aware of this issue :<br>
> >>> <a href="https://twitter.com/bower/status/487704111832252417" target="_blank">https://twitter.com/bower/status/487704111832252417</a><br>
> >>> Let me check if I can do something<br>
> >>><br>
> >>><br>
> >>><br>
> >>> On Tue, Jul 15, 2014 at 8:34 AM, Christos Vasilakis <<a href="mailto:cvasilak@gmail.com">cvasilak@gmail.com</a>><br>
> >>> wrote:<br>
> >>><br>
> >>>> Hi,<br>
> >>>><br>
> >>>> the same failure output "[INFO] Fatal error: Arguments to path.join<br>
> >>>> must be strings" have been noticed also when building liveoak<br>
> >>>> 'master'. I suspect some change on the nodes tools broke builds.. :(<br>
> >>>><br>
> >>>><br>
> >>>> [1] <a href="https://projectodd.ci.cloudbees.com/job/liveoak/371/console" target="_blank">https://projectodd.ci.cloudbees.com/job/liveoak/371/console</a><br>
> >>>><br>
> >>>><br>
> >>>><br>
> >>>> On Tue, Jul 15, 2014 at 9:07 AM, Matthias Wessendorf <<a href="mailto:matzew@apache.org">matzew@apache.org</a><br>
> >>>> > wrote:<br>
> >>>><br>
> >>>>> Hi,<br>
> >>>>><br>
> >>>>> since Friday, all in a sudden, the node.js part of the build<br>
> >>>>> (triggered by the frontend plugin inside the 'server' module) is failing on<br>
> >>>>> different ways.<br>
> >>>>><br>
> >>>>> Extremely odd: the 0.11.0 tag is effected as well. The release (on<br>
> >>>>> maven central) is good, but ATM we are not able to build the source on the<br>
> >>>>> 0.11.0 tag :-(<br>
> >>>>><br>
> >>>>> Oh, yeah, Travis-CI notice the broken build as well ;-) and thankfully<br>
> >>>>> abstractj put in a PR to have a temporary fix for the build failure:<br>
> >>>>> <a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/293" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/pull/293</a><br>
> >>>>><br>
> >>>>> Thanks Bruno!<br>
> >>>>><br>
> >>>>> Yesterday Bruno, Villiam and Luke looked at this already, and they<br>
> >>>>> noticed a failure like this:<br>
> >>>>><br>
> >>>>> [INFO] --- frontend-maven-plugin:0.0.15:npm (npm install) @ unifiedpush-server ---<br>
> >>>>> [INFO] Running 'npm install --color=false' in /home/travis/build/aerogear/aerogear-unifiedpush-server/admin-ui<br>
> >>>>> [INFO] npm WARN package.json newadmin@0.0.0 No repository field.<br>
> >>>>> [INFO]<br>
> >>>>> [INFO] --- frontend-maven-plugin:0.0.15:grunt (grunt build) @ unifiedpush-server ---<br>
> >>>>> [INFO] Running 'grunt dist --no-color' in /home/travis/build/aerogear/aerogear-unifiedpush-server/admin-ui<br>
> >>>>> [INFO] >> Local Npm module "grunt-cli" not found. Is it installed?<br>
> >>>>> [INFO]<br>
> >>>>> [INFO] Running "bower:install" (bower) task<br>
> >>>>> [INFO] Fatal error: Arguments to path.join must be strings<br>
> >>>>> [INFO] ------------------------------------------------------------------------<br>
> >>>>> [INFO] Reactor Summary:<br>
> >>>>><br>
</div></div>> >>>>> Note: "grunt-cli" *IS* installed, even globally. If I am correct, at<br>
<div><div class="h5">> >>>>> the moment we are not 100% sure what the "Fatal error: Arguments to<br>
> >>>>> path.join must be strings" really means...<br>
> >>>>><br>
> >>>>> On my machine, I noticed the npm stuff downloads half of the internet,<br>
> >>>>> but gets stuck in the middle:<br>
> >>>>><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/oauth-sign" target="_blank">https://registry.npmjs.org/oauth-sign</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/aws-sign2" target="_blank">https://registry.npmjs.org/aws-sign2</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/hawk" target="_blank">https://registry.npmjs.org/hawk</a><br>
> >>>>> [INFO] npm http GET <a href="https://registry.npmjs.org/combined-stream" target="_blank">https://registry.npmjs.org/combined-stream</a><br>
> >>>>> [INFO] npm http GET <a href="https://registry.npmjs.org/async" target="_blank">https://registry.npmjs.org/async</a><br>
> >>>>> [INFO] npm http GET <a href="https://registry.npmjs.org/assert-plus" target="_blank">https://registry.npmjs.org/assert-plus</a><br>
> >>>>> [INFO] npm http GET <a href="https://registry.npmjs.org/asn1" target="_blank">https://registry.npmjs.org/asn1</a><br>
> >>>>> [INFO] npm http GET <a href="https://registry.npmjs.org/ctype" target="_blank">https://registry.npmjs.org/ctype</a><br>
> >>>>> [INFO] npm http GET <a href="https://registry.npmjs.org/punycode" target="_blank">https://registry.npmjs.org/punycode</a><br>
> >>>>> [INFO] npm http GET <a href="https://registry.npmjs.org/hoek" target="_blank">https://registry.npmjs.org/hoek</a><br>
> >>>>> [INFO] npm http GET <a href="https://registry.npmjs.org/boom" target="_blank">https://registry.npmjs.org/boom</a><br>
> >>>>> [INFO] npm http GET <a href="https://registry.npmjs.org/sntp" target="_blank">https://registry.npmjs.org/sntp</a><br>
> >>>>> [INFO] npm http GET <a href="https://registry.npmjs.org/cryptiles" target="_blank">https://registry.npmjs.org/cryptiles</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/async" target="_blank">https://registry.npmjs.org/async</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/combined-stream" target="_blank">https://registry.npmjs.org/combined-stream</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/assert-plus" target="_blank">https://registry.npmjs.org/assert-plus</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/asn1" target="_blank">https://registry.npmjs.org/asn1</a><br>
> >>>>> [INFO] npm http GET <a href="https://registry.npmjs.org/delayed-stream" target="_blank">https://registry.npmjs.org/delayed-stream</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/ctype" target="_blank">https://registry.npmjs.org/ctype</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/punycode" target="_blank">https://registry.npmjs.org/punycode</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/boom" target="_blank">https://registry.npmjs.org/boom</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/hoek" target="_blank">https://registry.npmjs.org/hoek</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/cryptiles" target="_blank">https://registry.npmjs.org/cryptiles</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/sntp" target="_blank">https://registry.npmjs.org/sntp</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/delayed-stream" target="_blank">https://registry.npmjs.org/delayed-stream</a><br>
> >>>>><br>
> >>>>> Now, after more than one hour of 'waiting', I cancled the build,<br>
> >>>>> resulting in:<br>
> >>>>><br>
> >>>>> [INFO] > optipng-bin@0.3.9 postinstall /Users/matzew/Work/JBoss/UPS/admin-ui/node_modules/grunt-contrib-imagemin/node_modules/imagemin/node_modules/imagemin-optipng/node_modules/optipng-bin<br>
> >>>>> [INFO] > node index.js<br>
> >>>>> [INFO]<br>
> >>>>> [INFO] ✓ pre-build test passed successfully<br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/hoek" target="_blank">https://registry.npmjs.org/hoek</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/boom" target="_blank">https://registry.npmjs.org/boom</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/cryptiles" target="_blank">https://registry.npmjs.org/cryptiles</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/sntp" target="_blank">https://registry.npmjs.org/sntp</a><br>
> >>>>> [INFO] npm http 304 <a href="https://registry.npmjs.org/delayed-stream" target="_blank">https://registry.npmjs.org/delayed-stream</a><br>
> >>>>> ^C[INFO] ------------------------------------------------------------------------<br>
> >>>>> [INFO] Reactor Summary:<br>
> >>>>> [INFO]<br>
> >>>>> [INFO] AeroGear UnifiedPush Server ....................... SUCCESS [3.884s]<br>
> >>>>> [INFO] UnifiedPush Model Layer ........................... SUCCESS [0.146s]<br>
> >>>>> [INFO] UnifiedPush Server Model API ...................... SUCCESS [2.699s]<br>
> >>>>> [INFO] UnifiedPush Server Model JPA implementation ....... SUCCESS [15.036s]<br>
> >>>>> [INFO] UnifiedPush Service Layer ......................... SUCCESS [7.757s]<br>
> >>>>> [INFO] UnifiedPush Push Notification Networks ............ SUCCESS [2.009s]<br>
> >>>>> [INFO] UnifiedPush RESTful Endpoint ...................... SUCCESS [2.811s]<br>
> >>>>> [INFO] UnifiedPush Server (WAR) .......................... FAILURE [1:30:54.769s]<br>
> >>>>> [INFO] UnifiedPush Auth Server ........................... SKIPPED<br>
> >>>>> [INFO] ------------------------------------------------------------------------<br>
> >>>>> [INFO] BUILD FAILURE<br>
> >>>>> [INFO] ------------------------------------------------------------------------<br>
> >>>>> [INFO] Total time: 1:31:29.994s<br>
> >>>>> [INFO] Finished at: Tue Jul 15 07:48:37 CEST 2014<br>
> >>>>> [INFO] Final Memory: 80M/191M<br>
> >>>>> [INFO] ------------------------------------------------------------------------<br>
> >>>>> [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.15:npm (npm install) on project unifiedpush-server: 'npm install --color=false' failed. (error code 130) -> [Help 1]<br>
> >>>>> [ERROR]<br>
> >>>>> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.<br>
> >>>>> [ERROR] Re-run Maven using the -X switch to enable full debug logging.<br>
> >>>>> [ERROR]<br>
> >>>>> [ERROR] For more information about the errors and possible solutions, please read the following articles:<br>
> >>>>> [ERROR] [Help 1] <a href="http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException" target="_blank">http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException</a><br>
> >>>>> [ERROR]<br>
> >>>>> [ERROR] After correcting the problems, you can resume the build with the command<br>
> >>>>> [ERROR] mvn <goals> -rf :unifiedpush-server<br>
> >>>>><br>
> >>>>> This is more a FYI on what's going on - I will file a JIRA ticket for<br>
> >>>>> that;<br>
> >>>>><br>
</div></div>> >>>>> *PS:* According to yesterday's IRC discussions, a manual `grunt server does<br>
> >>>>> work, so development is not*directly* effected<br>
<div><div class="h5">> >>>>><br>
> >>>>> -Matthias<br>
> >>>>><br>
> >>>>> --<br>
> >>>>> Matthias Wessendorf<br>
> >>>>><br>
> >>>>> blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
> >>>>> sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
> >>>>> twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a><br>
> >>>>><br>
> >>>>> _______________________________________________<br>
> >>>>> aerogear-dev mailing list<br>
> >>>>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> >>>>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> >>>>><br>
> >>>><br>
> >>>><br>
> >>>> _______________________________________________<br>
> >>>> aerogear-dev mailing list<br>
> >>>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> >>>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> >>>><br>
> >>><br>
> >>><br>
> >>> _______________________________________________<br>
> >>> aerogear-dev mailing list<br>
> >>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> >>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> >>><br>
> >><br>
> >><br>
> ><br>
> > --<br>
> > Sent from Gmail Mobile<br>
> ><br>
> > _______________________________________________<br>
> > aerogear-dev mailing list<br>
> > <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> ><br>
<br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
<br>
--<br>
<br>
</div></div>abstractj<br>
<div class="HOEnZb"><div class="h5">_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>