<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 25, 2014 at 12:25 PM, Tadeas Kriz <span dir="ltr"><<a href="mailto:tkriz@redhat.com" target="_blank">tkriz@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div>
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div>—</div><div>Tadeas Kriz</div></div>
</div>
<br><div><div class=""><div>On 25 Jul 2014, at 11:04 am, Daniel Bevenius <<a href="mailto:daniel.bevenius@gmail.com" target="_blank">daniel.bevenius@gmail.com</a>> wrote:</div><br><blockquote type="cite"><div dir="ltr">
><span style="font-family:arial,sans-serif;font-size:13px">5. don’t use the url as a deviceToken (might not comply with Mozzila’s SimplePush specs)</span><div><span style="font-family:arial,sans-serif;font-size:13px">The deviceToken is an UPS concept and there is nothing in the SimplePush spec which is violated in this case. </span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div></div></blockquote></div><div>I thought that deviceTokens were changed from a generated value to the URL just to comply with Mozzila’s SimplePush specs. </div>
</div></div></blockquote><div><br></div><div>Nope</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div>Matzew, why was the generated token removed then?</div>
</div></div></blockquote><div><br></div><div>It was the channelID before - but that should not be exposed.</div><div>In GCM devices are identified via registrationID</div><div>In APNs devices are identified va deviceToken</div>
<div>(both are somewhat the same - but different names)</div><div><br></div><div>In SimplePush devices are identifeid v/ the URL of the pushEndpoint (a backend uses that endpoint to notify _THAT_ client, regardless of how many channels it has subscribed)</div>
<div><br></div><div>So, that lead us to make the change (see history of this threa)</div><div><br></div><div>-M </div><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><div class=""><br><blockquote type="cite"><div dir="ltr"><div><span style="font-family:arial,sans-serif;font-size:13px">I'm not sure about what the best option is for UPS thought. Would a regex in for the @Path annotation work perhaps, something like:</span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px"> </span></div><div><div><font face="arial, sans-serif">@DELETE</font></div><div><font face="arial, sans-serif">@Path("{token, .+}")</font></div>
<div><font face="arial, sans-serif">public Response unregisterInstallations(</font></div></div></div><div class="gmail_extra"><br></div></blockquote><div><br></div></div><div>What do you mean by that regex? The problem is simply the “%2F” in the token (which is an URLencoded simplepush url) and it’s being revoked long before it hits the RestEasy (which does the routing according to what’s in the @Path).</div>
<div><div class="h5"><br><blockquote type="cite"><div class="gmail_extra"><br><div class="gmail_quote">On 25 July 2014 10:32, Tadeas Kriz <span dir="ltr"><<a href="mailto:tkriz@redhat.com" target="_blank">tkriz@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
—<br>
Tadeas Kriz<br>
<br>
On 24 Jul 2014, at 05:44 pm, Karel Piwko <<a href="mailto:kpiwko@redhat.com" target="_blank">kpiwko@redhat.com</a>> wrote:<br>
<br>
> On Thu, Jul 24, 2014 at 3:28 PM, Tadeas Kriz <<a href="mailto:tkriz@redhat.com" target="_blank">tkriz@redhat.com</a>> wrote:<br>
>><br>
>> It should not. For hibernate, it’s just a string like any other.<br>
>> The problem might be in the configuration of <a href="http://jax.rs/RestEasy" target="_blank">JAX.RS/RestEasy</a>. If<br>
>> I’ll have some time today evening, I’ll try to fix it, it should<br>
>> be an easy fix.<br>
><br>
> Last famous words? ;-)<br>
><br>
<br>
I shall never say “an easy fix” again.<br>
<br>
> But I agree. Everything is string and URL encode should happen on<br>
> client while server should automatically decode and work always with<br>
> just decoded string. If we need to encode twice, something is wrong.<br>
><br>
<br>
Anyway, the 400 Bad request response is made by the tomcat itself, disallowing the use of %2F as a path parameter. This will probably apply on other web containers.<br>
<br>
Possible solutions with their disadvantages:<br>
<br>
1. well-documented double-encoding of the URL (might be confusing)<br>
2. use @QueryParam instead of @PathParam (breaks the api consistence, as every other call would still use @PathParam)<br>
3. allow @QueryParam (again, breaks the api consistence, but only for the SimplePush)<br>
4. find another encoding (Base64 for URL = URLEncode then Base64 encode)<br>
5. don’t use the url as a deviceToken (might not comply with Mozzila’s SimplePush specs)<br>
<br>
What do you think guys?<br>
<br>
>><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</blockquote></div><br></div>
_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></blockquote>
</div></div></div><br></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>