<div dir="ltr">+1 it should definitely point to the specific version</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 4, 2014 at 5:05 PM, Gorkem Ercan <span dir="ltr"><<a href="mailto:gorkem.ercan@gmail.com" target="_blank">gorkem.ercan@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi All, <div>I have been working cordova push quickstarts and noticed that on Android installation through JBoss tools started to fail. </div>
<div><br></div><div>After a bit of investigation I figured that the failure occurs because push plugin defines cordova plugin "com.google.playservices" as a dependency through a git URL[1] that points to the master of the plugin's repo. Unfortunately this repo received a change [2] which started to use a new feature that was not implemented for JBoss tools. In this particular case, I am already implementing the missing feature so it should be all good soon. However I have doubts that referencing a dependency through master is a good idea. I think it may not only make it really difficult for us to reproduce cases but also unexpected behaviour may just appear.</div>
<div><br></div><div><br></div><div>[1] <a href="https://github.com/MobileChromeApps/google-play-services" target="_blank">https://github.com/MobileChromeApps/google-play-services</a></div><div>[2] <a href="https://github.com/MobileChromeApps/google-play-services/commit/41c19152c21981c9a2f6497cc2100c317f5c660d" target="_blank">https://github.com/MobileChromeApps/google-play-services/commit/41c19152c21981c9a2f6497cc2100c317f5c660d</a></div>
</div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>