<div dir="ltr">From looking at the original proposal in this thread:<div><a href="https://gist.github.com/sebastienblanc/8897596" target="_blank">https://gist.github.com/sebastienblanc/8897596</a><br></div><div><br></div><div>and the actual PR:</div><div><a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/411">https://github.com/aerogear/aerogear-unifiedpush-server/pull/411</a><br></div><div><br></div><div>it looks like there is a mismatch. that is fine :)</div><div><br></div><div>However, I can't find a thread where the current proposal from the PR has been discussed;</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 22, 2014 at 2:38 PM, Sebastien Blanc <span dir="ltr"><<a href="mailto:scm.blanc@gmail.com" target="_blank">scm.blanc@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ok let me propose an approach on a PR and then we can discuss that. <div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 22, 2014 at 2:31 PM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Oct 22, 2014 at 2:28 PM, Sebastien Blanc <span dir="ltr"><<a href="mailto:scm.blanc@gmail.com" target="_blank">scm.blanc@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ok, so we should expose a more "rich" builder API ? </div></blockquote><div><br></div></span><div>yeah, perhaps - I have no concrete feeling on the API at the moment.</div><div>I think it would be nice to revisit the Java-Sender for the 1.1.x UPS version.</div><div><br></div><div>If something better comes out -> nice();</div><div><div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 22, 2014 at 2:26 PM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Oct 22, 2014 at 12:53 PM, Sebastien Blanc <span dir="ltr"><<a href="mailto:scm.blanc@gmail.com" target="_blank">scm.blanc@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi !<div>Since the UPS has its PR now [1], any comment on my question here below ? TLDR : Do we want to keep the same builder API (and just change the json send to UPS) ? </div></div></blockquote><div><br></div></span><div>oh, you mean the JAva-Sender API? Hrm.... I think, we can (or should?) update it. makes sense to have a sender 1.1.x, on master :) while keeping the "old" on 1.0.x branch</div><div><div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>Sebi</div><div><br></div><div>[1] <a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/411" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/pull/411</a></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 10, 2014 at 9:14 AM, Sebastien Blanc <span dir="ltr"><<a href="mailto:scm.blanc@gmail.com" target="_blank">scm.blanc@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Here a first question :<div>Do we want to change also how the Java Sender construct its message ?</div><div>Now we have a "plain" builder pattern, do we want now message.criteria.alias("fdfd") ? </div><div>I'm not sure</div><div>Sebi</div><div><br></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 10, 2014 at 9:01 AM, Sebastien Blanc <span dir="ltr"><<a href="mailto:scm.blanc@gmail.com" target="_blank">scm.blanc@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>Since the API Version PR [1] has been merged we can start the work on AGPUSH-534 to change the format of the Push message. There has been some discussions on this thread and this gist <a href="https://gist.github.com/sebastienblanc/8897596" target="_blank">https://gist.github.com/sebastienblanc/8897596</a> </div><div>Just want to be sure everyone is okay or have remarks before starting implementing this.</div><div><br></div><div>Questions ? </div><div><br></div><div>Sebi</div><div><br></div><div>[1] <a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/394" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/pull/394</a></div><div>[2] <a href="https://issues.jboss.org/browse/AGPUSH-534" target="_blank">https://issues.jboss.org/browse/AGPUSH-534</a></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Mon, Feb 10, 2014 at 4:46 PM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div><span><br><br>On Monday, February 10, 2014, Sebastien Blanc <<a href="mailto:scm.blanc@gmail.com" target="_blank">scm.blanc@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Feb 10, 2014 at 2:23 PM, Lucas Holmquist <span dir="ltr"><<a>lholmqui@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word">here is the current format for comparison<div><br></div><div><a href="https://gist.github.com/lholmquist/8915817" target="_blank">https://gist.github.com/lholmquist/8915817</a></div>
<div><br></div><div>+1 to being more structured.</div><div><br></div><div>one thing though, in the current format, simplePush is not part of the message, but it's own thing</div></div></blockquote><div>Yeah, that's why I put it in the config section in my first version but Matzew suggested it was more part of the message payload </div>
</div></div></div></blockquote><div><br></div><div><br></div></span><div>Nope to<span></span> config; should stay its own, does not (IMO) make sense to include in tve message for richer platforms like Android/iOS</div><div><div><div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<blockquote style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div><br><div><div>On Feb 9, 2014, at 9:06 AM, Sebastien Blanc <<a>scm.blanc@gmail.com</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr"><br><div><br><br><div>On Sun, Feb 9, 2014 at 2:14 PM, Matthias Wessendorf <span dir="ltr"><<a>matzew@apache.org</a>></span> wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div><br><br><div>
<div><div>On Sun, Feb 9, 2014 at 12:06 PM, Sebastien Blanc <span dir="ltr"><<a>scm.blanc@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hi,<div>I was looking at our current Push Message Format[1] and I was wonderimg if you should not add some more structure to it, decoupling config, criterias and the message itself : </div>
<div><br><div><br>
</div><div><pre style="line-height:12.800000190734863px;width:744px;font-size:12px;margin-bottom:0px;font-family:Consolas,'Liberation Mono',Courier,monospace;margin-top:0px;padding:0px"><div>
<span>{</span></div><div> <span style="color:navy">"config"</span> <span>:</span> <span>{</span></div><div>
<span style="color:navy">"ttl"</span> <span>:</span> <span style="color:rgb(0,153,153)">3600</span><span>,</span></div><div> <span style="color:navy">"content-available"</span> <span>:</span> <span style="font-weight:bold">true</span><span>,</span></div>
<div> <span style="color:navy">"simple-push"</span><span>:</span> <span style="color:rgb(221,17,68)">"version=123"</span></div><div>
<span>},</span></div><div> <span style="color:navy">"criteria"</span> <span>:</span> <span>{</span></div><div>
<span style="color:navy">"alias"</span> <span>:</span> <span>[</span><span style="color:rgb(221,17,68)">"<a>user@account.com</a>"</span><span>,</span> <span style="color:rgb(221,17,68)">"<a>someone@aerogear.org</a>"</span><span>,</span> <span style="color:rgb(166,23,23);background-color:rgb(227,210,210)">....</span><span>],</span></div>
<div> <span style="color:navy">"categories"</span> <span>:</span> <span>[</span><span style="color:rgb(221,17,68)">"someCategory"</span><span>,</span> <span style="color:rgb(221,17,68)">"otherCategory"</span><span>],</span></div>
<div> <span style="color:navy">"deviceType"</span> <span>:</span> <span>[</span><span style="color:rgb(221,17,68)">"iPad"</span><span>,</span> <span style="color:rgb(221,17,68)">"AndroidTablet"</span><span>],</span></div>
<div> <span style="color:navy">"variants"</span> <span>:</span> <span>[</span><span style="color:rgb(221,17,68)">"c3f0a94f-48de-4b77-a08e-68114460857e"</span><span>,</span> <span style="color:rgb(221,17,68)">"444939cd-ae63-4ce1-96a4-de74b77e3737"</span><span>]</span> </div>
<div> <span>}</span></div><div> <span>,</span></div><div> <span style="color:navy">"message"</span><span>:</span> <span>{</span></div>
<div> <span style="color:navy">"alert"</span><span>:</span><span style="color:rgb(221,17,68)">"HELLO!"</span><span>,</span></div>
<div> <span style="color:navy">"sound"</span><span>:</span><span style="color:rgb(221,17,68)">"default"</span><span>,</span></div>
<div> <span style="color:navy">"badge"</span><span>:</span><span style="color:rgb(0,153,153)">7</span><span>,</span></div><div>
<span style="color:navy">"someKey"</span><span>:</span><span style="color:rgb(221,17,68)">"some value"</span><span>,</span></div><div>
<span style="color:navy">"anotherCustomKey"</span><span>:</span><span style="color:rgb(221,17,68)">"some other value"</span></div><div>
<span>},</span></div><div> </div><div><span>}</span></div><div><span><br></span></div>
<div><span><span style="color:rgb(34,34,34);font-family:arial;font-size:small;line-height:normal;white-space:normal">wdyt ? </span><br></span></div><div></div></pre></div></div></div></blockquote><div><br></div></div></div>
<div>interesting idea - it looks better structured. </div>
<div><br></div><div>Re</div></div></div></div></blockquote></div></div></div></blockquote></div></div></div></div></div></blockquote></div><br></div></div>
</blockquote><br><br></div></div><span><font color="#888888">-- <br>Sent from Gmail Mobile<br>
</font></span><br></div></div><span>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></span></blockquote></div><br></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div></div></div><br><br clear="all"><span><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</span></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div></div></div></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div></div></div><div><div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>