<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 24, 2014 at 3:36 PM, Lucas Holmquist <span dir="ltr"><<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
So i’ve decided to take today and try and add Safari Push notifications into the UPS. When i tried about a year ago, i was successful, but i had lots of duplicated code since it is very close to the iOS variant.<br>
basically, the only real difference is that Safari notifications use the Production cert only. The other slight difference is how you send the message to the APNs service<br>
<br>
I wondering if now is the time to start changing the variant names, so iOSVariant would become APNsVariant(or something like that).<br></blockquote><div><br></div><div>+1</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
This would also change the endpoint at which we connect from ‘ios' to ‘apns’ . Since this is sort of a breaking change, from a curl perspective, does this need to wait until a Major release?<br></blockquote><div><br></div><div>Let's have it for master (1.1.x series) only.</div><div>That said, since there may be a few mire 1.0.x releases, which also may have effect to the 1.1.x code base (merges), I'd like to wait a bit with the actual merge of "Safari push" to master.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
plus this might make the current db migration stuff that is in progress more complex too<br>
<br>
I have no problems keeping it separate, and then in a later release merging things together<br></blockquote><div><br></div><div>ah, yeah - that's the best :) no need to "wait" on the work, let's keep branch in sync w/ master, and merge in a few weeks... ok ?</div><div> </div><div>-Matthias</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
wdyt?<br>
<br>
-Luke<br>
<br>
<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>