<div dir="ltr">+1 too<div>also I like the idea of dropping &quot;Java&quot; in JavaSender for a more descriptive PushSender or PushAppSender to get the information this sender is linked to an Push app</div><div><br></div><div>++</div><div>Corinne</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 10 November 2014 08:31, Erik Jan de Wit <span dir="ltr">&lt;<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>+1 I like the static methods for creating the builder</div><div>Also makes perfect sense to make the applicationId and masterSecret part of the sender.<span class=""><br><blockquote type="cite"><div dir="ltr"><div><br></div><div><div>PushSender client = DefaultPushSender.withRootServerURL(&quot;<a href="http://aerogear.example.com/ag-push" target="_blank">http://aerogear.example.com/ag-push</a>&quot;)</div><div>                .proxy(&quot;proxy&quot;, 8080)</div><div>                .proxyType(Proxy.Type.HTTP)</div><div>                .build();</div></div><div>PushSender client = DefaultPushSender.withConfig(&quot;/path/on/classpath/push-config.json&quot;).build();</div><div>PushSender client = DefaultPushSender.withConfig(inputstream).build();<br></div><div><br></div><div><br></div></div></blockquote></span></div><br></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>