<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 10, 2014 at 8:31 AM, Erik Jan de Wit <span dir="ltr">&lt;<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>+1 I like the static methods for creating the builder</div><div>Also makes perfect sense to make the applicationId and masterSecret part of the sender.<span class=""><br><blockquote type="cite"><div dir="ltr"><div><br></div><div><div>PushSender client = DefaultPushSender.withRootServerURL(&quot;<a href="http://aerogear.example.com/ag-push" target="_blank">http://aerogear.example.com/ag-push</a>&quot;)</div><div>                .proxy(&quot;proxy&quot;, 8080)</div><div>                .proxyType(Proxy.Type.HTTP)</div><div>                .build();</div></div><div>PushSender client = DefaultPushSender.withConfig(&quot;/path/on/classpath/push-config.json&quot;).build();</div><div>PushSender client = DefaultPushSender.withConfig(inputstream).build();<br></div></div></blockquote></span></div></div></blockquote><div><br></div><div>+1 and #agreed on doing this on master (not the 1.0.x branch)</div><div><br></div><div>-Matthias</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><span class=""><blockquote type="cite"><div dir="ltr"><div></div><div><br></div><div><br></div></div></blockquote></span></div><br></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div>
</div></div>