<div dir="ltr">Nice work Luke!<div>I noticed a minor typo, "push pacakge", in your blog.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 19 November 2014 15:07, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hey Luke,<div><br></div><div>did a first review and also committed some minor tweaks to polish the comments. First round -> done</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 14, 2014 at 8:42 PM, Lucas Holmquist <span dir="ltr"><<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">yea, no problem, i was just wondering if there were thoughts on having 2 selections or just 1. <div><div><br><div><blockquote type="cite"><div>On Nov 14, 2014, at 2:35 PM, Matthias Wessendorf <<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>> wrote:</div><br><div><div dir="ltr">so far so good :-)<div><br></div><div>It's just been a bit busy the last weeks... I will do a detailed review, and tests next week.</div><div>Sounds good?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 14, 2014 at 6:58 PM, Lucas Holmquist <span dir="ltr"><<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span><blockquote type="cite"><div>On Nov 5, 2014, at 2:03 PM, Lucas Holmquist <<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>> wrote:</div><br><div><div style="word-wrap:break-word">so i wrote a little blog post on this, <a href="http://blog.lholmquist.org/safari-push-notifications/" target="_blank">http://blog.lholmquist.org/safari-push-notifications/</a><div><br></div><div><br></div><div>So i’ve made the iOSVariant an APNsVariant, but now i have a decision.</div><div><br></div><div>currently on the safari-push branch, <a href="https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push</a>, i’ve changed the UI to this: </div><div><br></div><div><a href="http://blog.lholmquist.org/content/images/2014/Nov/Screen_Shot_2014_11_05_at_11_09_49_AM.png" target="_blank">http://blog.lholmquist.org/content/images/2014/Nov/Screen_Shot_2014_11_05_at_11_09_49_AM.png</a></div><div><br></div><div>where there is 1 variant to choose from for iOS and Safari. And not really and way to tell the difference if a variant is for safari or for iOS</div><div><br></div><div>I’m wondering if there should be 2 selections that hit the same(update from ios) “apns" endpoint, and also a field on the APNsVariant to differentiate between iOS and Safari, i can see this as being something for analytics</div><div><br></div></div></div></blockquote></span><div>any thoughts on this?</div><div><div><br><blockquote type="cite"><div><div style="word-wrap:break-word"><div><br></div><div>If we agree to go this route, then we can do the same when we update the GCMVariant</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br><div><blockquote type="cite"><div>On Oct 30, 2014, at 9:13 AM, Lucas Holmquist <<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>> wrote:</div><br><div><div style="word-wrap:break-word">hmm, indeed, let me try that also<br><div><blockquote type="cite"><div>On Oct 30, 2014, at 2:57 AM, Matthias Wessendorf <<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>> wrote:</div><br><div><div dir="ltr">I tried the same, again with -d (rhc -d), that worked fine....<div><br></div><div><br></div><div>hrm...</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 30, 2014 at 7:48 AM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">hahaha, than it disappeared ??? :-) <div><br></div><div>looks like the 'delete' was triggered by the 504 ? </div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 30, 2014 at 7:47 AM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Here is what I did, on command line:<div>rhc app create --no-git safari "<a href="https://cartreflect-claytondev.rhcloud.com/reflect?github=lholmquist/openshift-origin-cartridge-aerogear-push-wildfly&commit=086fe4f75f8991e7780c9df078c7371377c68aa2" target="_blank">https://cartreflect-claytondev.rhcloud.com/reflect?github=lholmquist/openshift-origin-cartridge-aerogear-push-wildfly&commit=086fe4f75f8991e7780c9df078c7371377c68aa2</a>"<br></div><div><br></div><div><br></div><div><br></div><div>One the console, I am getting:</div><div>Creating application 'safari' ... Server returned an unexpected error code: 504<br></div><div><br></div><div><br></div><div><br></div><div><br></div><div>but.... well, here is the server -> <a href="https://safari-pushee.rhcloud.com/ag-push" target="_blank">https://safari-pushee.rhcloud.com/ag-push</a></div><div><br></div><div><br></div><div><br></div><div>What I do not understand it the 504 :) </div><div><br></div><div><br><div><br></div><div><br></div></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 29, 2014 at 10:01 PM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">any log from rhc client?<div><div><span></span><br><br>On Wednesday, October 29, 2014, Lucas Holmquist <<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">i’ve created a safari-push branch on my fork of the open shift cartridge, <div><br></div><div><a href="https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wildfly/tree/safari-push" target="_blank">https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wildfly/tree/safari-push</a></div><div><br></div><div><br></div><div>i’ve been trying to create an app with it but haven’t been successful, perhaps something i’m doing, anyone mind giving it a try<br><div><blockquote type="cite"><div>On Oct 28, 2014, at 3:35 PM, Lucas Holmquist <<a>lholmqui@redhat.com</a>> wrote:</div><br><div><div style="word-wrap:break-word"><div><br></div><div>The branch on the main repo <a href="https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push</a></div><div><br></div><div>subsequent PR’s will target this one</div><br><div><blockquote type="cite"><div>On Oct 28, 2014, at 3:21 PM, Lucas Holmquist <<a>lholmqui@redhat.com</a>> wrote:</div><br><div><div style="word-wrap:break-word">Here is the initial addition in one of my branches: <a href="https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-push" target="_blank">https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-push</a><br><div><blockquote type="cite"><div>On Oct 27, 2014, at 9:42 AM, Matthias Wessendorf <<a>matzew@apache.org</a>> wrote:</div><br><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Oct 27, 2014 at 2:28 PM, Lucas Holmquist<span> </span><span dir="ltr"><<a>lholmqui@redhat.com</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div><div><blockquote type="cite"><div>On Oct 27, 2014, at 9:20 AM, Erik Jan de Wit <<a>edewit@redhat.com</a>> wrote:</div><br><div><div style="word-wrap:break-word">On 27 Oct,2014, at 14:15 , Lucas Holmquist <<a>lholmqui@redhat.com</a>> wrote:<br><div><br><blockquote type="cite"><div style="word-wrap:break-word"><div><br></div><div>So i’ve run into a bit of a problem, I’m trying to send notifications, using <a href="https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/src/main/java/org/jboss/aerogear/unifiedpush/message/sender/APNsPushNotificationSender.java#L52" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/src/main/java/org/jboss/aerogear/unifiedpush/message/sender/APNsPushNotificationSender.java#L52</a></div><div><br></div><div>but i’m not sure how to also tell it to use the new SafarVariant.class that i’ve created. </div></div></blockquote><div><br></div><div>Right now a sender is configured to send notifications for one specific variant type, this mapping is configured on the top of the class:</div><div><a href="https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/src/main/java/org/jboss/aerogear/unifiedpush/message/sender/APNsPushNotificationSender.java#L40" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/src/main/java/org/jboss/aerogear/unifiedpush/message/sender/APNsPushNotificationSender.java#L40</a></div><div><br></div><div>so APNsPushNotificationSender will only be use for <span style="background-color:rgb(248,238,199);color:rgb(51,51,51);font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;line-height:16.7999992370605px;white-space:pre-wrap">iOSVariant</span> variants, so either we change the way this works or you create a new Sender ( that extends this one maybe )</div></div></div></div></blockquote><div><br></div></div></div><div>I think i’ll just create a new sender of now just to get something working since the SafariVariant and iOSVariant will be combined into an APNsVariant in the near future.</div></div></div></blockquote><div><br></div><div>sounds reasonable on getting this started</div><div><br></div><div>-M </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><br></div><div><br></div><br><blockquote type="cite"><div><div style="word-wrap:break-word"><div><div><br></div><div>Cheers,</div><div><span style="white-space:pre-wrap"> </span>Erik Jan</div><br></div><br></div><span>_______________________________________________<br>aerogear-dev mailing list<br><a>aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></span></div></blockquote></div><br></div><br>_______________________________________________<br>aerogear-dev mailing list<br><a>aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>--<span> </span><br>Matthias Wessendorf<span> </span><br><br>blog:<span> </span><a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions:<span> </span><a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter:<span> </span><a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div></div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">_______________________________________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">aerogear-dev mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">aerogear-dev@lists.jboss.org</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div></blockquote></div><br></div>_______________________________________________<br>aerogear-dev mailing list<br><a>aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div></blockquote></div><br></div>_______________________________________________<br>aerogear-dev mailing list<br><a>aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div></blockquote></div><br></div></div></blockquote><br><br></div></div><div><div>-- <br>Sent from Gmail Mobile<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>
_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div></blockquote></div><br></div>_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div></blockquote></div><br></div></div>_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div></blockquote></div></div></div><br></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div>
</div>
_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div></blockquote></div><br></div></div></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div>
</div>
</div></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>