<div dir="ltr">I believe that is a way to go, but also definitely a breaking change, so something to discuss widely.<div><br></div><div>We would need to setup a backward-compatibility layer and thus cluttering code. The benefit is a clean API though.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 8, 2015 at 8:21 AM, Erik Jan de Wit <span dir="ltr"><<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
If we like that settings that are network depended, in a separate
'property', then should we then also move 'content-available' and
'action-category' to a 'apns' property as these are only relevant
for apple?<div><div class="h5"><br>
<br>
<div>On 07/01/2015 18:26, Lukáš Fryč wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi Erik,
<div><br>
</div>
<div>I'd prefer a structured format (under "windows" property)</div>
<div><br>
</div>
<div>it makes more readable code than a flat structure and
avoids collisions.</div>
<div><br>
</div>
<div>Do we have other platform-specific switches we'd need to
align with?</div>
<div><br>
</div>
<div><br>
</div>
<div>Cheers,</div>
<div><br>
</div>
<div>~ Lukas</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Jan 7, 2015 at 5:33 PM, Erik
Jan de Wit <span dir="ltr"><<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hi,<br>
<br>
Right now push is supported for windows, but only so
called `Toast Notifications`. I want to add the other
message types to the as described in this gist [1]. Now in
the new message format this would mean to add a couple of
fields that are windows specific they should be ignored by
the other push services. So I'm wondering if we should do
that, or if we should put these fields into a sub category
called windows for example:<br>
<br>
<pre style="font-family:Consolas,'Liberation Mono',Menlo,Courier,monospace;font-size:12px;margin-top:0px;margin-bottom:0px;width:748px;color:rgb(51,51,51);font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:16.7999992370605px;text-align:start;text-indent:0px;text-transform:none;word-spacing:0px;background-color:rgb(255,255,255)"><div>{
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>message<span style="color:rgb(223,80,0)">"</span></span>:{
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>alert<span style="color:rgb(223,80,0)">"</span></span>:<span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>HELLO!<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>user-data<span style="color:rgb(223,80,0)">"</span></span>:{
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>key<span style="color:rgb(223,80,0)">"</span></span>:<span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>value<span style="color:rgb(223,80,0)">"</span></span>
</div><div> },
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>windows<span style="color:rgb(223,80,0)">"</span></span>: {
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>template<span style="color:rgb(223,80,0)">"</span></span> : <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>cycle<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>title<span style="color:rgb(223,80,0)">"</span></span> : <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>Contoso<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>count<span style="color:rgb(223,80,0)">"</span></span> : <span style="color:rgb(0,134,179)">10</span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>smallBackgroundImage<span style="color:rgb(223,80,0)">"</span></span> : <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>/Assets/Tiles/smallBackgroundImage.jpg<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>cycleImages<span style="color:rgb(223,80,0)">"</span></span> :
</div><div> [
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>/Assets/Tiles/cycleImage1.jpg<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>/Assets/Tiles/cycleImage2.jpg<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>/Assets/Tiles/cycleImage3.jpg<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>/Assets/Tiles/cycleImage4.jpg<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>/Assets/Tiles/cycleImage5.jpg<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>/Assets/Tiles/cycleImage6.jpg<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>/Assets/Tiles/cycleImage7.jpg<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>/Assets/Tiles/cycleImage8.jpg<span style="color:rgb(223,80,0)">"</span></span>,
</div><div> <span style="color:rgb(223,80,0)"><span style="color:rgb(223,80,0)">"</span>/Assets/Tiles/cycleImage9.jpg<span style="color:rgb(223,80,0)">"</span></span>
</div><div> ]
</div><div> }
</div><div> }
</div><div>}</div></pre>
<br>
<br>
What do you think?<br>
<br>
[1] <a href="https://gist.github.com/edewit/305d76c31960aa6254a9" target="_blank">https://gist.github.com/edewit/305d76c31960aa6254a9</a><br>
</div>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
aerogear-dev mailing list
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>