<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Original test on my machine executes in 8.5 seconds the ‘new’ test in 15.115s<div><br><div><div>On 21 Jan,2015, at 16:59 , Erik Jan de Wit <<a href="mailto:edewit@redhat.com">edewit@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">This is using weld container, that is not a application container it doesn’t add a lot of execution time. It only enables CDI in tests.<div><br><div><div>On 21 Jan,2015, at 16:50 , Matthias Wessendorf <<a href="mailto:matzew@apache.org">matzew@apache.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">I think the problem that I have with using Arquillian is the time of execution for these integration tests. It boots up a container and stuff and just makes the test execution take a very long time. We spoke about that in the past, and didn't do Aquillian due to that.<div><br></div><div>Not sure how others feel about it, but I'd prefer we dont boot a container inside our tests</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 21, 2015 at 4:40 PM, Erik Jan de Wit <span dir="ltr"><<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hi,<div><br></div><div>The database unit tests of the UPS contain a lot of setup code as setting up the database is done within the test method. I’m proposing to remove this ‘noise’ from the test and put it in a separate file. Another thing that is setting up the dao's, when we use arquillian weld container we can use injection in our tests to further reduce the boilerplate, have a look at an example:</div><div><br></div><div><a href="https://github.com/edewit/aerogear-unifiedpush-server/blob/4bb63adce319df25e8e77d505f2844cf80ff5644/model/jpa/src/test/java/org/jboss/aerogear/unifiedpush/jpa/PushApplicationDaoTest.java" target="_blank">https://github.com/edewit/aerogear-unifiedpush-server/blob/4bb63adce319df25e8e77d505f2844cf80ff5644/model/jpa/src/test/java/org/jboss/aerogear/unifiedpush/jpa/PushApplicationDaoTest.java</a></div><div><br></div><div>If you like I could do this for all these tests.</div><div><br></div><div>Cheers,</div><div><span style="white-space:pre-wrap"> </span>Erik Jan </div></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div>
</div>
_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></blockquote></div><br></div></div>_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/aerogear-dev</blockquote></div><br></div></body></html>