<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 3, 2015 at 10:57 PM, Sébastien Blanc <span dir="ltr"><<a href="mailto:scm.blanc@gmail.com" target="_blank">scm.blanc@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="auto"><div>Agreed but we should make that clear in the clients (Java and Node) when receiving the response (I'm thinking about the callbacks) , that said, an javadoc/comment should de enough.<br></div></div></blockquote><div><br></div><div>Luckily they say nothing about the actual status code:</div><div>* <a href="https://aerogear.org/docs/specs/aerogear-unifiedpush-java-client/org/jboss/aerogear/unifiedpush/message/MessageResponseCallback.html#onComplete(int)">https://aerogear.org/docs/specs/aerogear-unifiedpush-java-client/org/jboss/aerogear/unifiedpush/message/MessageResponseCallback.html#onComplete(int)</a><br></div><div>* <a href="https://aerogear.org/docs/specs/aerogear-unifiedpush-nodejs-client/">https://aerogear.org/docs/specs/aerogear-unifiedpush-nodejs-client/</a></div><div><br></div><div>On JavaDoc, it just says "statusCode - the status code as returned by the server."</div><div><br></div><div>=> Nothing to change.</div><div><br></div><div>More important is to update this:</div><div><a href="https://aerogear.org/docs/specs/aerogear-unifiedpush-rest/sender/index.html#POST">https://aerogear.org/docs/specs/aerogear-unifiedpush-rest/sender/index.html#POST</a></div><div><br></div><div>But that's covered with the JavaDoc update, required for the change from 200 -> 202</div><div><br></div><div>-Matthias</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="auto"><div><br>Envoyé de mon iPhone</div><div><br>Le 3 févr. 2015 à 22:13, Matthias Wessendorf <<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>> a écrit :<br><br></div><div><div class="h5"><blockquote type="cite"><div><div dir="ltr">Hi,<div><br></div><div>I recently noticed that we are (IMO) incorrectly returning 200 (OK):</div><div><a href="https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/jaxrs/src/main/java/org/jboss/aerogear/unifiedpush/rest/sender/PushNotificationSenderEndpoint.java#L112-L113" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/jaxrs/src/main/java/org/jboss/aerogear/unifiedpush/rest/sender/PushNotificationSenderEndpoint.java#L112-L113</a></div><div><br></div><div>Since we really do submit an async job here, and its processing may not have been started when we do return the 200 (OK), I'd like to propose a slight change here to instead use 202 (Accepted):</div><div><br></div><div><a href="http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.3" target="_blank">http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.3</a></div><div><br></div><div>If the team is OK (ha ha) with this, I will track this in JIRA</div><div><br></div><div>-Matthias<br clear="all"><div><br></div>-- <br><div>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div>
</div></div>
</div></blockquote></div></div><blockquote type="cite"><div><span>_______________________________________________</span><br><span>aerogear-dev mailing list</span><br><span><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a></span><br><span><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></span></div></blockquote></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div>
</div></div>