<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 3, 2015, at 5:27 PM, Matthias Wessendorf <<a href="mailto:matzew@apache.org" class="">matzew@apache.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_extra"><br class="Apple-interchange-newline"><br class=""><div class="gmail_quote">On Tue, Feb 3, 2015 at 10:57 PM, Sébastien Blanc<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:scm.blanc@gmail.com" target="_blank" class="">scm.blanc@gmail.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div dir="auto" class=""><div class="">Agreed but we should make that clear in the clients (Java and Node) when receiving the response (I'm thinking about the callbacks) , that said, an javadoc/comment should de enough.<br class=""></div></div></blockquote><div class=""><br class=""></div><div class="">Luckily they say nothing about the actual status code:</div><div class="">*<span class="Apple-converted-space"> </span><a href="https://aerogear.org/docs/specs/aerogear-unifiedpush-java-client/org/jboss/aerogear/unifiedpush/message/MessageResponseCallback.html#onComplete(int)" class="">https://aerogear.org/docs/specs/aerogear-unifiedpush-java-client/org/jboss/aerogear/unifiedpush/message/MessageResponseCallback.html#onComplete(int)</a><br class=""></div><div class="">* <a href="https://aerogear.org/docs/specs/aerogear-unifiedpush-nodejs-client/" class="">https://aerogear.org/docs/specs/aerogear-unifiedpush-nodejs-client/</a></div></div></div></div></div></blockquote><div><br class=""></div>yea, i always thought this was a fire and forget thing anyway<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><div class="">On JavaDoc, it just says "statusCode - the status code as returned by the server."</div><div class=""><br class=""></div><div class="">=> Nothing to change.</div><div class=""><br class=""></div><div class="">More important is to update this:</div><div class=""><a href="https://aerogear.org/docs/specs/aerogear-unifiedpush-rest/sender/index.html#POST" class="">https://aerogear.org/docs/specs/aerogear-unifiedpush-rest/sender/index.html#POST</a></div><div class=""><br class=""></div><div class="">But that's covered with the JavaDoc update, required for the change from 200 -> 202</div><div class=""><br class=""></div><div class="">-Matthias</div><div class=""><br class=""></div><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div dir="auto" class=""><div class=""><br class="">Envoyé de mon iPhone</div><div class=""><br class="">Le 3 févr. 2015 à 22:13, Matthias Wessendorf <<a href="mailto:matzew@apache.org" target="_blank" class="">matzew@apache.org</a>> a écrit :<br class=""><br class=""></div><div class=""><div class="h5"><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">Hi,<div class=""><br class=""></div><div class="">I recently noticed that we are (IMO) incorrectly returning 200 (OK):</div><div class=""><a href="https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/jaxrs/src/main/java/org/jboss/aerogear/unifiedpush/rest/sender/PushNotificationSenderEndpoint.java#L112-L113" target="_blank" class="">https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/jaxrs/src/main/java/org/jboss/aerogear/unifiedpush/rest/sender/PushNotificationSenderEndpoint.java#L112-L113</a></div><div class=""><br class=""></div><div class="">Since we really do submit an async job here, and its processing may not have been started when we do return the 200 (OK), I'd like to propose a slight change here to instead use 202 (Accepted):</div><div class=""><br class=""></div><div class=""><a href="http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.3" target="_blank" class="">http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.3</a></div><div class=""><br class=""></div><div class="">If the team is OK (ha ha) with this, I will track this in JIRA</div><div class=""><br class=""></div><div class="">-Matthias<br clear="all" class=""><div class=""><br class=""></div>--<span class="Apple-converted-space"> </span><br class=""><div class="">Matthias Wessendorf<span class="Apple-converted-space"> </span><br class=""><br class="">blog:<span class="Apple-converted-space"> </span><a href="http://matthiaswessendorf.wordpress.com/" target="_blank" class="">http://matthiaswessendorf.wordpress.com/</a><br class="">sessions:<span class="Apple-converted-space"> </span><a href="http://www.slideshare.net/mwessendorf" target="_blank" class="">http://www.slideshare.net/mwessendorf</a><br class="">twitter:<span class="Apple-converted-space"> </span><a href="http://twitter.com/mwessendorf" target="_blank" class="">http://twitter.com/mwessendorf</a></div></div></div></div></blockquote></div></div><blockquote type="cite" class=""><div class=""><span class="">_______________________________________________</span><br class=""><span class="">aerogear-dev mailing list</span><br class=""><span class=""><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank" class="">aerogear-dev@lists.jboss.org</a></span><br class=""><span class=""><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank" class="">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></span></div></blockquote></div><br class="">_______________________________________________<br class="">aerogear-dev mailing list<br class=""><a href="mailto:aerogear-dev@lists.jboss.org" class="">aerogear-dev@lists.jboss.org</a><br class=""><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank" class="">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br class=""></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>--<span class="Apple-converted-space"> </span><br class=""><div class="gmail_signature">Matthias Wessendorf<span class="Apple-converted-space"> </span><br class=""><br class="">blog:<span class="Apple-converted-space"> </span><a href="http://matthiaswessendorf.wordpress.com/" target="_blank" class="">http://matthiaswessendorf.wordpress.com/</a><br class="">sessions:<span class="Apple-converted-space"> </span><a href="http://www.slideshare.net/mwessendorf" target="_blank" class="">http://www.slideshare.net/mwessendorf</a><br class="">twitter:<span class="Apple-converted-space"> </span><a href="http://twitter.com/mwessendorf" target="_blank" class="">http://twitter.com/mwessendorf</a></div></div></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">aerogear-dev mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="mailto:aerogear-dev@lists.jboss.org" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">aerogear-dev@lists.jboss.org</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div></blockquote></div><br class=""></body></html>