<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">+1 that would make it more in sync with iOS and Windows, where we created profiled config:</div><div class=""><br class=""></div><div class=""><a href="https://github.com/aerogear/aerogear-windows-oauth2/blob/master/aerogear-windows-oauth2/AccountManager.cs#L86" class="">https://github.com/aerogear/aerogear-windows-oauth2/blob/master/aerogear-windows-oauth2/AccountManager.cs#L86</a></div><div class=""><a href="https://github.com/aerogear/aerogear-ios-oauth2/blob/master/AeroGearOAuth2/AccountManager.swift#L23" class="">https://github.com/aerogear/aerogear-ios-oauth2/blob/master/AeroGearOAuth2/AccountManager.swift#L23</a></div><div class=""><br class=""></div><div class=""><br class=""></div><br class=""><div><blockquote type="cite" class=""><div class="">On 9 Mar,2015, at 14:42 , Bruno Oliveira <<a href="mailto:bruno@abstractj.org" class="">bruno@abstractj.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Good morning, while writing our quickstarts, I found something that I<br class="">would like to change.<br class=""><br class="">Currently to setup our OAuth2 providers we have to do something like<br class="">this:<br class=""><br class="">AuthorizationManager.config(MODULE_NAME, OAuth2AuthorizationConfiguration.class)<br class=""> .setBaseURL(new URL("https://"))<br class=""> .setAuthzEndpoint(AUTHZ_ENDPOINT)<br class=""> .setAccessTokenEndpoint(AUTHZ_TOKEN_ENDPOINT)<br class=""> .setAccountId(AUTHZ_ACCOOUNT_ID)<br class=""> .setClientId(AUTHZ_CLIENT_ID)<br class=""> .setClientSecret(AUTHZ_CLIENT_SECRET)<br class=""> .setRedirectURL(AUTHZ_REDIRECT_URL)<br class=""> .setRefreshEndpoint(AUTHZ_TOKEN_ENDPOINT)<br class=""> .addAdditionalAccessParam(Pair.create("response_type", "code"))<br class=""> .setScopes(Arrays.asList("photo_upload, publish_actions"))<br class=""> .asModule();<br class=""><br class="">Although, things like the url endpoint, access token endpoint, or the<br class="">module will most of time remain unchanged. Unless you switch from Facebook to<br class="">Keycloak for example. People don't care that much about these<br class="">urls, but which provider they want to connect.<br class=""><br class="">So I would like to refactor the authz module from AGDroid, define the default values<br class="">for ommitted params and make the methods like setBaseURL for example,<br class="">alternative. Something like this:<br class=""><br class="">AuthorizationManager.config(MODULE_NAME, OAuth2AuthorizationConfiguration.class)<br class=""> .setClientId(AUTHZ_CLIENT_ID)<br class=""> .setClientSecret(AUTHZ_CLIENT_SECRET)<br class=""> .asModule();<br class=""><br class="">Based on the module name, we instantiate the respective module with the<br class="">default values already in.<br class=""><br class="">Thoughts? Let me know if the idea is useless.<br class=""><br class=""><br class="">--<br class=""><br class="">abstractj<br class="">PGP: 0x84DC9914<br class="">_______________________________________________<br class="">aerogear-dev mailing list<br class=""><a href="mailto:aerogear-dev@lists.jboss.org" class="">aerogear-dev@lists.jboss.org</a><br class="">https://lists.jboss.org/mailman/listinfo/aerogear-dev<br class=""></div></blockquote></div><br class=""></body></html>