<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 5, 2015 at 10:39 AM, Erik Jan de Wit <span dir="ltr"><<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I agree with this and maybe we want even more functionality moved,<br>
because also updating the categories is strange in a 'register'<br>
method. Say for instance you want to change the categories your<br>
interested in a developer has to call register again?</blockquote><div><br></div><div>Right, there could be an update function on the client sdk.</div><div><br></div><div>For update we than could do PUT - instead of always do POST (since taht is done now on the register)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> And if I<br>
understand Corinnes mail that will currently not even work on iOS.<br>
<br>
For cordova I store the device info, because the lifecycle is<br>
different, but that is okay it's an integration problem.<br>
<br>
So updating the installation details should be a separate method that<br>
also contains updating the categories. That way we have a better split<br>
between a device that registers itself with UPS and updating the<br>
subscription data.<br></blockquote><div><br></div><div>sounds good to me! </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
On Tue, May 5, 2015 at 9:26 AM, Corinne Krych <<a href="mailto:corinnekrych@gmail.com">corinnekrych@gmail.com</a>> wrote:<br>
> Hello Sebi,<br>
><br>
><br>
> I've done an initial work on aerogear-ios-push [swift branch], adding a new<br>
> parameter when doing the registration to pass the ag-push-id. See:<br>
><br>
> <a href="https://github.com/aerogear/aerogear-ios-push/compare/aerogear:master...corinnekrych:AGPUSH-1232.analytics.push.notification?expand=1" target="_blank">https://github.com/aerogear/aerogear-ios-push/compare/aerogear:master...corinnekrych:AGPUSH-1232.analytics.push.notification?expand=1</a><br>
><br>
> This client could be tested with HelloWorld. See:<br>
><br>
> <a href="https://github.com/jboss-mobile/unified-push-helloworld/compare/jboss-mobile:swift...corinnekrych:AGPUSH-1232.analytics.push.notification?expand=1" target="_blank">https://github.com/jboss-mobile/unified-push-helloworld/compare/jboss-mobile:swift...corinnekrych:AGPUSH-1232.analytics.push.notification?expand=1</a><br>
><br>
> What is not covered is the background app coming to foreground through a<br>
> push notification. If you look at HelloWorld:<br>
><br>
> <a href="https://github.com/jboss-mobile/unified-push-helloworld/blob/f7d0a7e093327f9a84041910c4c2892280c88ffb/ios-swift/HelloWorldSwift/AppDelegate.swift#L152" target="_blank">https://github.com/jboss-mobile/unified-push-helloworld/blob/f7d0a7e093327f9a84041910c4c2892280c88ffb/ios-swift/HelloWorldSwift/AppDelegate.swift#L152</a><br>
><br>
> In iOS, when we go from background to foreground we don't go through<br>
> registration API. The iOS push lib doesn't store locally (as opposed to<br>
> windows sdk for ex) the device information. So i can't really make another<br>
> call to registration API. What i'd suggest is to have a separate endpoint<br>
> for metrics instead of having it coupled with registration endpoint. wdyt?<br>
><br>
> ++<br>
><br>
> Corinne<br>
><br>
> On 4 May 2015 at 19:07, Sébastien Blanc <<a href="mailto:scm.blanc@gmail.com">scm.blanc@gmail.com</a>> wrote:<br>
>><br>
>> Hi Corinne !<br>
>> We want to collect for both situations you described :)<br>
>><br>
>> Envoyé de mon iPhone<br>
>><br>
>> Le 4 mai 2015 à 17:53, Corinne Krych <<a href="mailto:corinnekrych@gmail.com">corinnekrych@gmail.com</a>> a écrit :<br>
>><br>
>> Hello Sebi,<br>
>><br>
>> After giving it a closer look, I've got a question for you: do we want to<br>
>> collect metrics only when an app is opened via push notification or do we<br>
>> also want to collect metrics when an app is brought to foreground by a push<br>
>> notification?<br>
>><br>
>> ++<br>
>> Corinne<br>
>><br>
>><br>
>> On 4 May 2015 at 10:21, Corinne Krych <<a href="mailto:corinnekrych@gmail.com">corinnekrych@gmail.com</a>> wrote:<br>
>>><br>
>>> Yeap<br>
>>> on it.<br>
>>><br>
>>> On 30 April 2015 at 15:43, Sebastien Blanc <<a href="mailto:scm.blanc@gmail.com">scm.blanc@gmail.com</a>> wrote:<br>
>>>><br>
>>>> Hi,<br>
>>>><br>
>>>> The Advanced Analytics task[1] has a new PR[2] that has been rebased on<br>
>>>> the latest master and got a lot of polishing.<br>
>>>><br>
>>>> Could the Client Tech Leads take a look at it [3] and review ? The only<br>
>>>> "breaking" change is the rename of the header's name that identifies a Push<br>
>>>> Notification, it's called now "aerogear-push-id"<br>
>>>><br>
>>>> Seb<br>
>>>><br>
>>>><br>
>>>><br>
>>>> [1] <a href="https://issues.jboss.org/browse/AGPUSH-971" target="_blank">https://issues.jboss.org/browse/AGPUSH-971</a><br>
>>>> [2] <a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/540" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/pull/540</a><br>
>>>> [3] Subtasks of <a href="https://issues.jboss.org/browse/AGPUSH-971" target="_blank">https://issues.jboss.org/browse/AGPUSH-971</a><br>
>>>><br>
>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> aerogear-dev mailing list<br>
>>>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
>>>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
>>><br>
>>><br>
>><br>
>> _______________________________________________<br>
>> aerogear-dev mailing list<br>
>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
>><br>
>><br>
>> _______________________________________________<br>
>> aerogear-dev mailing list<br>
>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Cheers,<br>
Erik Jan<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div>
</div></div>