<div dir="ltr">Something i was just thinking about though, is i would like to change the API to be promised based instead of using callbacks. This would be a major API change, thus a Major version bump. <div><br></div><div>So maybe making these things the same version might not be the best idea? Or perhaps getting the API change done before the sync up in versions could also work?</div><div><br></div><div><br></div><div>i hate when i talk myself out of things :)</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 29, 2016 at 10:38 AM, Luke Holmquist <span dir="ltr"><<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Currently the node sender for the UPS, is at 0.10.1,<div><a href="https://github.com/aerogear/aerogear-unifiedpush-nodejs-client/releases/tag/0.10.1" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-nodejs-client/releases/tag/0.10.1</a><br></div><div><br></div><div>which works with the UPS version 1.1.x series.</div><div><br></div><div>Ive been thinking that perhaps we should update the node sender version to be in lock-step with the version of the UPS it works with. </div><div><br></div><div>The only real problem with this is that the UPS 1.0.x uses the 0.7.x node sender. but if we want to stay semver compliant, we can't really make a 1.0.x node sender series since it would "reverting" things in the 0.8+ versions.</div><div><br></div><div><br></div><div>I'm thinking that perhaps we just bump the node sender to 1.1.1? or whatever the current release is of the UPS. </div><div><br></div><div>hopefully if we keep things like this, then it becomes less confusing for users to know what version of the sender to use with which version of the UPS</div><div><br></div><div>There is one issue i would like to get in though, before bumping the version. <a href="https://issues.jboss.org/browse/AGJS-302" target="_blank">https://issues.jboss.org/browse/AGJS-302</a> - this adds in using the request library.</div><div><br></div><div><br></div><div>thoughts?</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-Luke</div></font></span></div>
</blockquote></div><br></div>