<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 23 June 2016 at 18:37, Michael Doo <span dir="ltr"><<a href="mailto:michael@410labs.com" target="_blank">michael@410labs.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><div><div><div><div><div><div><div>Hello,<br><br></div>There are three pending pull requests on the iOS OAuth2 project. They are as follows:<br><br></div>#45 - Update to CocoaPods 1.0.1<br></div>This makes the update from CP 0.39.0 to CP 1.0.1. The main changes are in the project file as well as the Podfile. <br><br></div>#46 - Make the OAuth2Module webview public<br></div>In
the project I'm working on, we're using different logic to detect a
redirect to the OAuth2 callback URL. To integrate this into the Aerogear
library, we override the OAuth2Module's webview. This PR simply makes
that part of the code public.<br><br></div></div></div></div></div></div></div></div></div></blockquote><div><br></div><div>Both merged!</div><div>Thanks for your contribution.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><div><div></div>#49 - Update Travis CI to use latest CocoaPods<br></div>The
Travis build is still breaking (an error regarding the Aerogear Http
library). Nonetheless, if the project is going to use CP 1.0.1, Travis
CI needs to switch over as well. Not sure what to do about the
consistent CI failures though...<br></div></div></div></div></div></div></div></blockquote><div><br></div><div>I'm looking into this one... Travis can be quite a mystery from time to time ;)</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><br></div><div>Please let me know if there are any questions/concerns regarding these PRs. <br></div><div><br></div>Some things on my to-do list that probably won't get done very soon, but likely in the next couple of months:<br><br></div>*
Beginning the conversion to Swift 2.3. This release of Swift is a sort
of bridge between 2.2 and 3.0. However, the challenge here is that if
the OAuth2 library is built with 2.3, all it's dependencies must also be
in 2.3. I will probably do this work on a branch until such time that
the dependencies catch up.<br></div></div></div></div></div></blockquote><div><br></div><div>+1 for a swift2.3 branch</div><div>For the dependencies, we have AeroGearHttp (I can help on that one) and OHHTTPStubs (for test pod only, this one already have a PR for swift2.3: <a href="https://github.com/AliSoftware/OHHTTPStubs/pull/184">https://github.com/AliSoftware/OHHTTPStubs/pull/184</a>). I like the idea of having it compatible for both Swift 2.2/Xcode 7.3 and Swift 2.3/Xcode 8. </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div><div></div>* Making the library iOS 10.0 /
Xcode 8 ready. iOS 10 will most likely be released this fall and the
OAuth2 library should support it. As part of this, the library will also
need some changes to support Xcode 8 (Xcode 7.x won't build for an iOS
10 target). Again, this will probably be done on a separate branch until
the library's dependencies also support iOS 10.</div></div></div></div></blockquote><div><br></div><div>+1 for a separate branch</div><div><br></div><div>Thanks for your contributions, I'm looking forward seeing the next ones ;) </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div><br><br></div>Best,<br></div>Michael Doo<br></div>410 Labs</div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div></div>