<div><br><div class="gmail_quote"><div>On Wed, 28 Jun 2017 at 12:08, Jose Miguel Gallas Olmedo <<a href="mailto:jgallaso@redhat.com">jgallaso@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Matthias is already unreachable but I think he agreed on this idea so I will proceed to send a PR with this changes. </div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"></div></div></blockquote><div><br></div><div>+1 </div><div><br></div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Maybe @Leigh or @Summers want to add some comments on this?</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">I've created <a href="https://issues.jboss.org/browse/AGPUSH-2127" target="_blank">this ticket</a> so far and will work on the PR now.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 26 June 2017 at 11:02, Jose Miguel Gallas Olmedo <span><<a href="mailto:jgallaso@redhat.com" target="_blank">jgallaso@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><span><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><div class="gmail_default"><span style="font-family:arial,sans-serif">On 26 June 2017 at 10:19, Matthias Wessendorf </span><span style="font-family:arial,sans-serif"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span><span style="font-family:arial,sans-serif"> wrote:</span></div><div class="gmail_quote" style="font-family:arial,sans-serif"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="m_-1217987612512064763m_2562841712352540988gmail-">On Mon, Jun 26, 2017 at 9:19 AM, Jose Miguel Gallas Olmedo <span><<a href="mailto:jgallaso@redhat.com" target="_blank">jgallaso@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div style="font-family:arial,helvetica,sans-serif"><br class="m_-1217987612512064763m_2562841712352540988gmail-m_4090263789431902110m_1209567383203091541gmail-Apple-interchange-newline"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="font-family:arial,sans-serif;font-size:12.8px">not sure if we should delete it yet - I think it was written by QE to test GCMv2 - but push server is now GCMv3/FCM compliant. I think there is some features missing there. Perhaps it's still good - not really sure.</span></blockquote><div><br></div><div>Actually, we could keep the old gcm-proxy as well. The repo is "push-network-proxies" which means many proxies. We could store the new one under "fcm-wiremock" and the old one under "gcm-java"</div></div></div></blockquote><div><br></div></span><div>+1</div><span class="m_-1217987612512064763m_2562841712352540988gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div style="font-family:arial,helvetica,sans-serif">but for this, I think, we ought to extract GCM logic from the current project, leaving only APNS stuff.</div></div></blockquote><div><br></div></span><div>no, not just APNs, IMO </div></div></div></div></blockquote></div></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div></span><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">I think I didn't explain it clear enough, let me start again: The current repository is a java project that implements both GCM and APNS proxies. What I mean with "extract GCM logic from the project" is exactly what you see in the structure: "apns-java" would have the original "push-network-proxies" java project but only with the APNS implementation and "gcm-java" would have the original "push-network-proxies" java project but only with GCM implementation. Maybe "decouple" would be a better term.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Does it make more sense now or didn't I understand you point maybe?</div><span><div class="gmail_extra"><div><br></div>-- <br><div class="m_-1217987612512064763m_2562841712352540988gmail_signature"><div><div><div><div><div><div><div><div><div><div><div><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>JOSE MIGUEL</span> <span>GALLAS OLMEDO</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>ASSOCIATE QE, mobile</span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat <span><br><br></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span href="tel:+34618488633">M: <a href="http://redhatemailsignature-marketing.itos.redhat.com/" style="color:rgb(0,136,206);font-size:11px;margin:0px" target="_blank">+34618488633</a> </span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div></div></div></div>
</div></span></div><div class="m_-1217987612512064763HOEnZb"><div class="m_-1217987612512064763h5"><div class="gmail_extra"><br><div class="gmail_quote">On 26 June 2017 at 10:19, Matthias Wessendorf <span><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Mon, Jun 26, 2017 at 9:19 AM, Jose Miguel Gallas Olmedo <span><<a href="mailto:jgallaso@redhat.com" target="_blank">jgallaso@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:arial,helvetica,sans-serif;font-size:small"><span><br class="m_-1217987612512064763m_2562841712352540988m_4090263789431902110m_1209567383203091541gmail-Apple-interchange-newline"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="font-family:arial,sans-serif;font-size:12.8px">not sure if we should delete it yet - I think it was written by QE to test GCMv2 - but push server is now GCMv3/FCM compliant. I think there is some features missing there. Perhaps it's still good - not really sure.</span></blockquote><div><br></div></span><div>Actually, we could keep the old gcm-proxy as well. The repo is "push-network-proxies" which means many proxies. We could store the new one under "fcm-wiremock" and the old one under "gcm-java" </div></div></div></blockquote><div><br></div></span><div>+1</div><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:arial,helvetica,sans-serif;font-size:small"><div>but for this, I think, we ought to extract GCM logic from the current project, leaving only APNS stuff.</div></div></div></blockquote><div><br></div></span><div>no, not just APNs, IMO </div><span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:arial,helvetica,sans-serif;font-size:small"><div><div style="font-family:arial,sans-serif"><font face="monospace, monospace"><br></font></div><div style="font-family:arial,sans-serif"><font face="monospace, monospace">push-network-proxies/</font></div><div style="font-family:arial,sans-serif"><font face="monospace, monospace"> fcm-wiremock/</font></div><div style="font-family:arial,sans-serif"><font face="monospace, monospace"> ...</font></div><div style="font-family:arial,sans-serif"><font face="monospace, monospace"> apns-java/</font></div><div style="font-family:arial,sans-serif"><font face="monospace, monospace"> ...</font></div><div style="font-family:arial,sans-serif"><font face="monospace, monospace"> gcm-java/</font></div><div style="font-family:arial,sans-serif"><font face="monospace, monospace"> ...</font></div><div style="font-family:arial,sans-serif"><font face="monospace, monospace"> push-network-proxies-template.yml</font></div></div></div></div></blockquote><div><br></div></span><div>I think this is a good structure</div><div><div class="m_-1217987612512064763m_2562841712352540988h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:arial,helvetica,sans-serif;font-size:small"><div><br></div><div>In the future we might want to add new different implementations (or new proxies) so it makes sense to me to have push-network-proxies as an extensible repository, not as a only-2-proxies one.<br></div></div></div><div class="m_-1217987612512064763m_2562841712352540988m_4090263789431902110HOEnZb"><div class="m_-1217987612512064763m_2562841712352540988m_4090263789431902110h5"><div class="gmail_extra"><br><div class="gmail_quote">On 24 June 2017 at 15:33, Matthias Wessendorf <span><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Jun 23, 2017 at 4:08 PM, Jose Miguel Gallas Olmedo <span><<a href="mailto:jgallaso@redhat.com" target="_blank">jgallaso@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:arial,helvetica,sans-serif;font-size:small">Hi all,</div><div style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div style="font-family:arial,helvetica,sans-serif;font-size:small">I recently create a Docker image of our push FCM proxy, made with Wiremock. Since we are no longer using the FCM proxy in <a href="https://github.com/aerogear/push-network-proxies" target="_blank">https://github.com/aerogear/push-network-proxies</a> (even the Dockerfile there only consider APNs) I think we could remove it from there and refactor the repository like this:</div></div></blockquote><div><br></div></span><div>not sure if we should delete it yet - I think it was written by QE to test GCMv2 - but push server is now GCMv3/FCM compliant. I think there is some features missing there. Perhaps it's still good - not really sure.</div><div><br></div><div>But if Wiremock offers what we need -> fine, better to use things that are supported through a larger community ;-)</div><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-size:small"><font face="monospace, monospace"><br></font></div><div style="font-size:small"><font face="monospace, monospace">push-network-proxies/</font></div><div style="font-size:small"><font face="monospace, monospace"> fcm/</font></div><div style="font-size:small"><font face="monospace, monospace"> Dockerfile</font></div><div style="font-size:small"><font face="monospace, monospace"> ...</font></div><div style="font-size:small"><font face="monospace, monospace"> apns/</font></div><div style="font-size:small"><font face="monospace, monospace"> Dockerfile</font></div><div style="font-size:small"><font face="monospace, monospace"> ...</font></div><div style="font-size:small"><font face="monospace, monospace"> push-network-proxies-template.yml</font></div><div style="font-size:small"><font face="monospace, monospace"><br></font></div><div><font face="arial, helvetica, sans-serif">So that we have everything in the same place. I also made a template for Openshift so that we can setup a testing environment for UPS quickly. I think that's the ultimate point of having the mocks together.</font></div></div></blockquote><div><br></div></span><div>I like that, having this structure, where FCM is based on Wiremock, right? </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span><div><div><font face="arial, helvetica, sans-serif"><br></font></div><div><font face="arial, helvetica, sans-serif">WDYT?</font></div><span class="m_-1217987612512064763m_2562841712352540988m_4090263789431902110m_1209567383203091541m_6645334282631665650HOEnZb"><font color="#888888"><div><br></div>-- <br><div class="m_-1217987612512064763m_2562841712352540988m_4090263789431902110m_1209567383203091541m_6645334282631665650m_7920304583616866219gmail_signature"><div><div><div><div><div><div><div><div><div><div><div><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>JOSE MIGUEL</span> <span>GALLAS OLMEDO</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>ASSOCIATE QE, mobile</span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat <span><br><br></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span href="tel:+34618488633">M: <a href="http://redhatemailsignature-marketing.itos.redhat.com/" style="color:rgb(0,136,206);font-size:11px;margin:0px" target="_blank">+34618488633</a> </span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div></div></div></div>
</font></span></div>
<br></span>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><span class="m_-1217987612512064763m_2562841712352540988m_4090263789431902110m_1209567383203091541HOEnZb"><font color="#888888"><br></font></span></blockquote></div><span class="m_-1217987612512064763m_2562841712352540988m_4090263789431902110m_1209567383203091541HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="m_-1217987612512064763m_2562841712352540988m_4090263789431902110m_1209567383203091541m_6645334282631665650gmail_signature" data-smartmail="gmail_signature"><div><div>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div></div></div>
</font></span></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_-1217987612512064763m_2562841712352540988m_4090263789431902110m_1209567383203091541gmail_signature" data-smartmail="gmail_signature"><div><div><div><div><div><div><div><div><div><div><div><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>JOSE MIGUEL</span> <span>GALLAS OLMEDO</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>ASSOCIATE QE, mobile</span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat <span><br><br></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span href="tel:+34618488633">M: <a href="http://redhatemailsignature-marketing.itos.redhat.com/" style="color:rgb(0,136,206);font-size:11px;margin:0px" target="_blank">+34618488633</a> </span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div></div></div></div>
</div>
</div></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div></div></div><div><div class="m_-1217987612512064763m_2562841712352540988h5"><br><br clear="all"><div><br></div>-- <br><div class="m_-1217987612512064763m_2562841712352540988m_4090263789431902110gmail_signature" data-smartmail="gmail_signature"><div><div>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div></div></div>
</div></div></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_-1217987612512064763m_2562841712352540988gmail_signature" data-smartmail="gmail_signature"><div><div><div><div><div><div><div><div><div><div><div><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>JOSE MIGUEL</span> <span>GALLAS OLMEDO</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>ASSOCIATE QE, mobile</span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat <span><br><br></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span href="tel:+34618488633">M: <a href="http://redhatemailsignature-marketing.itos.redhat.com/" style="color:rgb(0,136,206);font-size:11px;margin:0px" target="_blank">+34618488633</a> </span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div></div></div></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_-1217987612512064763gmail_signature" data-smartmail="gmail_signature"><div><div><div><div><div><div><div><div><div><div><div><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>JOSE MIGUEL</span> <span>GALLAS OLMEDO</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>ASSOCIATE QE, mobile</span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat <span><br><br></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span href="tel:+34618488633">M: <a href="http://redhatemailsignature-marketing.itos.redhat.com/" style="color:rgb(0,136,206);font-size:11px;margin:0px" target="_blank">+34618488633</a> </span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div></div></div></div>
</div>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></blockquote></div></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature">Sent from Gmail Mobile</div>