<div dir="ltr">Thanks Matthias! :) <div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 9, 2017 at 9:46 AM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Wed, Aug 9, 2017 at 10:35 AM, Dimitra Zuccarelli <span dir="ltr"><<a href="mailto:dimitrazuccarelli@gmail.com" target="_blank">dimitrazuccarelli@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-size:12.800000190734863px">Hi guys, here's the PR for the generic ser/des:<a href="https://github.com/matzew/kafka-cdi/pull/17" target="_blank"> https://github.com/ma<wbr>tzew/kafka-cdi/pull/17</a><br></div><div><div style="font-size:12.800000190734863px"><br></div><div style="font-size:12.800000190734863px">As far as testing goes, there are a few issues with abstract classes obviously, and since most of the objects we'll be producing contain 'Variant' (which is an abstract class) we'll have to come up with a nice solution for that - we're open to ideas! <br></div></div></div></blockquote><div><br></div></span><div>not sure I follow :-) but why not using one of the concrete impls of it ? </div></div></div></div></blockquote><div><br></div><div>Because then we'd have to define a producer/consumer for every concrete implementation, like SimpleKafkaProducer<String, AndroidVariant>, SimpleKafkaProducer<String, AdmVariant> etc.. I think that would be extremely inefficient </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div style="font-size:12.800000190734863px"></div><div style="font-size:12.800000190734863px"><br></div><div style="font-size:12.800000190734863px">Right now it won't work "out of the box" with Polina's PR due to the List<Variant> in the PushApplication class: </div><div style="font-size:12.800000190734863px"><br></div><div style="font-size:12.800000190734863px"><p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(175,173,36)"><span style="font-variant-ligatures:no-common-ligatures">Caused by: com.fasterxml.jackson.databind<wbr>.JsonMappingException: Can not construct instance of org.jboss.aerogear.unifiedpush<wbr>.api.Variant, problem: abstract types either need to be mapped to concrete types, have custom deserializer, or be instantiated with additional type information</span></p><p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo"><span style="font-variant-ligatures:no-common-ligatures"><font color="#afad24"> at [Source: [B@d4163ef; line: 1, column: 229] </font><font color="#9900ff">(through reference chain: org.jboss.aerogear.unifiedpush<wbr>.api.PushApplication["variants<wbr>"])</font></span></p><p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(175,173,36)"><span style="font-variant-ligatures:no-common-ligatures"><br></span></p><p style="margin:0px;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(175,173,36)"><br></p><p style="margin:0px;line-height:normal"><span style="font-variant-ligatures:no-common-ligatures"></span></p></div></div></div></blockquote><div><br></div></span><div>do we need to define some mapping in UPS?</div></div></div></div></blockquote><div><br></div><div>What do you mean? </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div style="font-size:12.800000190734863px"><p style="margin:0px;line-height:normal"><span style="font-variant-ligatures:no-common-ligatures">Two other things: </span></p><p style="margin:0px;line-height:normal"><span style="font-variant-ligatures:no-common-ligatures"><br></span></p><p style="margin:0px;line-height:normal"><span style="font-variant-ligatures:no-common-ligatures">* Bad things will happen if objects of incorrect type are pushed to the same topic.</span></p></div></div></div></blockquote><div><br></div></span><div>when or how ? any code/pointers?</div><span class="gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div style="font-size:12.800000190734863px"><p style="margin:0px;line-height:normal"><span style="font-variant-ligatures:no-common-ligatures"> This will definitely have to be addressed by enforcing some basic security (<a href="https://issues.jboss.org/browse/AGPUSH-2109" target="_blank">AGPUSH-2109</a>)</span></p></div></div></div></blockquote><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div style="font-size:12.800000190734863px"><p style="margin:0px;line-height:normal"><span style="font-variant-ligatures:no-common-ligatures"><br></span></p><p style="margin:0px;line-height:normal"><span style="font-variant-ligatures:no-common-ligatures">* We'll have to make sure our logs are a little more "informative" as we can't log whole objects obviously for readability. </span></p></div></div></div></blockquote></span><div>+1</div><span class="gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div style="font-size:12.800000190734863px"><p style="margin:0px;line-height:normal"><span style="font-variant-ligatures:no-common-ligatures">Right now, even with just two consumers, the log is quite overwhelming (i.e. consumer configs etc) </span></p></div></div></div></blockquote><div><br></div></span><div>we could make the kafka own logging quiet ;-) That's IMO the verbose one, which is sometimes handy.</div><div><br></div><div>But in WildFly we could limit those to WARN/ERROR</div></div></div></div></blockquote><div><br></div><div>+1 </div><div>It's handy for development but otherwise we should limit it I think</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span class="gmail-"><div class="gmail-m_2512592196931071255HOEnZb"><div class="gmail-m_2512592196931071255h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 8, 2017 at 9:42 PM, Dimitra Zuccarelli <span dir="ltr"><<a href="mailto:dimitrazuccarelli@gmail.com" target="_blank">dimitrazuccarelli@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi guys,<div><br></div><div>It's week 11 of GSoC, which means we only have about 3 weeks left until the end! Here's a quick summary of what we've been doing: <div><br></div><div>* Right now I'm currently working on implementing custom object serialisers and deserialisers to give us the ability to produce whatever we want to our topics. </div><div>It's been a bit of a bumpy ride so far but Matthias just did a <a href="https://github.com/matzew/kafka-cdi/pull/16" target="_blank">PR</a> which resolves some of the issues we were having with generics. We'll hopefully have this sorted by the end of the week, so we can start using it for the producers/consumers/streams that we implement.</div><div><br></div><div>* Polina has already done <a href="https://issues.jboss.org/browse/AGPUSH-2159" target="_blank">AGPUSH-2159</a> related to our first "custom" producer but hasn't sent a PR off yet, given the aforementioned issues. She's also currently working on getting a fancier test environment up for all of our future consumers and producers :) </div><div><br></div><div>* Since we have a very short amount of time left after that, we'll jump right into some more implementation with <a href="https://issues.jboss.org/browse/AGPUSH-2165" target="_blank">AGPUSH-2165</a> and <a href="https://issues.jboss.org/browse/AGPUSH-2166" target="_blank">AGPUSH-21<wbr>66</a>, which we'll be working on in our next sprint. </div><div><br></div><div>That's it, just wanted to update on what's going on. </div><div>Thanks for the feedback and help, we always appreciate it! </div></div><span class="gmail-m_2512592196931071255m_1414204379716384038HOEnZb"><font color="#888888"><div><br></div><div>Dimitra</div></font></span></div>
</blockquote></div><br></div>
</div></div><br></span><span class="gmail-">______________________________<wbr>_________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
</span><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/aerogear-dev</a><br></blockquote></div><span class="gmail-"><br><br clear="all"><div><br></div>-- <br><div class="gmail-m_2512592196931071255gmail_signature"><div dir="ltr"><div>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.<wbr>wordpress.com/</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div></div></div>
</span></div></div>
<br>______________________________<wbr>_________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div></div>