<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 9, 2017 at 12:03 PM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>in the ups we have some code, that deals w/ old, non InstanceID tokens (which do not contain a ':' char), since those are not FCM compliant, and are therefore not usable for the topic support in FCM.</div><div><br></div><div>Currently I am looking at the tokenloader, and I see there is a bit of complexity, and odd code, that deals w/ that. While I do understand that in the 1.1.x line we wanna keep this, do we really want to keep if for the master branch ? </div><div><br></div><div>How realistically is it, that UPS users are using a non InstanceID token? Or Android Push APIs are now over a year on the latest of Google's FCM APIs (in android/client).</div></div></blockquote><div><br></div><div>So it is unlikely that users of newer versions of UPS are not updating their client apps. So users using the new versions of UPS which only support FCM probably will have the FCM version of the AeroGear libraries.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>Do we feel OK to remove that from the master branch, at some point ? </div></div></blockquote><div><br></div><div>I think that is a reasonable idea.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>Cheers,</div><div>Matthias </div><span class="HOEnZb"><font color="#888888"><div><br></div><div><br clear="all"><div><br></div>-- <br><div class="m_-5145009282210042288gmail_signature"><div dir="ltr"><div>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.<wbr>wordpress.com/</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div></div></div>
</div></font></span></div>
<br>______________________________<wbr>_________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div></div>