<div dir="ltr">great starting point!</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 9, 2018 at 2:20 PM, Adam Saleh <span dir="ltr"><<a href="mailto:asaleh@redhat.com" target="_blank">asaleh@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><div><div><div>Hi all,<br><br></div>after a day or so of fiddling around, there is now a mandatory check on the mobile-cli repository [1],<br></div>running on our trusted jenkins-wendy [2]. If there are any problems with the check, please shout at me on IRC :-)<br><br></div>Check themselves are quite benign right now:<br></div>* installs dependencies through glide<br></div>* runs make build (after last Craigs PR this includes some tests as well)<br></div>* tries to run the 'mobile' binary to print out the help<br><br></div>I think this is a good start and as next steps I will probably try to do<br></div>* some proper documentation about i.e. updating the slave image if somebody would need to<br></div>* adding proper test-result/coverage collecting<br><div><div><div><br></div><div>I am putting together a proper proposal for PR-testing in Aerogear, where we could discuss how thorough do we want to have these tests.<br></div><div><div><div><div><div><div><br></div><div>Please let me know what you think about this :-)<br></div><div><br></div><div>Adam<br></div><div><br>[1] <a href="https://github.com/aerogear/mobile-cli/blob/master/Jenkinsfile" target="_blank">https://github.com/aerogear/<wbr>mobile-cli/blob/master/<wbr>Jenkinsfile</a></div><div>[2] <a href="https://jenkins-wendy.ci.feedhenry.org/job/aerogear/job/mobile-cli/" target="_blank">https://jenkins-wendy.ci.<wbr>feedhenry.org/job/aerogear/<wbr>job/mobile-cli/</a></div></div></div></div></div></div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Craig Brookes<div>RHMAP </div><div>@maleck13 Github</div></div></div>
</div>