<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class="">One of the captured metrics is ‚push_requests_total‘. It would be nice to add a label here to group by platform, e.g. ‚push_requests_total{platform=„android“} = 5.0‘</div><div class=""><br class=""></div><div class="">About the default metrics. They are free and i think we should include them just to have the same behavior in our metrics endpoints as much as possible.</div><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">Am 22.01.2018 um 11:43 schrieb David Martin <<a href="mailto:davmarti@redhat.com" class="">davmarti@redhat.com</a>>:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">There are 2 metrics already captured in the push server metrics endpoint.</div><div class="">More info here</div><div class=""><a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/949" class="">https://github.com/aerogear/aerogear-unifiedpush-server/pull/949</a><br class=""></div><div class=""><div class="">Related trello with more info on the story [1]</div></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">I'm interested in any suggestions on what else could/should be included in the metrics endpoint.</div><div class=""><br class=""></div><div class="">CPU/RAM will already be captured by heapster in openshift<br class=""></div><div class=""><br class=""></div><div class="">Any thoughts on using the same approach as keycloak & including default exports<br class=""></div><div class=""><a href="https://github.com/prometheus/client_java#included-collectors" class="">https://github.com/prometheus/client_java#included-collectors</a></div><div class=""><a href="https://github.com/aerogear/keycloak-metrics-spi/blob/master/src/main/java/org/jboss/aerogear/keycloak/metrics/PrometheusExporter.java#L55" class="">https://github.com/aerogear/keycloak-metrics-spi/blob/master/src/main/java/org/jboss/aerogear/keycloak/metrics/PrometheusExporter.java#L55</a></div><div class="">?</div><div class=""><br class=""></div><div class="">Is there anything else specific to administering a push server that would be useful?</div><div class=""><br class=""></div><div class="">[1] <a href="https://trello.com/c/tPin7vee/22-as-a-developer-i-want-to-be-able-to-expose-metrics-data-about-push-in-prometheus-format-from-an-endpoint-of-this-service" class="">https://trello.com/c/tPin7vee/22-as-a-developer-i-want-to-be-able-to-expose-metrics-data-about-push-in-prometheus-format-from-an-endpoint-of-this-service</a></div>-- <br class=""><div class="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class="">David Martin<div class="">Red Hat Mobile</div><div class="">Twitter: <span style="font-size:12.8px" class="">@irldavem</span></div><div class=""><span style="font-size:12.8px" class="">IRC: @irldavem (#aerogear)</span></div></div></div></div></div></div></div>
</div>
_______________________________________________<br class="">feedhenry-dev mailing list<br class=""><a href="mailto:feedhenry-dev@redhat.com" class="">feedhenry-dev@redhat.com</a><br class="">https://www.redhat.com/mailman/listinfo/feedhenry-dev<br class=""></div></blockquote></div><br class=""></body></html>