<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 22, 2018 at 12:23 PM, Peter Braun <span dir="ltr"><<a href="mailto:pbraun@redhat.com" target="_blank">pbraun@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div>One of the captured metrics is ‚push_requests_total‘. It would be nice to add a label here to group by platform, e.g. ‚push_requests_total{platform=<wbr>„android“} = 5.0‘</div></div></blockquote><div><br></div><div>+1 we could do that, instead (or in addition)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><br></div><div>About the default metrics. They are free and i think we should include them just to have the same behavior in our metrics endpoints as much as possible.</div></div></blockquote><div><br></div><div>+1 </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><br><div><br><blockquote type="cite"><div><div class="h5"><div>Am 22.01.2018 um 11:43 schrieb David Martin <<a href="mailto:davmarti@redhat.com" target="_blank">davmarti@redhat.com</a>>:</div><br class="m_5543912915449543323Apple-interchange-newline"></div></div><div><div><div class="h5"><div dir="ltr"><div>There are 2 metrics already captured in the push server metrics endpoint.</div><div>More info here</div><div><a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/949" target="_blank">https://github.com/aerogear/<wbr>aerogear-unifiedpush-server/<wbr>pull/949</a><br></div><div><div>Related trello with more info on the story [1]</div></div><div><br></div><div><br></div><div>I'm interested in any suggestions on what else could/should be included in the metrics endpoint.</div><div><br></div><div>CPU/RAM will already be captured by heapster in openshift<br></div><div><br></div><div>Any thoughts on using the same approach as keycloak & including default exports<br></div><div><a href="https://github.com/prometheus/client_java#included-collectors" target="_blank">https://github.com/prometheus/<wbr>client_java#included-<wbr>collectors</a></div><div><a href="https://github.com/aerogear/keycloak-metrics-spi/blob/master/src/main/java/org/jboss/aerogear/keycloak/metrics/PrometheusExporter.java#L55" target="_blank">https://github.com/aerogear/<wbr>keycloak-metrics-spi/blob/<wbr>master/src/main/java/org/<wbr>jboss/aerogear/keycloak/<wbr>metrics/PrometheusExporter.<wbr>java#L55</a></div><div>?</div><div><br></div><div>Is there anything else specific to administering a push server that would be useful?</div><div><br></div><div>[1] <a href="https://trello.com/c/tPin7vee/22-as-a-developer-i-want-to-be-able-to-expose-metrics-data-about-push-in-prometheus-format-from-an-endpoint-of-this-service" target="_blank">https://trello.com/c/<wbr>tPin7vee/22-as-a-developer-i-<wbr>want-to-be-able-to-expose-<wbr>metrics-data-about-push-in-<wbr>prometheus-format-from-an-<wbr>endpoint-of-this-service</a></div>-- <br><div class="m_5543912915449543323gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">David Martin<div>Red Hat Mobile</div><div>Twitter: <span style="font-size:12.8px">@irldavem</span></div><div><span style="font-size:12.8px">IRC: @irldavem (#aerogear)</span></div></div></div></div></div></div></div>
</div></div></div>
______________________________<wbr>_________________<br>feedhenry-dev mailing list<br><a href="mailto:feedhenry-dev@redhat.com" target="_blank">feedhenry-dev@redhat.com</a><br><a href="https://www.redhat.com/mailman/listinfo/feedhenry-dev" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/feedhenry-dev</a><br></div></blockquote></div><br></div><br>______________________________<wbr>_________________<br>
feedhenry-dev mailing list<br>
<a href="mailto:feedhenry-dev@redhat.com">feedhenry-dev@redhat.com</a><br>
<a href="https://www.redhat.com/mailman/listinfo/feedhenry-dev" rel="noreferrer" target="_blank">https://www.redhat.com/<wbr>mailman/listinfo/feedhenry-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Project lead AeroGear.org</div></div>
</div></div>