<div dir="ltr">I see you on the team -> <a href="https://hub.docker.com/u/darahayes/">https://hub.docker.com/u/darahayes/</a> (at least this account) </div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 15, 2018 at 11:51 AM, Dara Hayes <span dir="ltr"><<a href="mailto:dara.hayes@redhat.com" target="_blank">dara.hayes@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I 100% agree that it should be in the aerogear org and I suggested it at the time. However, we were never given access (even though we asked) :)</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 15, 2018 at 10:26 AM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:mwessend@redhat.com" target="_blank">mwessend@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The other question is ... is "aerogearcatalog" the right choice ? <div><br></div><div>IMO no - since that <a href="https://github.com/aerogear/grafana-docker" target="_blank">https://github.com/aeroge<wbr>ar/grafana-docker</a> is not an APB</div><div><br></div><div>IMO it would be better in "aerogear" dh org ;-) </div></div><div class="gmail_extra"><div><div class="m_7980509857382695235h5"><br><div class="gmail_quote">On Thu, Mar 15, 2018 at 11:25 AM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:mwessend@redhat.com" target="_blank">mwessend@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">there is no issue w/ forks etc :-)<div><br></div><div>I just found it very annoying not seeing any hint on the repo, in dockerhub :-)</div><div><br></div><div>I will update it </div></div><div class="gmail_extra"><div><div class="m_7980509857382695235m_-4258478805831496951h5"><br><div class="gmail_quote">On Thu, Mar 15, 2018 at 11:19 AM, Dara Hayes <span dir="ltr"><<a href="mailto:dara.hayes@redhat.com" target="_blank">dara.hayes@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">TL;DR: We forked the grafana build tools [0] and built a commit off the master branch that we knew to be stable. In addition we modified the build scripts to include some Grafana plugins inside the container image. There were two reasons we did this.</span><div><br></div><div>1. We were depending on new features in Grafana that were only available on the master branch. Grafana was under very heavy development as they geared up towards their 5.0 release and we were finding new problems arising every few days while we worked off the master branch. This was really slowing down APB development. </div><div><br></div><div>2. We needed to install additional plugins required by some dashboards. <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Grafana's docker image provides a way to install plugins using environment variables fed into the container at runtime but this requires root access which is not feasible in Openshift.</span> The only way we could do it at the time was by baking in the plugins as part of the docker build. It's a terrible solution but it was the only way at the time to continue the very fast pace of development of the APBs.<div><br></div></div><div>There are still a some questions to be answered:<br></div><div><br></div><div>* How are we going to distribute Grafana on OpenShift such that it doesn't require root access?</div><div>* What is the best way to install plugins? There was some discussion about the different options and the consequences of those options in this document [1]</div><div><br></div><div>This all arose during a sprint where one of the primary goals was to deliver an APB that could provision Grafana + Prometheus and display dashboard discovery and some other features. We decided at the time that we were not prepared to answer those bigger questions so we knowingly put this technical debt on ourselves and implemented a quick and dirty solution.</div><div><br></div><div>This entire thing was discussed publicly in a Github PR: <a href="https://github.com/aerogearcatalog/keycloak-apb/pull/33" target="_blank">https://github.com/aerogea<wbr>rcatalog/keycloak-apb/pull/33</a> But perhaps it should also have been mentioned on list at the time. Hope this clears things up.</div><div><br></div><div>[0]: <a href="https://github.com/aerogear/grafana-docker" target="_blank">https://github.com/aeroge<wbr>ar/grafana-docker</a></div><div>[1]: <a href="https://docs.google.com/document/d/1WAUQ9IfJovSSUsHYR2PU3UeRWdpuyoKN9_ImyVv6dhc/edit#heading=h.yf74gvpjt77w" target="_blank">https://docs.google.com/d<wbr>ocument/d/1WAUQ9IfJovSSUsHYR2P<wbr>U3UeRWdpuyoKN9_ImyVv6dhc/edit#<wbr>heading=h.yf74gvpjt77w</a></div></div><div class="gmail_extra"><div><div class="m_7980509857382695235m_-4258478805831496951m_5601235587816336421h5"><br><div class="gmail_quote">On Thu, Mar 15, 2018 at 9:27 AM, David Martin <span dir="ltr"><<a href="mailto:davmarti@redhat.com" target="_blank">davmarti@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I remember a rember there's a reason for having a custom image built<br>
(we need specific features that aren't in latest upstream image), but<br>
I'm not sure who pushed it up and from where.<br>
<br>
@Dara @Steven, is there a fork of grafana or some repo where we have<br>
the Dockerfile?<br>
<div class="m_7980509857382695235m_-4258478805831496951m_5601235587816336421m_-8298056028604154705HOEnZb"><div class="m_7980509857382695235m_-4258478805831496951m_5601235587816336421m_-8298056028604154705h5"><br>
On 14 March 2018 at 15:15, Matthias Wessendorf <<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>> wrote:<br>
> Hi,<br>
><br>
> I am not able to find the image for this container:<br>
> <a href="https://hub.docker.com/r/aerogearcatalog/grafana/" rel="noreferrer" target="_blank">https://hub.docker.com/r/aerog<wbr>earcatalog/grafana/</a><br>
><br>
> If not an automated build repo, we should at least point to the actual<br>
> aerogear GH repository, where the thing is located.<br>
><br>
> Thanks<br>
><br>
> --<br>
> Matthias Wessendorf<br>
><br>
> github: <a href="https://github.com/matzew" rel="noreferrer" target="_blank">https://github.com/matzew</a><br>
> twitter: <a href="http://twitter.com/mwessendorf" rel="noreferrer" target="_blank">http://twitter.com/mwessendorf</a><br>
><br>
> --<br>
> You received this message because you are subscribed to the Google Groups<br>
> "Aerogear" group.<br>
> To unsubscribe from this group and stop receiving emails from it, send an<br>
> email to <a href="mailto:aerogear%2Bunsubscribe@googlegroups.com" target="_blank">aerogear+unsubscribe@googlegro<wbr>ups.com</a>.<br>
> To post to this group, send email to <a href="mailto:aerogear@googlegroups.com" target="_blank">aerogear@googlegroups.com</a>.<br>
> To view this discussion on the web visit<br>
> <a href="https://groups.google.com/d/msgid/aerogear/CAAg5f2RgsYFDWqG%3DX%3Dj%3D48fVhCH2nrgjRuXNdNF9za3nt8uhSQ%40mail.gmail.com" rel="noreferrer" target="_blank">https://groups.google.com/d/ms<wbr>gid/aerogear/CAAg5f2RgsYFDWqG%<wbr>3DX%3Dj%3D48fVhCH2nrgjRuXNdNF9<wbr>za3nt8uhSQ%40mail.gmail.com</a>.<br>
> For more options, visit <a href="https://groups.google.com/d/optout" rel="noreferrer" target="_blank">https://groups.google.com/d/op<wbr>tout</a>.<br>
<br>
<br>
<br>
</div></div><span class="m_7980509857382695235m_-4258478805831496951m_5601235587816336421m_-8298056028604154705HOEnZb"><font color="#888888">--<br>
David Martin<br>
Red Hat Mobile<br>
Twitter: @irldavem<br>
IRC: @irldavem (#aerogear)<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br></div></div><div class="m_7980509857382695235m_-4258478805831496951m_5601235587816336421m_-8298056028604154705gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase">Dara Hayes</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">Associate software engineer</p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://redhat.com" style="color:rgb(17,85,204)" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto" alt=""></a></td><td style="font-size:10px"><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></td></tr></tbody></table><div style="font-size:12.8px;color:rgb(0,0,0);font-family:overpass,sans-serif"><div style="font-size:10px;color:rgb(153,153,153)"><br></div></div></div></div></div></div>
</div><span>
<p></p>
-- <br>
You received this message because you are subscribed to the Google Groups "Aerogear" group.<br>
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="mailto:aerogear+unsubscribe@googlegroups.com" target="_blank">aerogear+unsubscribe@googlegro<wbr>ups.com</a>.<br>
To post to this group, send email to <a href="mailto:aerogear@googlegroups.com" target="_blank">aerogear@googlegroups.com</a>.<br></span>
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/aerogear/CABkcJC19HDKXS2jTUMj%2BU8Z8e27o4uD55Rea%2B7Eu8KSfBY4nrg%40mail.gmail.com?utm_medium=email&utm_source=footer" target="_blank">https://groups.google.com/d/ms<wbr>gid/aerogear/CABkcJC19HDKXS2jT<wbr>UMj%2BU8Z8e27o4uD55Rea%2B7Eu8K<wbr>SfBY4nrg%40mail.gmail.com</a>.<div class="m_7980509857382695235m_-4258478805831496951m_5601235587816336421HOEnZb"><div class="m_7980509857382695235m_-4258478805831496951m_5601235587816336421h5"><br>
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank">https://groups.google.com/d/op<wbr>tout</a>.<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="m_7980509857382695235m_-4258478805831496951HOEnZb"><font color="#888888">-- <br><div class="m_7980509857382695235m_-4258478805831496951m_5601235587816336421gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Project lead AeroGear.org</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="m_7980509857382695235HOEnZb"><font color="#888888">-- <br><div class="m_7980509857382695235m_-4258478805831496951gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Project lead AeroGear.org</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_7980509857382695235gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase">Dara Hayes</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">Associate software engineer</p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://redhat.com" style="color:rgb(17,85,204)" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto" alt=""></a></td><td style="font-size:10px"><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></td></tr></tbody></table><div style="font-size:12.8px;color:rgb(0,0,0);font-family:overpass,sans-serif"><div style="font-size:10px;color:rgb(153,153,153)"><br></div></div></div></div></div></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Project lead AeroGear.org</div></div>
</div>