<div dir="ltr">sounds good to me.<div><br></div><div>TBH, I found it quite confusing, seening that spring dependency in there, just because of BOM support</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 29, 2018 at 11:08 PM, Daniel Passos <span dir="ltr"><<a href="mailto:dpassos@redhat.com" target="_blank">dpassos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="m_-8508827567180015941markdown-here-wrapper"><p style="margin:0px 0px 1.2em!important">Hi,</p>
<p style="margin:0px 0px 1.2em!important">While working on push stuff I figure out Spring dependency management[1] doesn’t work properly with Gradle transitive dependencies[2]. </p>
<p style="margin:0px 0px 1.2em!important">TL;DR It’s ignoring the transitive dependencies and on push, it causes some dependency conflicts. Since Google Services plugin doesn’t found any dependency it’s going to inject it from your on.</p>
<pre style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;font-size:1em;line-height:1.2em;margin:1.2em 0px"><code style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;margin:0px 0.15em;padding:0px 0.3em;white-space:pre-wrap;border:1px solid rgb(234,234,234);background-color:rgb(248,248,248);border-radius:3px;display:inline;white-space:pre-wrap;overflow:auto;border-radius:3px;border:1px solid rgb(204,204,204);padding:0.5em 0.7em;display:block!important">Android dependency 'com.google.firebase:firebase-<wbr>iid' has different version for the compile (11.4.2) and runtime (12.0.1) classpath.
</code></pre><p style="margin:0px 0px 1.2em!important">I’ve sent a PR[3] to remove it for now and revisit it in the future. I have moved all our dependencies version for a single file[4] like most of the libraries do.</p>
<p style="margin:0px 0px 1.2em!important">This also will make us a little more fast and flexible to do changes in our dependencies. </p>
<p style="margin:0px 0px 1.2em!important">Any thoughts?</p>
<p style="margin:0px 0px 1.2em!important">[1] <a href="https://github.com/spring-gradle-plugins/dependency-management-plugin" target="_blank">https://github.com/spring-<wbr>gradle-plugins/dependency-<wbr>management-plugin</a><br>[2] <a href="https://docs.gradle.org/current/userguide/managing_transitive_dependencies.html" target="_blank">https://docs.gradle.org/<wbr>current/userguide/managing_<wbr>transitive_dependencies.html</a><br>[3] <a href="https://github.com/aerogear/aerogear-android-sdk/pull/173" target="_blank">https://github.com/aerogear/<wbr>aerogear-android-sdk/pull/173</a><br>[4] <a href="https://github.com/aerogear/aerogear-android-sdk/blob/master/constants.gradle" target="_blank">https://github.com/aerogear/<wbr>aerogear-android-sdk/blob/<wbr>master/constants.gradle</a></p>
<div title="MDH:SGksPGJyPjxkaXY+PGJyPldoaWxlIHdvcmtpbmcgb24gcHVzaCBzdHVmZiBJIGZpZ3VyZSBvdXQg
U3ByaW5nIGRlcGVuZGVuY3kgbWFuYWdlbWVudFsxXSBkb2Vzbid0IHdvcmsgcHJvcGVybHkgd2l0
aCBHcmFkbGUgdHJhbnNpdGl2ZSBkZXBlbmRlbmNpZXNbMl0uIDxicj48YnI+VEw7RFIgSXQncyBp
Z25vcmluZyB0aGUgdHJhbnNpdGl2ZSBkZXBlbmRlbmNpZXMgYW5kIG9uIHB1c2gsIGl0IGNhdXNl
cyBzb21lIGRlcGVuZGVuY3kgY29uZmxpY3RzLiBTaW5jZSBHb29nbGUgU2VydmljZXMgcGx1Z2lu
IGRvZXNuJ3QgZm91bmQgYW55IGRlcGVuZGVuY3kgaXQncyBnb2luZyB0byBpbmplY3QgaXQgZnJv
bSB5b3VyIG9uLjxicj48YnI+YGBgPGJyPkFuZHJvaWQgZGVwZW5kZW5jeSAnY29tLmdvb2dsZS5m
aXJlYmFzZTpmaXJlYmFzZS1paWQnIGhhcyBkaWZmZXJlbnQgdmVyc2lvbiBmb3IgdGhlIGNvbXBp
bGUgKDExLjQuMikgYW5kIHJ1bnRpbWUgKDEyLjAuMSkgY2xhc3NwYXRoLiA8YnI+YGBgPGJyPkkn
dmUgc2VudCBhIFBSWzNdIHRvIHJlbW92ZSBpdCBmb3Igbm93IGFuZCByZXZpc2l0IGl0IGluIHRo
ZSBmdXR1cmUuIEkgaGF2ZSBtb3ZlZCBhbGwgb3VyIGRlcGVuZGVuY2llcyB2ZXJzaW9uIGZvciBh
IHNpbmdsZSBmaWxlWzRdIGxpa2UgbW9zdCBvZiB0aGUgbGlicmFyaWVzIGRvLjxicj48YnI+PC9k
aXY+PGRpdj5UaGlzIGFsc28gd2lsbCBtYWtlIHVzIGEgbGl0dGxlIG1vcmUgZmFzdCBhbmQgZmxl
eGlibGUgdG8gZG8gY2hhbmdlcyBpbiBvdXIgZGVwZW5kZW5jaWVzLiA8YnI+PC9kaXY+PGRpdj48
YnI+QW55IHRob3VnaHRzPzxicj48YnI+WzFdIGh0dHBzOi8vZ2l0aHViLmNvbS9zcHJpbmctZ3Jh
ZGxlLXBsdWdpbnMvZGVwZW5kZW5jeS1tYW5hZ2VtZW50LXBsdWdpbjxicj5bMl0gaHR0cHM6Ly9k
b2NzLmdyYWRsZS5vcmcvY3VycmVudC91c2VyZ3VpZGUvbWFuYWdpbmdfdHJhbnNpdGl2ZV9kZXBl
bmRlbmNpZXMuaHRtbDxicj5bM10gaHR0cHM6Ly9naXRodWIuY29tL2Flcm9nZWFyL2Flcm9nZWFy
LWFuZHJvaWQtc2RrL3B1bGwvMTczPGJyPls0XSBodHRwczovL2dpdGh1Yi5jb20vYWVyb2dlYXIv
YWVyb2dlYXItYW5kcm9pZC1zZGsvYmxvYi9tYXN0ZXIvY29uc3RhbnRzLmdyYWRsZTxiciBjbGVh
cj0iYWxsIj48YnI+PC9kaXY+" style="height:0;width:0;max-height:0;max-width:0;overflow:hidden;font-size:0em;padding:0;margin:0"></div></div><span class="HOEnZb"><font color="#888888"><div class="m_-8508827567180015941markdown-here-signature">-- <br><div class="m_-8508827567180015941gmail_signature"><div dir="ltr">-- Passos<br></div></div>
</div></font></span></div><span class="HOEnZb"><font color="#888888">
<p></p>
-- <br>
You received this message because you are subscribed to the Google Groups "Aerogear" group.<br>
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="mailto:aerogear+unsubscribe@googlegroups.com" target="_blank">aerogear+unsubscribe@<wbr>googlegroups.com</a>.<br>
To post to this group, send email to <a href="mailto:aerogear@googlegroups.com" target="_blank">aerogear@googlegroups.com</a>.<br>
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/aerogear/CADF%3Dh2tqu_R1zY66YxPT2w6U-RdKqCJBfU%2BgtPihjyJEmKsmpg%40mail.gmail.com?utm_medium=email&utm_source=footer" target="_blank">https://groups.google.com/d/<wbr>msgid/aerogear/CADF%3Dh2tqu_<wbr>R1zY66YxPT2w6U-RdKqCJBfU%<wbr>2BgtPihjyJEmKsmpg%40mail.<wbr>gmail.com</a>.<br>
For more options, visit <a href="https://groups.google.com/d/optout" target="_blank">https://groups.google.com/d/<wbr>optout</a>.<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Project lead AeroGear.org</div></div>
</div>