<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3b4d64" style="background-color:#3b4d64;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://issues.jboss.org/s/en_USizp98r-418945332/812/58/_/jira-logo-scaled.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://community.jboss.org/people/mwessendorf/avatar/16.png" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="mwessendorf" id="email_mwessendorf" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=mwessendorf" style="color:#326ca6;">Matthias Wessendorf</a>
commented on <img src="https://issues.jboss.org/images/icons/newfeature.gif" height="16" width="16" border="0" align="absmiddle" alt="Feature Request"> <a style='color:#326ca6;text-decoration:none;' href='https://issues.jboss.org/browse/AEROGEAR-855'>AEROGEAR-855</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#326ca6;text-decoration:none;' href='https://issues.jboss.org/browse/AEROGEAR-855'><strong>ios: read:id is broken</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>The impl code:</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">-(void) read:(id)value
success:(void (^)(id responseObject))success
failure:(void (^)(NSError *error))failure {
<span class="code-keyword">if</span> (value == nil || [value isKindOfClass:[NSNull class]]) {
[self raiseError:@<span class="code-quote">"read"</span> msg:@<span class="code-quote">"read id value was nil"</span> failure:failure];
<span class="code-comment">// <span class="code-keyword">do</span> nothing
</span> <span class="code-keyword">return</span>;
}
<span class="code-comment">// <span class="code-keyword">try</span> to add auth.token:
</span> [self applyAuthToken];
<span class="code-comment">// TODO: move to function:
</span> NSString* objectKey;
<span class="code-keyword">if</span> ([value isKindOfClass:[NSString class]]) {
objectKey = value;
} <span class="code-keyword">else</span> {
objectKey = [value stringValue];
}
[_restClient getPath:[self appendObjectPath:objectKey] parameters:nil success:^(AFHTTPRequestOperation *operation, id responseObject) {
<span class="code-keyword">if</span> (success) {
<span class="code-comment">//TODO: NSLog(@<span class="code-quote">"Invoking successblock...."</span>);
</span> success(responseObject);
}
} failure:^(AFHTTPRequestOperation *operation, NSError *error) {
<span class="code-keyword">if</span> (failure) {
<span class="code-comment">//TODO: NSLog(@<span class="code-quote">"Invoking failure block...."</span>);
</span> failure(error);
}
}];
}
</pre>
</div></div>
<p>More todo:</p>
<ul>
<li>move the string value fu into a function (there are other places in the class, that do the same....)</li>
<li>Since the unit test passes... we also need an integration test (on the integration test app)
<ul>
<li>read with string:
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">[_tasks read:@<span class="code-quote">"72"</span> success:^(id responseObject) {........
</pre>
</div></div></li>
<li>read with number:
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">[_tasks read:@72 success:^(id responseObject) {........
</pre>
</div></div></li>
</ul>
</li>
</ul>
</div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->