<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3b4d64" style="background-color:#3b4d64;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://issues.jboss.org/s/en_USd3nf01-418945332/852/58/_/jira-logo-scaled.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://community.jboss.org/people/beve/avatar/16.png" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="beve" id="email_beve" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=beve" style="color:#326ca6;">Daniel Bevenius</a>
created <img src="https://issues.jboss.org/images/icons/issuetypes/task.png" height="16" width="16" border="0" align="absmiddle" alt="Task"> <a style='color:#326ca6;text-decoration:none;' href='https://issues.jboss.org/browse/AGPUSH-180'>AGPUSH-180</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#326ca6;text-decoration:none;' href='https://issues.jboss.org/browse/AGPUSH-180'><strong>Update to latest version of Netty</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Issue Type:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<img src="https://issues.jboss.org/images/icons/issuetypes/task.png" height="16" width="16" border="0" align="absmiddle" alt="Task"> Task
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Affects Versions:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
0.4.0 </td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Assignee:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="beve" id="email_beve" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=beve" style="color:#326ca6;">Daniel Bevenius</a>
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Components:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
SimplePush-server </td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Created:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
19/Jul/13 4:58 AM
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<p style='margin-top:0;margin-bottom:10px;'>Test will break with the latest version of Netty (currently 4.0.4.Final-SNAPSHOT). This task should fix these test failures:</p>
<div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent">
<pre>websocketUnregister(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest) Time elapsed: 0.052 sec <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketUnregister(SimplePushSockJSServiceTest.java:211)
websocketHandleAcknowledgements(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest) Time elapsed: 0.001 sec <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketHandleAcknowledgements(SimplePushSockJSServiceTest.java:258)
websocketRegisterDuplicateChannelId(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest) Time elapsed: 0.003 sec <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketRegisterDuplicateChannelId(SimplePushSockJSServiceTest.java:199)
websocketHandleAcknowledgement(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest) Time elapsed: 0.095 sec <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketHandleAcknowledgement(SimplePushSockJSServiceTest.java:240)
websocketHello(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest) Time elapsed: 0 sec <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketHello(SimplePushSockJSServiceTest.java:175)
websocketUnregisterNonRegistered(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest) Time elapsed: 0.138 sec <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketUnregisterNonRegistered(SimplePushSockJSServiceTest.java:223)
websocketRegister(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest) Time elapsed: 0.01 sec <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketRegister(SimplePushSockJSServiceTest.java:186)
</pre>
</div></div>
<p style='margin-top:0;margin-bottom:10px;'>This was handled in the SockJS test by discarding empty responses for the websocket tests in question:</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">
<span class="code-keyword">private</span> <span class="code-object">Object</span> readOutboundDiscardEmpty(<span class="code-keyword">final</span> EmbeddedChannel ch) {
<span class="code-keyword">final</span> <span class="code-object">Object</span> obj = ch.readOutbound();
<span class="code-keyword">if</span> (obj <span class="code-keyword">instanceof</span> ByteBuf) {
<span class="code-keyword">final</span> ByteBuf buf = (ByteBuf) obj;
<span class="code-keyword">if</span> (buf.capacity() == 0) {
ReferenceCountUtil.release(buf);
<span class="code-keyword">return</span> ch.readOutbound();
}
}
<span class="code-keyword">return</span> obj;
}
</pre>
</div></div>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Fix Versions:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
0.4.0 </td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Project:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a style="color:#326ca6;" href="https://issues.jboss.org/browse/AGPUSH">AeroGear Push</a>
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Priority:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<img src="https://issues.jboss.org/images/icons/priorities/major.png" height="16" width="16" border="0" align="absmiddle" alt="Major"> Major
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Reporter:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="beve" id="email_beve" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=beve" style="color:#326ca6;">Daniel Bevenius</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->