<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://issues.jboss.org" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://developer.jboss.org/gravatar/1ce36ce1c246b989f9cd79504c400b08?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="lfryc" id="email_lfryc" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=lfryc" style="color:#3b73af;; color: #3b73af; text-decoration: none">Lukáš Fryč</a> <strong>commented</strong> on <a href="https://issues.jboss.org/browse/AGJS-211" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-task-754a8edf-c121-4c3d-a788-6d80e3d77f96" height="16" width="16" border="0" align="absmiddle" alt="Task" /> AGJS-211</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AGJS-211" style="color: #3b73af; text-decoration: none">Re: Rework Integration Tests from the ground up</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">I've revamped the tests in this way so far:</p>
<ul>
<li>
implemented "download" multi-task (could be exposed as grunt module)
<ul>
<li>
leaving aside its name, it does actually much more: 1. downloads distribution, 2. validates checksum, 3. extracts, 4. extracts configuration file (overlay), 5. renames to the stable name (e.g. runtimes/apache-activemq instead of apache-activemq-5.8.0)
</li>
</ul>
</li>
<li>
ability to kill the process running on background
<ul>
<li>
each need to use different approach
<ul>
<li>
activemq runs as daemon, is needs to be killed by running 'activemq stop' command
</li>
<li>
vertx runs as process, can be killed simply by issuing SIGTERM
</li>
</ul>
</li>
<li>
when grunt ends prematurily (by killing its process or by test failure) the server is stopped gracefully (that requires grunt:0.4.1 as highter versions contains a bug/limitation)
</li>
<li>
we are able to stop the server after test by executing :stop subtask
</li>
</ul>
</li>
<li>
tests rewritten to Karma
<ul>
<li>
that wasn't intentional first, but Karma has another advantage - it uses its own server and bypasses browser security (CORS) so testing is much easier
<ul>
<li>
as connect can't be killed gracefully after the test (at least not simple way)
</li>
</ul>
</li>
<li>
Karma has one downside though, it can't load HTML file with QUnit script (at least not vanilla Karma), because it expects files array in the config
</li>
</ul>
</li>
</ul>
<p style="margin: 10px 0 0 0">I believe this approach has certain advantages:</p>
<ul>
<li>
configuration for downloads is way simpler (declarative)
<ul>
<li>
all you need is <a href="https://github.com/lfryc/aerogear-js-integration/blob/a6ef97b7b0c24f0d23da49ef923384503bd71ac7/Gruntfile.js#L65" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">declaring http urls</a>
</li>
<li>
it is also smart: installs new runtime just when needed
</li>
<li>
because it uses temporary folder for extraction we know exactly when the distribution is ready to be moved to its position (process-kill-proof solution)
</li>
</ul>
</li>
<li>
running tasks is faster and more stable (in theory, the time will tell us)
<ul>
<li>
its faster because it <a href="https://github.com/lfryc/aerogear-js-integration/blob/a6ef97b7b0c24f0d23da49ef923384503bd71ac7/Gruntfile.js#L80" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">waits for certain log in process' stdout</a> (as oppose to waiting hard-coded delay time)
</li>
<li>
its more stable because thanks to using <tt>grunt-external-daemon</tt> the processes are handled correctly
</li>
</ul>
</li>
<li>
it can be simply debugged
<ul>
<li>
<tt>grunt ... --verbose --debug</tt>
</li>
</ul>
</li>
<li>
the only what <tt>aerogear-js</tt> needs to do is make sure <tt>aerogear-js-integration</tt> is cloned and then run <tt>grunt ci:activemq ci:vertx</tt>
</li>
</ul>
<p style="margin: 10px 0 0 0">Some disadvantages:</p>
<ul>
<li>
none
<ul>
<li>
just kidding, here it is:
</li>
</ul>
</li>
<li>
using forked version of <tt>grunt-external-daemon</tt>
<ul>
<li>
the original didn't handle kill processes and didn't support a way of stopping that activemq requires as a daemon process
</li>
<li>
but we should contribute this improvement back
</li>
<li>
the project doesn't use cleaneast project ever and I made it even bigger mess, some re-structure would be nice after agreement with an original author <img class="emoticon" src="https://issues.jboss.org/images/icons/emoticons/wink.gif" height="16" width="16" align="absmiddle" alt="" border="0" />
</li>
</ul>
</li>
</ul>
<p style="margin: 10px 0 0 0">The code is here:</p>
<p style="margin: 10px 0 0 0">aerogear-js: <a href="https://github.com/lfryc/aerogear-js/tree/AGJS-211-rework-integration-tests" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">https://github.com/lfryc/aerogear-js/tree/AGJS-211-rework-integration-tests</a></p>
<p style="margin: 10px 0 0 0">aerogear-js-integration: <a href="https://github.com/lfryc/aerogear-js-integration/tree/AGJS-211-rework-integration-tests" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">https://github.com/lfryc/aerogear-js-integration/tree/AGJS-211-rework-integration-tests</a></p>
<p style="margin: 10px 0 0 0">Some polishing is still needed as it is still rather proof of concept.<br /> Old configs and dependencies need to be removed. </p>
<p style="margin: 10px 0 0 0">Some commands to play with after clones:</p>
<ul>
<li>
<tt>grunt ci:vertx ci:activemq</tt>
</li>
<li>
<tt>grunt ci:vertx --verbose --debug</tt>
</li>
</ul>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AGJS-211#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-da7bba83-2fd5-4575-bfa0-5388a389d00f" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/AGJS-211#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.3.1#6329-<span title="7df76f1f758b4c5e4d2f2d8aa6679c1ae74a2e4e" data-commit-id="7df76f1f758b4c5e4d2f2d8aa6679c1ae74a2e4e}">sha1:7df76f1</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-779dc5e7-4e7b-4e13-9ba7-aa9d704cc278" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>