<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.jboss.org">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/0d5a0dc52688f185ff93275f1ec9e7ff?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="peter.braun" id="email_peter.braun" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=peter.braun" style="color:#3b73af;; color: #3b73af; text-decoration: none">Peter Braun</a> <strong>edited a comment</strong> on <a href="https://issues.jboss.org/browse/AEROGEAR-2023" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-b9545e37-1253-4717-b5fd-21f9dabb6c58" height="16" width="16" border="0" align="absmiddle" alt="Task"> AEROGEAR-2023</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-2023" style="color: #3b73af; text-decoration: none">Re: Evaluate the fh-sync-server & SDKs in terms of feature requests and known problems</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0; padding-top: 10px"> <span class="diffcontext">Following are my results of the investigation of fh-sync (with fh-sync-server and fh-sync-js). To start off I felt that fh-sync was somewhat hard to use and get into. It could definitely use a getting started kind and more simple examples.<br><br>*Overview*<br><br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">_Mobile Platforms_</span> <span class="diffaddedchars" style="background-color:#ddfade;">_*Mobile Platforms*_</span> <span class="diffcontext">: we support Cordova, iOS and Android. Support for react native is possible and has been tried here: https://github.com/emilioicai/react-native-fh-sync<br><br>_Mobile API_: i have mostly looked at the javascript API, but at least the Android API looks reasonably similar. The Javascript API is somewhat non-standard. It doesn't use Promises and makes use of older-style success/fail callbacks instead of error first callbacks. This makes it hard to use in combination with other libraries like async (which expects error first) or Promise based libraries.<br><br>The API is based around Datasets and offers CRUDL operations. A dataset seems to translate to a Mongodb collection but can also be represented by another data store on the backend.<br><br>A Typescript typing for the API is available wich provides good code completion support (even when used with regular Javascript). One problem with the typing is that the return types of the callbacks are not typed (they use Typescript's _any_ type). Having code completion on the return types would help a lot considering there is no documentation that explains what the different operations (create, list, update) exactly return.<br><br>_Syncing mechanism to a remote database & other mobile apps_<br><br>The backend component (fh-sync-server) is dependent on Mongodb and Redis. If no external storage is used (and possibly also if it is) it will create a collection for each dataset in it's Mongo database. I have not been able to make this work, so I can't say if this storage is sufficient for a Setup where no external storage is available but i would assume that it is usually. The syncing mechanism relies on sync loops on the frontend and backend. The frequency of those loops is configurable. One of the problems of the mechanism is that it's hashing algorithm traverses the data and can become slow (also outlined in Wei's analysis). Syncing can take quite a bit (10-30 seconds) with the default configurations.<br><br>_Offline Capability_<br><br>The Javascript library has offline capabilities and offers a number of storage strategies. Again, this needs documentation, examples, when to use which strategy... There was some strange behavior with the 'dom' strategy where I deleted the database but the records reappeard (could also be seen as a feature). This did not happen using the 'memory' strategy.<br><br>_Conflicts_<br><br>Clients can list collisions (two updates to the same record from two different clients). Custom conflict solving strategies can be implemented on the backend by overriding handlers. The default implementation seems to accept a record that causes a conflict and overwrite the existing one.<br><br>_Authentication and Authorization_<br><br>fh-sync does not provider built in solutions for this. But there are ways to achieve this. Basic KeyCloak support has been implemented in fh-sync-server. Role based access could be implemented by overriding the CRUDL handlers on the server side. We might need to do some work to make it possible to pass the http request/response/session objects into those handlers. On the Client side authentication could be achieved by either handling it outside of fh-sync-js (e.g. store the auth token in a HTML header) or by overriding a handler that lets you add metadata to records before they are sent to the Server.<br><br>_Data Source Integrations_<br><br>This seems to be one of the strong points of fh-sync (as long as we want to store JSON objects). The backend allows us to override the handlers for all CRUDL operations. This means we usually get the ID/Record and can decide what to do with them. We could talk to Postgres, call external REST endpoints, store the records on disc... One of the problems is (as Wei also outlined) that storing binary data is not well supported in JSON. Base64 encoding could work but increases the payload size. We might want to look into frameworks like Apache Thrift to improve our binary data exchange story.<br><br>_Using with an API Gateway (3scale)_<br><br>This should not be a problem since fh-sync is completely http request based.<br><br>_Monitoring/Metrics_<br><br>fh-sync-server provides a good metrics endpoint already.<br><br>_Alerting/Hooks_<br><br>Since there is a Prometheus compatible metrics endpoint and Prometheus supports alerting, we might want look into that for Alerting support.<br><br>_Compatibility with Kubernetes/Openshift_<br><br>There should be nothing from preventing us running fh-sync-server on Openshift (e.g. process does not need to run as root). APBs and Images already exist. We have full control over this.<br><br>*Analysis based on Trello Cards*<br><br>_As a Developer I wnat real time Sync with web sockets so that data is synchronized as quickly as possible_<br><br>*Not met*. fh-sync does not have support for Websockets at the moment. But with the way the sync protocol works i don't see any Reason why we could not make it work on Websockets. The authentication story mitght look a bit different in that case (no HTTP headers?). If we want to go full-binary support with Apache Thrift we're also good: thrift does support Websockets.<br><br>_As a developer I want to be able to trigger events when specific conditions (e.g. number of pending messages for a specific client) is reached so that I can proactively take action in response to such events._<br><br>*Not met*. As suggested above, one way to achieve this would be using Prometheus buit-in alerting capabilities. The drawback is that this would then only work if the metrics-apb is also deployed.<br><br>_As a developer i would like to be able to protect Sync with an API Gaetway_<br><br>*Met*. Currently sync only uses http requests which makes it nicely compatible with 3scale. Even with Websockets it should be possible (haven't tested it though).<br><br>_As a developer I want to be able to expose metrics data about Sync in prometheus format from an endpoint of the service._<br><br>*Met*. fh-sync-server provides this already and it can be extended if needed.<br><br>_As a developer I want to be able to trigger events when specific conditions (e.g. number of pending messages for a specific client) is reached so that I can proactively take action in response to such events._<br><br>*Not met*. But this could also be achieved by making use of Prometheus Alerts and Gauges in the metrics endpoint, e.g.<br><br>{code}<br>sync_pending_messages{clientId=<clientId>} = <really high number><br>{code}<br><br>_As a developer I want a pluggable storage engine available on the client side so that I can use the most appropriate storage engine for my needs_<br><br>*Met*. fh-sync does allow to override CRUDL handlers. This can be used to implement different storage strageties like Filesystem, Relational Database, etc.<br><br>_As a developer I want the ability to synchronise binary data (e.g. photos, videos, audio files) via the Sync Framework._<br><br>*Not met*. It might be possible by abusing JSON and base64 encoding but that's not ideal. We might want to look into frameworks like Apache Thrift for our protocol.<br><br>_As a security conscious developer I want to be able to apply role/permission checks on incoming sync requests so that I can ensure only authorised users are able to access specific datasets._<br><br>*Mostly met*. But left to implementation: fh-sync allows to override all CRUDL handlers. Permission and Role checks can be performed there. We might need to do some work to make it possible to pass the http request/response/session objects to those handlers. In case of Websockets this could be more complex.<br><br>_As a developer I want the ability to encrypt key pieces of data while still being able to query against non encrypted fields so that I can still query data even when it has encrypted pieces._<br><br>*Not met*. As far as i am aware there is not built-in encryption capabilities in fh-sync. I'm not sure if this belongs into fh-sync at all. But it might be possible to extend fh-sync-server and make it encrypt data with a (user) provided key before sending it on to an external data store.<br><br>_As a developer I want the option of using diff-sync so that only the changed data is synced and not the entire payload._<br><br>*Unsure*. According to https://github.com/feedhenry/fh-sync/blob/master/docs/sync_protocol.adoc (Point 8) this is at least partly the case.<br><br>_As a developer I want to be able to choose where on the server side I store binary data that is being synced._<br><br>*Not met*. Since we don't provide a good binary story at the moment. Otherwise this sounds like it could be achieved by overriding the handlers, or do we want to make it an easier Option for users?<br><br>_As a developer I want to be able to define the structure of my data sets so that I can use structured data stores on the client and provide the most efficient sync experience possible_<br><br>*Not met*. We don't have that at the moment. GraphQL could be an Option if it allows us to form a query that has all the fields that should be synced and leave out the ones we don't care about. Rather large piece of work i'd assume.<br><br>_As a sync customer I want to be able to review results of performance / load / stress / soak tests so that I know what levels of performance are possible and with what resource requirements (CPU / RAM etc...)._<br><br>*Not met*. As far as i am aware we don't have an easy way to review the data, but there might be some scenarios prepared by the QE team from the time when Sync was being prepared for production use.<br><br>_As a developer I want client side permission checks on token validity and roles/permissions checks so that I can fail fast on the client side without the need for a network request._<br><br>*Not met*. The fh-sync client libraries don't provide this at the moment. The JS client has a handler that is executed before a Network request and can be overridden but this still needs work.<br><br>_As a developer I want to be able to choose the collision handling strategy to use for data collisions so that I can I can use the most appropriate strategy for my dataset._<br><br>*Not met*. At the moment custom strategies can be implemented in the backend by overriding 'handleCollision'. But we don't provide an easy way for users to pick a predefined strategy.<br><br>_As a developer who does not trust the Internet and the powers that run it, I want to be able to set up a distributed peer to peer sync mesh so that I can achieve data synchronisation between clients without the need for a central server._<br><br>*Not met*. At the moment the sync clients require a backend to work. Not sure how we could achieve this in the JS client. On Android and iOS we could make use of UDP discovery for the local Network and Hole Punching over the Internet. Although i don't know how good that would work on a phone.<br><br>_As a developer I want to be able to set upper limits on payload sizes (record size, dataset size, binary size) so that I can control the volume of data that is being synced._<br><br>*Not met*. As far as i am aware we don't provide that option (at least i didn't see it defined in SyncOptions).<br><br>_As a developer I want to be able to consume datasets in "pages" - i.e. not get the entire dataset up front so that I can control the number of records returned._<br><br>*Not met*. As far as i am aware doList does not take any Options and does not provide pagination capabilities.<br><br>_As a developer I want to be able to control sync frequencies on the client and server so that I co-ordinate syncing and remove un-necessary sync loops._<br><br>*Met*. It looks like fh-sync allows us to define the frequencies of the sync loop on both, the backend and the clients.<br><br>_As a developer I want clear instructions (e.g. docs, examples, videos) on how to integrate the Sync SDK into my apps so that I can quickly get the SDK working and connect to the Sync._<br><br>*Not met*. A big pain point IMO. We need a central place for docs, a clear structure, a getting started guide, examples that guide the user from a minimal demo to a complex setup with a custom storage. <br><br>_As a developer I want single sign on between OpenShift/MCP and all of the mobile services so that I only need to sign in once and am authenticated everywhere._<br><br>*Not met*. But this is a problem we need to solve for other services as well (SDK metrics, etc.).</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-2023#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-31bbb30d-d15e-44f3-a4ac-c23431dfc790" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/AEROGEAR-2023#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.5.0#75005-<span title="fd8c849d4e278dd8bbaccc61e707a716ad697024" data-commit-id="fd8c849d4e278dd8bbaccc61e707a716ad697024}">sha1:fd8c849</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-826fd6be-4280-448b-a843-95b36768cd66" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>