<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.jboss.org">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/0d5a0dc52688f185ff93275f1ec9e7ff?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="peter.braun" id="email_peter.braun" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=peter.braun" style="color:#3b73af;; color: #3b73af; text-decoration: none">Peter Braun</a> <strong>edited a comment</strong> on <a href="https://issues.jboss.org/browse/AEROGEAR-2064" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-1c61123b-bbfc-4b3d-8e86-099fde77575c" height="16" width="16" border="0" align="absmiddle" alt="Task"> AEROGEAR-2064</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-2064" style="color: #3b73af; text-decoration: none">Re: Investigation: are there use cases where a JS SDK is not sufficient</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0; padding-top: 10px"> <span class="diffcontext">Some early results:<br><br>There are some use cases where we need to fall back to a native library for react-native (and very likely Corodva too). I'll analyse them one by one:<br><br>h2. Device Self Defence checks<br><br>There are several libraries for react-native and cordova that try to detect if a device is rooted/jailbroken, uses mocked locations, runs from an external SD card, etc. (RN: https://github.com/GantMan/jail-monkey, Cordova: https://github.com/dpa99c/cordova-diagnostic-plugin). The methods seem to be similar: for the root check they scan the filesystem for the presence of revealing binaries (su, sshd, etc.) or packages (Cydia, Superuser, etc.). They all use native code for this because otherwise they would not be able to access the filesystem at that level. We would have to do the same.<br><br>h2. Metrics<br><br>Most of metrics can be covered without native code:<br><br>* App Version: read from package.json<br>* SDK Version: can be exposed from the SDK's package.json<br>* Platform: react-native provides the Platform module which can be used. Cordova has a plugin but it relies on native code: https://github.com/apache/cordova-plugin-device<br>* Client ID: On react-native we can use AsyncStorage and on Cordova LocalStorage to save the generated ID.<br>* App ID: Java package/iOS module: it's probably not possible to retrieve this without native code. On iOS it currently has to be hardcoded even because there is no API to retrieve this information.<br><br>So we could cover most of metrics without using native code if we find a different definition for the App ID and a non-native way to retrieve the platform information on Cordova.<br><br>h2. Auth<br><br>The auth framework is based on OpenID Connect on Android. There is no implementation on iOS yet, but a very similar library exists (https://github.com/openid/AppAuth-iOS). There is a pure JS library (https://github.com/IdentityModel/oidc-client-js) that can be used for Cordova but it has no react-native support. There is a libary for App Auth on react native: https://github.com/FormidableLabs/react-native-app-auth<br><br>But i would like to avoid telling our customers to rely on 3rd party modules. We have this functionality in our Android SDK so it would be very inconsistent to tell a customer that on react-native they should just use a 3rd party module.<br><br>The pure JS library shows that it is possible without native code and maybe we could even contribute to that project and add react-native support. But short/mid-term it seems to be easier to just wrap our already existing Android SDK (and later iOS).<br><br>h2. Push<br><br>There has been an attempt to create a pure JS Push client: https://github.com/aerogear/aerogear-js-push. But it is no longer maintained and the functionality seems very limited. The existing Cordova plugin seems well maintained: https://github.com/aerogear/aerogear-cordova-push.<br><br>Again, it's probably possible to create a pure JS push client and at some point we will have to do it (to support progressive web apps). But short/mid term it seems easier to use/wrap what's already there.<br><br>h2. Conclusion<br><br>We can't satisfy all our use cases without using native code (or changing the requirements). That requires us to overthink the SDK architecture. What we wanted to achieve was one SDK that has the same semantics in Cordova, React Native and Browser. And for pure JS code there are ways to achive that (e.g. UMD modules).<br><br>With the requirement of native code i'm not sure if the current architecture will work: I don't think we can have one, say, aerogear-js-metrics SDK that can be used in Cordova and React Native and wraps native code? So that leaves us with creating separate modules: aerogaer-reactnative..., aerogear-cordova..., etc. And if we do that there is no smallest common denominator for all three platforms, we can just wrap native code where it makes sense.<br><br>The problem is that we won't have a Web SDK as an implicit result of the work. We will have to do that separately.<br><br>h2. Next steps<br><br>I'll try to build a react-native library and a cordova plugin wrapping what we already have.<br><br>Those conclusions are what i get from the investigation. I'm of course open for a discussion about any of this. ping [~davidmartin] [~wtrocki] [~phajidec] [~danielpassos]</span> <span class="diffaddedchars" style="background-color:#ddfade;"> [~jgallaso]</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-2064#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-cf4969d2-ee53-421f-9569-73150ae89d59" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/AEROGEAR-2064#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.5.0#75005-<span title="fd8c849d4e278dd8bbaccc61e707a716ad697024" data-commit-id="fd8c849d4e278dd8bbaccc61e707a716ad697024}">sha1:fd8c849</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-3071656a-7ae7-4f3d-8a93-c693235ab9d0" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>