<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.jboss.org">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/bd1946aafd256fc8796cd927befe1353?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="cmacedo86" id="email_cmacedo86" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=cmacedo86" style="color:#0052cc;; color: #3b73af; text-decoration: none">Camila Macedo</a> <strong>edited a comment</strong> on <a href="https://issues.jboss.org/browse/AEROGEAR-8583" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-8afba3c2-6873-42c4-ba3e-8b7676827fbb" height="16" width="16" border="0" align="absmiddle" alt="Task"> AEROGEAR-8583</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-8583" style="color: #3b73af; text-decoration: none">Re: Add asserts for all tests.</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0; padding-top: 10px"> <span class="diffcontext">Hi [~endaphelan],<br><br>Thank you for share. I replied the ML[1] and I hope that it can makes sense for you and it give a chance for you think a little more about it and who knows may change your mind :-)<br><br>Note that the CONS are good part a copy and past from the post in a blog[2] and that the book mentioned in this blog and in your email has the goal to explain the Go system and tools and it is comparing the go test system impl X Assertions approach in other languages.</span> <span class="diffaddedchars" style="background-color:#ddfade;"> *</span> <span class="diffcontext"> The argumentations added as CONS are NOT ALL truly valid for</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> *</span> <span class="diffaddedchars" style="background-color:#ddfade;"> "</span> <span class="diffcontext">testify/assert</span> <span class="diffaddedchars" style="background-color:#ddfade;">"</span> <span class="diffcontext">* which is one the most popular and used pkg in GO which is the testify/assert as you can check here[3].<br><br>*See that the biggest part of the OpenSource projects in this stack are using testify/assert because of all advantages and incredible gains that it can offer. For example the OpenShift, Kubernets and indeed the echo framework which was adopted for this project.* Also, IMHO we should follow up the OpenShift project which is one of the best examples for this stack and it is made by us, RedHat.<br> <br>Since you added as CONS that it is unnecessary because it is just another way to do it, then IHMO it is actually an easier, faster and simple way to get the tests done and maintained. Please, think a little over it: If it is not good at all, why OpenShift and Kubernets which are examples/standards for the stack are using it? Why it is the most popular and used GO lib? Why echo is using it and describing in its docs how to do the test with? Is the implementation of the framework adopted by us really not follow up the good practices as these others all big OpenSource projects? <br><br>* Following one example of the CONS added that is NOT true for this pkg,<br>bq. Tests stop executing after the first assert fails - masking patterns of failure<br>* Following the test made locally in order to show that it is NOT the behaviour faced with<br><br>{code:java}<br>camilamacedo@Camilas-MacBook-Pro ~/go/src/github.com/aerogear/mobile-security-service (AEROGEAR-8583) $ make test<br>Running tests:<br>GOCACHE=off go test -cover \<br> github.com/aerogear/mobile-security-service/pkg/config github.com/aerogear/mobile-security-service/pkg/db github.com/aerogear/mobile-security-service/pkg/httperrors github.com/aerogear/mobile-security-service/pkg/web/apps github.com/aerogear/mobile-security-service/pkg/web/router<br>--- FAIL: TestGetEnv_OverrideValues (0.00s)<br> config_test.go:77: <br> Error Trace: config_test.go:77<br> Error: Expected nil, but got: "json"<br> Test: TestGetEnv_OverrideValues<br>FAIL<br>coverage: 100.0% of statements<br>FAIL github.com/aerogear/mobile-security-service/pkg/config 0.060s<br>? github.com/aerogear/mobile-security-service/pkg/db [no test files]<br>ok github.com/aerogear/mobile-security-service/pkg/httperrors 0.035s coverage: 96.3% of statements<br>ok github.com/aerogear/mobile-security-service/pkg/web/apps 0.033s coverage: 77.2% of statements<br>? github.com/aerogear/mobile-security-service/pkg/web/router [no test files]<br>make: *** [test-unit] Error 1<br>{code}<br><br>HI [~dffrench],<br><br>Regards:<br><br>bq. Just getting to this now. I would agree, unless there is a strong need or justification for introducing testify, we should be heeding the wisdom of developers that have worked on the existing Mobile Services.<br><br>I hope that you can check the email in this thread[1] and see that has many strong justifications for we use testify and see it with your own eyes, mind and heart by comparing the 2 practical examples as [~endaphelan]. :-) <br><br>In this case, I am heading in the wisdom of the devs who wrote OpenShift[6] and Kubernets[5] which has been working with this stack for too long, as echo framework[4] and so many others devs which has been implementing OpenSource projects in this stack since it is one of the most used and popular lib in GO. Note that that OCP project has an incredible test suite. <br><br>PS.: If I am allowed to finish this task I will not spend more than 2 hours from now since [~endaphelan] made a fantastic work by implementing many tests and this project still too small. <br><br>[1] - https://groups.google.com/d/msgid/aerogear/f6d257f7-3668-48ee-8d8e-0243aac29277%40googlegroups.com?utm_medium=email&utm_source=footer<br>[2] - https://blog.alexellis.io/golang-writing-unit-tests/<br>[3] - https://godoc.org/ (atached image)<br>[4] - https://echo.labstack.com/guide/testing<br>[5] -https://github.com/search?q=org%3Akubernetes+%22github.com%2Fstretchr%2Ftestify%2Fassert%22&type=Code<br>[6] - https://github.com/search?q=org%3Aopenshift+%22github.com%2Fstretchr%2Ftestify%2Fassert%22&type=Code<br><br>c/c [~austincunningham]</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-8583#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-efcfb4d4-9cd0-4d7c-bc34-36db9f3c1d88" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/AEROGEAR-8583#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v7.12.1#712002-<span title="609a50578ba6bc73dbf8b05dddd7c04a04b6807c" data-commit-id="609a50578ba6bc73dbf8b05dddd7c04a04b6807c}">sha1:609a505</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://issues.jboss.org/images/mail/atlassian-email-logo.png" alt="Atlassian logo" title="Atlassian logo" width="191" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>