<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.jboss.org">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/bd1946aafd256fc8796cd927befe1353?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="cmacedo86" id="email_cmacedo86" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=cmacedo86" style="color:#0052cc;; color: #3b73af; text-decoration: none">Camila Macedo</a> <strong>commented</strong> on <a href="https://issues.jboss.org/browse/AEROGEAR-8583" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-94e594cc-5bd4-46e7-b860-fa2110f1d24d" height="16" width="16" border="0" align="absmiddle" alt="Task"> AEROGEAR-8583</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-8583" style="color: #3b73af; text-decoration: none">Re: Add asserts for all tests.</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <p style="margin: 10px 0 0 0; margin-top: 0">Hi <a href="https://issues.jboss.org/secure/ViewProfile.jspa?name=endaphelan" class="user-hover" rel="endaphelan" style="color: #3b73af; text-decoration: none">Enda Phelan</a>,</p> <p style="margin: 10px 0 0 0">Thank you for share. I replied the ML<span class="error">[1]</span> and I hope that it can makes sense for you and it give a chance for you think a little more about it and who knows change your mind <img class="emoticon" src="cid:jira-generated-image-static-smile-ca0d0b4e-e1b6-4738-b99d-56165a7c1a4d" height="16" width="16" align="absmiddle" alt="" border="0"></p> <p style="margin: 10px 0 0 0">Note that the CONS are good part a copy and past from the post in a blog<span class="error">[2]</span> and that the book mentioned in this blog and in your email has the goal to explain the Go system and tools and this book tried compare the go test system impl X Assertions approach in another languages. The argumentations added as CONS are NOT ALL truelly valid for <b>testify/assert</b> which is one the most popular and used pkg in GO which is the testify/assert as you can check here<span class="error">[3]</span>.</p> <p style="margin: 10px 0 0 0"><b>See that the biggest part of the OpenSource projects in this stack are using *testify/assert</b> because of all advantagens and incredable gains that it can offer.* For example the OpenShift, Kubernets and indeed the echo framework which was dopted for this project. Also, IHMO we should follow up the OpenShift project which is one of the best examples for this stack and it is made by us, RedHat. </p> <p style="margin: 10px 0 0 0">Since you added as CONS that it is uncesseray because it is just another way to do it, then IHMO it is accutually an easer, faster and simple way to get the tests done and mantained. Please, think a little over it: If it is not good at all, why OpenShift and Kubernets which are examples/standards for the stack are using it? Why it is the most popular and used GO lib? Why echo is using it and describing in its docs how to do the test with? Is the implementation of the fremework adopted by us really not follow up the good practices as these others all big OpenSource projects? </p> <p style="margin: 10px 0 0 0">Following one example of the CONS added that are NOT true for this pkg,</p>
<blockquote style="margin: 10px 0 0 0; border-left: 1px solid #cccccc; color: #707070; margin-left: 19px; padding: 10px 20px">
<p style="margin: 10px 0 0 0; margin-top: 0">Tests stop executing after the first assert fails - masking patterns of failure</p>
</blockquote> <p style="margin: 10px 0 0 0">Following the test made locally in order to show that it is NOT the behaviour faced with this adoption. </p> <p style="margin: 10px 0 0 0"></p>
<div id="syntaxplugin" class="syntaxplugin" style="border: 1px dashed #bbb; border-radius: 5px !important; overflow: auto; max-height: 30em;">
<table cellspacing="0" cellpadding="0" border="0" width="100%" style="font-size: 1em; line-height: 1.4em !important; font-weight: normal; font-style: normal; color: black;; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; margin-top: 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">camilamacedo</span><span style="color: gray; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">@Camilas</span><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">-MacBook-Pro ~/go/src/github.com/aerogear/mobile-security-service (AEROGEAR-</span><span style="color: #009900; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">8583</span><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">) $ make test</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">Running tests:</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">GOCACHE=off go test -cover \</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;"> github.com/aerogear/mobile-security-service/pkg/config github.com/aerogear/mobile-security-service/pkg/db github.com/aerogear/mobile-security-service/pkg/httperrors github.com/aerogear/mobile-security-service/pkg/web/apps github.com/aerogear/mobile-security-service/pkg/web/router</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">--- FAIL: TestGetEnv_OverrideValues (</span><span style="color: #009900; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">0</span><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">.00s)</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;"> config_test.go:</span><span style="color: #009900; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">77</span><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">: </span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;"> Error Trace: config_test.go:</span><span style="color: #009900; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">77</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;"> Error: Expected nil, but got: </span><span style="color: blue; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">"json"</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;"> Test: TestGetEnv_OverrideValues</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">FAIL</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">coverage: </span><span style="color: #009900; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">100.0</span><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">% of statements</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">FAIL github.com/aerogear/mobile-security-service/pkg/config </span><span style="color: #009900; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">0</span><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">.060s</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">? github.com/aerogear/mobile-security-service/pkg/db [no test files]</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">ok github.com/aerogear/mobile-security-service/pkg/httperrors </span><span style="color: #009900; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">0</span><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">.035s coverage: </span><span style="color: #009900; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">96.3</span><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">% of statements</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">ok github.com/aerogear/mobile-security-service/pkg/web/apps </span><span style="color: #009900; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">0</span><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">.033s coverage: </span><span style="color: #009900; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">77.2</span><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">% of statements</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">? github.com/aerogear/mobile-security-service/pkg/web/router [no test files]</span></pre> </td>
</tr>
<tr id="syntaxplugin_code_and_gutter">
<td style=" line-height: 1.4em !important; padding: 0em; vertical-align: top;; padding: 0px; border-collapse: collapse"> <pre style="font-size: 1em; margin: 0 10px; margin-bottom: 10px; width: auto; padding: 0;; margin: 10px 0 0 0; margin-top: 0"><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">make: *** [test-unit] Error </span><span style="color: #009900; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">1</span><span style="color: black; font-family: 'Consolas', 'Bitstream Vera Sans Mono', 'Courier New', Courier, monospace !important;">
</span></pre> </td>
</tr>
</tbody>
</table>
</div> <p style="margin: 10px 0 0 0"></p> <p style="margin: 10px 0 0 0">HI <a href="https://issues.jboss.org/secure/ViewProfile.jspa?name=dffrench" class="user-hover" rel="dffrench" style="color: #3b73af; text-decoration: none">David Ffrench</a>,</p> <p style="margin: 10px 0 0 0">Regards:</p>
<blockquote style="margin: 10px 0 0 0; border-left: 1px solid #cccccc; color: #707070; margin-left: 19px; padding: 10px 20px">
<p style="margin: 10px 0 0 0; margin-top: 0">Just getting to this now. I would agree, unless there is a strong need or justification for introducing testify, we should be heeding the wisdom of developers that have worked on the existing Mobile Services.</p>
</blockquote> <p style="margin: 10px 0 0 0">I hope that you can check the email in this thread<span class="error">[1]</span> and see for that has many strong justifications for we use testify and checking and compare the 2 pratical examples with your own eyes, mind and heart as <a href="https://issues.jboss.org/secure/ViewProfile.jspa?name=endaphelan" class="user-hover" rel="endaphelan" style="color: #3b73af; text-decoration: none">Enda Phelan</a>. <img class="emoticon" src="cid:jira-generated-image-static-smile-ca0d0b4e-e1b6-4738-b99d-56165a7c1a4d" height="16" width="16" align="absmiddle" alt="" border="0"> In this case, I am heading in the wisdom in the devs who wrote OpenShift and Kubernets which has been working with this stack for too long, as echo framewrok and so many others dev which implemented OpenSource projects in this stack since it is one of the most used and popular lib in GO. Note that that OCP projects has an incredable test suite. </p> <p style="margin: 10px 0 0 0">PS.: If I be allowed to finish this task I will not spend more than 2 hours from now since <a href="https://issues.jboss.org/secure/ViewProfile.jspa?name=endaphelan" class="user-hover" rel="endaphelan" style="color: #3b73af; text-decoration: none">Enda Phelan</a> made a fantastic work by implement many tests and this project still too small. </p> <p style="margin: 10px 0 0 0"><span class="error">[1]</span> - <a href="https://groups.google.com/d/msgid/aerogear/f6d257f7-3668-48ee-8d8e-0243aac29277%40googlegroups.com?utm_medium=email&utm_source=footer" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">https://groups.google.com/d/msgid/aerogear/f6d257f7-3668-48ee-8d8e-0243aac29277%40googlegroups.com?utm_medium=email&utm_source=footer</a><br> <span class="error">[2]</span> - <a href="https://blog.alexellis.io/golang-writing-unit-tests/" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">https://blog.alexellis.io/golang-writing-unit-tests/</a><br> <span class="error">[3]</span> - <a href="https://godoc.org/" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">https://godoc.org/</a> (atached image)</p> <p style="margin: 10px 0 0 0">c/c <a href="https://issues.jboss.org/secure/ViewProfile.jspa?name=austincunningham" class="user-hover" rel="austincunningham" style="color: #3b73af; text-decoration: none">Austin Cunningham</a></p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-8583#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-591befb0-4bf5-43a2-9250-0d4647f36b46" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/AEROGEAR-8583#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v7.12.1#712002-<span title="609a50578ba6bc73dbf8b05dddd7c04a04b6807c" data-commit-id="609a50578ba6bc73dbf8b05dddd7c04a04b6807c}">sha1:609a505</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://issues.jboss.org/images/mail/atlassian-email-logo.png" alt="Atlassian logo" title="Atlassian logo" width="191" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>