<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.jboss.org">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/bd1946aafd256fc8796cd927befe1353?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="cmacedo86" id="email_cmacedo86" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=cmacedo86" style="color:#0052cc;; color: #3b73af; text-decoration: none">Camila Macedo</a> <strong>edited a comment</strong> on <a href="https://issues.jboss.org/browse/AEROGEAR-9091" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-21184d36-90d6-4cbd-ad82-48bda97ac78e" height="16" width="16" border="0" align="absmiddle" alt="Task"> AEROGEAR-9091</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-9091" style="color: #3b73af; text-decoration: none">Re: Check the operator working an OCP OSD cluster</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0; padding-top: 10px"> <span class="diffcontext">The</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> problem shows be</span> <span class="diffaddedchars" style="background-color:#ddfade;"> name is defined</span> <span class="diffcontext"> in the</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> follow</span> <span class="diffaddedchars" style="background-color:#ddfade;"> following</span> <span class="diffcontext"> code</span> <span class="diffaddedchars" style="background-color:#ddfade;"> and it came from the spec</span> <span class="diffcontext">.</span> <span class="diffaddedchars" style="background-color:#ddfade;"> (CR)</span> <span class="diffcontext"><br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code:java}</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">ObjectMeta: metav1.ObjectMeta</span> <span class="diffcontext">{</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br> Name: getConfigMapName(m),<br> Namespace: m.Namespace,<br> Labels: getAppLabels(m.Name),<br> },<br>{</span> <span class="diffcontext">code</span> <span class="diffaddedchars" style="background-color:#ddfade;">}<br><br>The problem can be in the fetch that should be using the same helper func to get the name.<br><br>{code</span> <span class="diffcontext">:java}<br>//</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">getConfigMapName</span> <span class="diffaddedchars" style="background-color:#ddfade;">fetchAppConfigMap</span> <span class="diffcontext"> returns</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> an string name with</span> <span class="diffcontext"> the</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> name of the configMap</span> <span class="diffaddedchars" style="background-color:#ddfade;"> config map resource created for this instance</span> <span class="diffcontext"><br>func</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> getConfigMapName</span> <span class="diffcontext">(</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">m</span> <span class="diffaddedchars" style="background-color:#ddfade;">r</span> <span class="diffcontext"> *</span> <span class="diffaddedchars" style="background-color:#ddfade;">ReconcileMobileSecurityService) fetchAppConfigMap(reqLogger logr.Logger, instance *</span> <span class="diffcontext">mobilesecurityservicev1alpha1.MobileSecurityService)</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> string</span> <span class="diffaddedchars" style="background-color:#ddfade;"> (*corev1.ConfigMap, error)</span> <span class="diffcontext">{<br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> if len</span> <span class="diffaddedchars" style="background-color:#ddfade;"> reqLogger.Info</span> <span class="diffcontext">(</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">m</span> <span class="diffaddedchars" style="background-color:#ddfade;">"Checking if the ConfigMap already exists")<br> configMap := &corev1</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Spec</span> <span class="diffaddedchars" style="background-color:#ddfade;">ConfigMap{}<br> err := r</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">ConfigMapName</span> <span class="diffaddedchars" style="background-color:#ddfade;">client.Get(context.TODO(</span> <span class="diffcontext">)</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> > 0</span> <span class="diffaddedchars" style="background-color:#ddfade;">, types.NamespacedName</span> <span class="diffcontext"> {</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br> return m</span> <span class="diffaddedchars" style="background-color:#ddfade;">Name: instance</span> <span class="diffcontext">.Spec.ConfigMapName</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">, Namespace: instance.Namespace</span> <span class="diffcontext"> }</span> <span class="diffaddedchars" style="background-color:#ddfade;">, configMap)</span> <span class="diffcontext"><br> return</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> m.Name</span> <span class="diffaddedchars" style="background-color:#ddfade;"> configMap, err</span> <span class="diffcontext"><br>}<br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">{code}<br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br>For some reason, it is not getting the specified name in the CR. We can just remove the name from the CR and make the configMap be always the m.name since it is not a requirement at all. <br><br> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-9091#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-20718bf3-ed8d-477e-ae13-be30b57c09a0" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/AEROGEAR-9091#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v7.12.1#712002-<span title="609a50578ba6bc73dbf8b05dddd7c04a04b6807c" data-commit-id="609a50578ba6bc73dbf8b05dddd7c04a04b6807c}">sha1:609a505</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://issues.jboss.org/images/mail/atlassian-email-logo.png" alt="Atlassian logo" title="Atlassian logo" width="191" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>