<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.jboss.org">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/bd1946aafd256fc8796cd927befe1353?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="cmacedo86" id="email_cmacedo86" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=cmacedo86" style="color:#0052cc;; color: #3b73af; text-decoration: none">Camila Macedo</a> <strong>edited a comment</strong> on <a href="https://issues.jboss.org/browse/AEROGEAR-8987" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-765b68c6-d21c-402a-8df1-8ad63cf4174c" height="16" width="16" border="0" align="absmiddle" alt="Task"> AEROGEAR-8987</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-8987" style="color: #3b73af; text-decoration: none">Re: Impl config the oauth proxy to the service </a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0; padding-top: 10px"> <span class="diffcontext">Hi [~dffrench] and [~lfitzgerald].<br><br>Regards bq."requires investigation into whether there is a way we can determine if the operator is running on openshift or kubernetes"<br><br>* *When you run OCP you are running the kubernetes.* You never run one or another. The server is Kubernetes. The OCP is just on top of it. The kube is inside of OCP. Note that in your home you will find the .kube dir which is the setup used. <br>* All that worked in kubernetes worked for OCP just the other way around is not valid.<br><br>h4. What I understood that are the current problems faced for [~lfitzgerald]?<br><br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">*</span> <span class="diffaddedchars" style="background-color:#ddfade;">h5.</span> <span class="diffcontext"> She needs the name of the router and when it is created based on the ingress OCP is not respecting the name and is append a string at it. (See [here](https://github.com/openshift/router/issues/23) for a further understand)<br><br>Workaround/Suggestions made so far:<br><br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">1.</span> <span class="diffcontext"> Just use the kind in the annotation. ([~lfitzgerald] will try) <br><br>{code:java}<br> annotations:<br> serviceaccounts.openshift.io/oauth-redirectreference.primary: '{"kind":"OAuthRedirectReference","apiVersion":"v1","reference":{"kind":"Route"}}’<br>{code}<br><br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">2</span> <span class="diffaddedchars" style="background-color:#ddfade;">PS</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> We</span> <span class="diffaddedchars" style="background-color:#ddfade;">: I think that we</span> <span class="diffcontext"> could</span> <span class="diffaddedchars" style="background-color:#ddfade;"> also</span> <span class="diffcontext"> create a group and pass and/or get the name router name created by</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> <br></span> <span class="diffcontext"> OCP programmatically.<br><br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">* She needs setup</span> <span class="diffaddedchars" style="background-color:#ddfade;">h5. Setup</span> <span class="diffcontext"> TLS. We just need to use the ks8 API to implement it in the ingress as follows examples in other operators.<br><br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">#</span> <span class="diffaddedchars" style="background-color:#ddfade;">*</span> <span class="diffcontext"> https://github.com/mercari/certificate-expiry-monitor-controller/blob/36eac97ffae7df101fbcd7e5815106eb8488152e/source/source_test.go#L24<br><br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">#</span> <span class="diffaddedchars" style="background-color:#ddfade;">*</span> <span class="diffcontext"> https://github.com/infinimesh/operator/blob/c9e8de03c19f5daee226df7e7c89a364d8e84d5e/pkg/controller/platform/frontend.go#L122<br><br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">#</span> <span class="diffaddedchars" style="background-color:#ddfade;">*</span> <span class="diffcontext"> https://github.com/presslabs/wordpress-operator/blob/1d285e7cff886ac42fe88a9ec742b824b3c05e17/pkg/controller/wordpress/internal/sync/ingress.go#L79<br><br>Following an example of how to solve it in our project.<br><br>{code:java}<br>Spec: v1beta1.IngressSpec{<br> TLS: []v1beta1.IngressTLS{<br> {<br> Hosts: []string{m.Spec.ClusterHost},<br> SecretName: "ingressSecret1",<br> },<br> },<br> Backend: &v1beta1.IngressBackend{<br> ServiceName: m.Name,<br> ServicePort: intstr.FromInt(int(m.Spec.Port)),<br> },<br> Rules: []v1beta1.IngressRule{<br> {<br> Host: utils.GetAppIngress(m.Spec.ClusterHost, m.Spec.HostSufix),<br> IngressRuleValue: v1beta1.IngressRuleValue{<br> HTTP: &v1beta1.HTTPIngressRuleValue{<br> Paths: []v1beta1.HTTPIngressPath{<br> {<br> Backend: v1beta1.IngressBackend{<br> ServiceName: m.Name,<br> ServicePort: intstr.FromInt(int(m.Spec.Port)),<br> },<br> Path: "/",<br> },<br> },<br> },<br> },<br> },<br> },<br> },<br>{code}<br><br><br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-8987#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-f816aee2-aca9-4a93-8d48-fc0776a31fd9" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/AEROGEAR-8987#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v7.12.1#712002-<span title="609a50578ba6bc73dbf8b05dddd7c04a04b6807c" data-commit-id="609a50578ba6bc73dbf8b05dddd7c04a04b6807c}">sha1:609a505</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://issues.jboss.org/images/mail/atlassian-email-logo.png" alt="Atlassian logo" title="Atlassian logo" width="191" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>