<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.jboss.org">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/bd1946aafd256fc8796cd927befe1353?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="cmacedo86" id="email_cmacedo86" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=cmacedo86" style="color:#0052cc;; color: #3b73af; text-decoration: none">Camila Macedo</a> <strong>edited a comment</strong> on <a href="https://issues.jboss.org/browse/AEROGEAR-9507" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-a837452d-c1aa-48bf-a29b-8798af8c4604" height="16" width="16" border="0" align="absmiddle" alt="Enhancement"> AEROGEAR-9507</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-9507" style="color: #3b73af; text-decoration: none">Re: [MSS Oper] - Add OpenAPI validation schema for all CRs</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0; padding-top: 10px"> <span class="diffcontext">HI [~dffrench],<br><br>The files are automatically updated by the framework</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">. The step to check it is basically verified if it passed in the CI since this change is not able to impact what was done already. So,</span> <span class="diffaddedchars" style="background-color:#ddfade;"> so</span> <span class="diffcontext"> I</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> did</span> <span class="diffaddedchars" style="background-color:#ddfade;"> am</span> <span class="diffcontext"> not</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> understand</span> <span class="diffaddedchars" style="background-color:#ddfade;"> sure</span> <span class="diffcontext"> why it would take</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> many hours to get done</span> <span class="diffaddedchars" style="background-color:#ddfade;"> too much time</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> but OK</span> <span class="diffaddedchars" style="background-color:#ddfade;"> however, it is fine</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> <br></span> <span class="diffaddedchars" style="background-color:#ddfade;"> <br></span> <span class="diffcontext"><br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">NOTE: After we can improve the comments added by me if</span> <span class="diffaddedchars" style="background-color:#ddfade;">[~dffrench][~lfitzgerald]<br>*Do</span> <span class="diffcontext"> you</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> wish but</span> <span class="diffaddedchars" style="background-color:#ddfade;"> mind if</span> <span class="diffcontext"> I</span> <span class="diffaddedchars" style="background-color:#ddfade;"> ping others to</span> <span class="diffcontext"> do</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> not see that a typo text in a comment/description would be a blocker for not merge</span> <span class="diffaddedchars" style="background-color:#ddfade;"> this review since you have no time to do</span> <span class="diffcontext"> it</span> <span class="diffaddedchars" style="background-color:#ddfade;">?*</span> <span class="diffcontext"><br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">Hi [~bofarrel]<br><br>Thank you for your reply. <br><br></span> <span class="diffcontext">h4. Why it is required?<br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">*</span> <span class="diffcontext"> It will make easier create the OLM<br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">*</span> <span class="diffcontext"> Following the good practices<br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">*</span> <span class="diffcontext"> Make easier the understatement<br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">*</span> <span class="diffcontext"> Validate the data in the CR by the API ( avoid issues and mistakes when it is used )<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">I have planning to present this project as an example/demo in the TDC event at 20th.</span> <span class="diffcontext">So,</span> <span class="diffaddedchars" style="background-color:#ddfade;"> I'd like to address small improvements and keep it better shape than it is already. <br><br>Also,</span> <span class="diffcontext"> if a dev from the community do a PR as I did this one we will not review and addressed it</span> <span class="diffaddedchars" style="background-color:#ddfade;"> unless we are working effectively on it or</span> <span class="diffcontext"> before the next month</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">.</span> <span class="diffaddedchars" style="background-color:#ddfade;">?</span> <span class="diffcontext"> Is it something that really makes sense? <br><br></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">c/c [~bofarrel][~lfitzgerald]<br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-9507#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-822f81ea-4454-4f0e-bb63-9ef7fa6f7975" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/AEROGEAR-9507#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v7.12.1#712002-<span title="609a50578ba6bc73dbf8b05dddd7c04a04b6807c" data-commit-id="609a50578ba6bc73dbf8b05dddd7c04a04b6807c}">sha1:609a505</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://issues.jboss.org/images/mail/atlassian-email-logo.png" alt="Atlassian logo" title="Atlassian logo" width="191" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>