<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.jboss.org">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/bd1946aafd256fc8796cd927befe1353?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="cmacedo86" id="email_cmacedo86" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=cmacedo86" style="color:#0052cc;; color: #3b73af; text-decoration: none">Camila Macedo</a> <strong>edited a comment</strong> on <a href="https://issues.jboss.org/browse/AEROGEAR-9652" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-14f53e00-9251-430b-b4bc-de6dd0f74d24" height="16" width="16" border="0" align="absmiddle" alt="Bug"> AEROGEAR-9652</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-9652" style="color: #3b73af; text-decoration: none">Re: MSS Grafana Service Dashboard is using operator data when should not</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0; padding-top: 10px"> <span class="diffcontext">Hi [~lfitzgerald],<br><br>Thank for your reply. <br><br>First, at all, this JIRA is not about MDC. It is about MSS Oper.<br><br>*However, regards MDC:*<br>- The Grafana dashboard for the Service was NOT implemented. So, it is</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> not</span> <span class="diffaddedchars" style="background-color:#ddfade;"> NOT</span> <span class="diffcontext"> using one for both. <br>- The task tracked for we do it is: https://issues.jboss.org/browse/AEROGEAR-9650<br><br>*Note:* IMHO we should do all in the same way. Also, it was a request from SRE in order to make easier the understatement, to use and to admin it.<br><br>*Regards this JIRA:*<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">*</span> <span class="diffcontext">WHAT:</span> <span class="diffaddedchars" style="background-color:#ddfade;">*</span> <span class="diffcontext"> MSS Grafana Service Dashboard is using operator data when should not since it has one for the Service and other for the Operator<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">*</span> <span class="diffcontext">WHERE</span> <span class="diffaddedchars" style="background-color:#ddfade;">*</span> <span class="diffcontext">: E.g https://github.com/aerogear/mobile-security-service-operator/blob/master/deploy/monitor/mss_grafana_dashboard.yaml#L643<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">*</span> <span class="diffcontext">WHY:</span> <span class="diffaddedchars" style="background-color:#ddfade;">*</span> <span class="diffcontext"> A admin</span> <span class="diffaddedchars" style="background-color:#ddfade;"> will</span> <span class="diffcontext"> check the CPU and Memory for example in the MSS Application Dashboard</span> <span class="diffaddedchars" style="background-color:#ddfade;"> then the admin</span> <span class="diffcontext"> will expect to see the data just obtained</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> in</span> <span class="diffaddedchars" style="background-color:#ddfade;"> from</span> <span class="diffcontext"> the app.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> The</span> <span class="diffaddedchars" style="background-color:#ddfade;"> Also, the</span> <span class="diffcontext"> labels</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> also</span> <span class="diffcontext"> are saying that the data/graph</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> cam</span> <span class="diffaddedchars" style="background-color:#ddfade;"> came</span> <span class="diffcontext"> from the MSS Application/Service when it is not.<br><br>Why I pinged you and [~austincunningham] here?<br><br>My goal</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> as</span> <span class="diffaddedchars" style="background-color:#ddfade;"> here is to</span> <span class="diffcontext"> share it with you folks and give the opportunity for you to share your thoughts in the case of you have any reason for it</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> b</span> <span class="diffaddedchars" style="background-color:#ddfade;"> got</span> <span class="diffcontext"> done in this way</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> and</span> <span class="diffaddedchars" style="background-color:#ddfade;">. I mean if</span> <span class="diffcontext"> it</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> is</span> <span class="diffaddedchars" style="background-color:#ddfade;"> was</span> <span class="diffcontext"> not a mistake,</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> I mean</span> <span class="diffaddedchars" style="background-color:#ddfade;"> as</span> <span class="diffcontext"> some test and/or cut and paste from the Operator dashboard implemented in the project which we forget to change/remove.<br><br>Please, let me know if the above description makes sense now and if you would like to share any thought that goes against keeping the cohesion in this dashboard by having just the application/service data used on it. Hi, [~austincunningham], have you any objection over this fix? </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.jboss.org/browse/AEROGEAR-9652#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-8b9abf72-a460-4d59-87d2-3c6e73da5acf" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/AEROGEAR-9652#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v7.12.1#712002-<span title="609a50578ba6bc73dbf8b05dddd7c04a04b6807c" data-commit-id="609a50578ba6bc73dbf8b05dddd7c04a04b6807c}">sha1:609a505</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://issues.jboss.org/images/mail/atlassian-email-logo.png" alt="Atlassian logo" title="Atlassian logo" width="191" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>