<div dir="ltr">Hi Kelvin,<div><br></div><div>I finally added the PR you suggested:</div><div><a href="https://github.com/aerogear/aerogear-unifiedpush-server/pull/629">https://github.com/aerogear/aerogear-unifiedpush-server/pull/629</a><br></div><div><br></div><div>-M</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 31, 2015 at 2:08 PM, Daniel Passos <span dir="ltr"><<a href="mailto:dpassos@redhat.com" target="_blank">dpassos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class="">On Thu, Jul 30, 2015 at 9:48 PM, Kelvin Lunsford <span dir="ltr"><<a href="mailto:kelvin@qantel.com" target="_blank">kelvin@qantel.com</a>></span> wrote:<br></span><div class="gmail_extra"><div class="gmail_quote"><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Sorry Matt,<br>
<br>
Not ready to be a real contributor yet. Just a user. No git account.<br></blockquote><div><br></div></span><div>I understand your point here but I cannot agree with you. Notify about a possible bug/whatever is a real contribution. <br><br>Thank you for that. <br></div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
This looks like a 3 line change to me. Not big enough to learn everything required to do a PR.<br>
<br>
I might sign up later for a bigger change, but that's another topic.<br>
<br>
- Kelvin<br>
<br>
<br>
------------------------------------------------------------------------------------<br>
From: <a href="mailto:aerogear-users-bounces@lists.jboss.org" target="_blank">aerogear-users-bounces@lists.jboss.org</a> [mailto:<a href="mailto:aerogear-users-bounces@lists.jboss.org" target="_blank">aerogear-users-bounces@lists.jboss.org</a>] On Behalf Of Matthias Wessendorf<br>
Sent: Thursday, July 30, 2015 3:39 AM<br>
To: <a href="mailto:aerogear-users@lists.jboss.org" target="_blank">aerogear-users@lists.jboss.org</a><br>
Subject: Re: [Aerogear-users] UPS push to IOS removes the badge<br>
<div><div><br>
Hi Kevin,<br>
<br>
you mind sending a PR (pull request) to fix this bug?<br>
Sorry for it, its a pretty annoying issue for sure!<br>
<br>
-Matthias<br>
<br>
On Thursday, July 30, 2015, Kelvin Lunsford <<a href="mailto:kelvin@qantel.com" target="_blank">kelvin@qantel.com</a>> wrote:<br>
If UPS is given a push command with no "badge" value the IOS badge icon is being removed when the notification is received. Expected behavior is that the badge icon would be unchanged if no badge value is set.<br>
<br>
When USP receives a push command with no "badge" value it is sending APNS a "badge" value of -1.<br>
<br>
The Apple push payload spec says the badge icon is removed if the "badge" value is 0, and the icon is unchanged if there is no "badge" value. The spec does not say what happens if the "badge" value is less than zero.<br>
<br>
Tested devices are removing the badge icon when -1 is set.<br>
<br>
Please change UPS so no "badge" value is sent to APNS when the UPS command has no "badge" value.<br>
<br>
For example you could change the sendPushMessage function of APNsPushNotificationSender.java to:<br>
<br>
PayloadBuilder builder = APNS.newPayload()<br>
// adding recognized key values<br>
.alertBody(message.getAlert())<br>
//.badge(message.getBadge()) // do not set badge here<br>
.sound(message.getSound())<br>
.alertTitle(apns.getTitle())<br>
.alertAction(apns.getAction())<br>
.urlArgs(apns.getUrlArgs())<br>
.category(apns.getActionCategory())<br>
.localizedTitleKey(apns.getLocalizedTitleKey());<br>
<br>
if (message.getBadge() >= 0)<br>
builder.badge(message.getBadge()); // only set badge if needed<br>
<br>
- Kelvin<br>
<br>
_______________________________________________<br>
Aerogear-users mailing list<br>
<a href="mailto:Aerogear-users@lists.jboss.org" target="_blank">Aerogear-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-users" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-users</a><br>
<br>
<br>
--<br>
Sent from Gmail Mobile<br>
<br>
_______________________________________________<br>
Aerogear-users mailing list<br>
<a href="mailto:Aerogear-users@lists.jboss.org" target="_blank">Aerogear-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-users" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-users</a><br>
</div></div></blockquote></div></div></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br><div><div dir="ltr">-- Passos<br></div></div>
</font></span></div></div>
<br>_______________________________________________<br>
Aerogear-users mailing list<br>
<a href="mailto:Aerogear-users@lists.jboss.org">Aerogear-users@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-users" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-users</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a></div>
</div>