[arquillian-issues] [JBoss JIRA] (ARQ-666) Redesign WebDriver browser configuration

[Karel Piwko (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646058#comment-12646058 ] 

Karel Piwko commented on ARQ-666:
---------------------------------

Implementation note:

No warning are issue. Configuration is hidden from tests, so user will see no warnings based on implementationClass value. This leads to following situation:

{code}
@Drone HtmlUnitDriver driver;
{code}

{code:xml}
<property name="implementationClass">...FirefoxDriver</property>
{code}

This will use HtmlUnitDriverFactory to get instance of FirefoxDriver. This is incorrect and will fail (because HtmlUnitDriverFactory has specific instantiation). Following must be specified in order to pass, however than implementation specific details are no triggered, e.g. no ChromeSwitches will be executed.

{code}
@Drone WebDriver driver;
{code}

Is that generic approach enough?


                
> Redesign WebDriver browser configuration
> ----------------------------------------
>
>                 Key: ARQ-666
>                 URL: https://issues.jboss.org/browse/ARQ-666
>             Project: Arquillian
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>          Components: Extension - Drone
>    Affects Versions: drone_1.0.0.CR2
>            Reporter: Karel Piwko
>            Priority: Critical
>             Fix For: drone_1.0.0.Final
>
>
> Current binding of browser type to the type defined in the class itself limits the usage of generic WebDriver drivers.
> This means that you can simply change WebDriver type by configuration, you have to modify Java code. The usage should be modified to implementationClass be the property which decides what instance will be used even for generic webdrivers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira