[arquillian-issues] [JBoss JIRA] (ARQGRA-373) Resolving @Location value does not work as expected

[Lukáš Fryč (JIRA)]

    [ https://issues.jboss.org/browse/ARQGRA-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803814#comment-12803814 ] 

Lukáš Fryč edited comment on ARQGRA-373 at 9/12/13 7:16 AM:
------------------------------------------------------------

Hey [~michbeck100], nice catch and thanks for the patch! :-)

I can confirm the patch works as expected.

We did a mistake to use just {{resource://}} URLs in the test suite. ;-)
https://github.com/arquillian/arquillian-graphene/blob/master/ftest/src/test/java/org/jboss/arquillian/graphene/ftest/enricher/TestPageObjectsLocation.java#L90

----

Can I ask you to sign a Contributor License Agreement for Arquillian project?
https://cla.jboss.org/index.seam

Would you mind to send this patch as a pull request?
You don't even need to use Git, you can edit the source straight on Github (when you are signed, use the [Edit button|https://help.github.com/articles/creating-and-editing-files-in-your-repository#editing-a-file])
https://github.com/arquillian/arquillian-graphene/blob/master/impl/src/main/java/org/jboss/arquillian/graphene/enricher/LocationEnricher.java

I will fix the test suite afterwards.
                
      was (Author: lfryc):
    Hey [~michbeck100], nice catch and thanks for the patch! :-)

I can confirm the patch works as expected.

We did a mistake to use just {{resource://}} URLs in the test suite. ;-)
https://github.com/arquillian/arquillian-graphene/blob/master/ftest/src/test/java/org/jboss/arquillian/graphene/ftest/enricher/TestPageObjectsLocation.java#L90

----

Can I ask you to sign a Contributor License Agreement for Arquillian project?
https://cla.jboss.org/index.seam

Would you mind to send this patch as a pull request?
You don't even need to use Git, you can edit the source straight on Github:
https://github.com/arquillian/arquillian-graphene/blob/master/impl/src/main/java/org/jboss/arquillian/graphene/enricher/LocationEnricher.java

I will fix the test suite afterwards.
                  
> Resolving @Location value does not work as expected
> ---------------------------------------------------
>
>                 Key: ARQGRA-373
>                 URL: https://issues.jboss.org/browse/ARQGRA-373
>             Project: Arquillian Graphene
>          Issue Type: Bug
>    Affects Versions: 2.0.0.Beta1
>            Reporter: Michael Kotten
>             Fix For: 2.0.0.CR1
>
>         Attachments: ARQGRA-373.patch
>
>
> The @Location annotation introduced with 2.0.0.Alpha5 does not work as described in the example of http://arquillian.org/blog/2013/09/04/arquillian-graphene-2-0-0-Alpha5/.
> Using a non-absolute location value like "index.html" will throw an exception when trying to browse to the page using Graphene.goTo or using @InitialPage.
> When looking at the sources of LocationEnricher I see 2 problems:
> * contextRootStore is initialized too late in resolve method (line 70). It's already needed during goTo (line 110 in getURLFromLocation) which gets called before initialization (line 68).
> * Using a non-absolute location value leads to an IllegalArgumentException in getURLFromLocation (line 146). I guess the catch block in line 116 is just for this purpose. Unfortunately there will be no URISyntaxException for non-absolute locations. They are perfectly fine URIs (until they get converted to URLs).
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira