[arquillian-issues] [JBoss JIRA] (ARQ-1511) Wrong Android server identification in logs

[Stefan Miklosovic (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12808218#comment-12808218 ] 

Stefan Miklosovic commented on ARQ-1511:
----------------------------------------

The name of the container is taken from this method

https://github.com/arquillian/arquillian-droidium/blob/master/droidium-container/arquillian-droidium-container-impl/src/main/java/org/arquillian/droidium/container/AndroidDeployableContainer.java#L185

Since "Starting the container Nexus4" is written out in start method of container adapter where that method gets called and you have specified both avdName and serialId, that method returns avdName as the name of the container. I think the fix for this is to put if statement with serialId before avdName to follow "serialId wins when avdName is present as well" logic.


                
> Wrong Android server identification in logs
> -------------------------------------------
>
>                 Key: ARQ-1511
>                 URL: https://issues.jboss.org/browse/ARQ-1511
>             Project: Arquillian
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Extension - Droidium
>    Affects Versions: droidium_1.0.0.Alpha1
>            Reporter: Karel Piwko
>            Priority: Minor
>
> Despite the fact I have physical device attached and tests are running on that device, Droidium logs following:
> {code}
> Sep 29, 2013 4:30:14 PM org.arquillian.droidium.container.configuration.AndroidContainerConfiguration validate
> WARNING: Both "avdName" and "serialId" properties are defined, the device specified by "serialId" will get priority if connected.
> Sep 29, 2013 4:30:14 PM org.arquillian.droidium.container.AndroidDeployableContainer start
> INFO: Starting the container Nexus4.
> Sep 29, 2013 4:30:14 PM org.arquillian.droidium.container.impl.AndroidBridgeConnector initAndroidDebugBridge
> INFO: Initializing Android Debug Bridge.
> Sep 29, 2013 4:30:14 PM org.arquillian.droidium.container.impl.AndroidBridgeImpl connect
> INFO: Connecting to the Android Debug Bridge at /home/kpiwko/apps/android-sdk-linux_x86/platform-tools/adb forceNewBridge = true
> Sep 29, 2013 4:30:14 PM org.arquillian.droidium.container.impl.AndroidBridgeConnector initAndroidDebugBridge
> INFO: Android Debug Bridge was initialized in 323ms.
> Sep 29, 2013 4:30:14 PM org.arquillian.droidium.container.impl.AndroidDeviceSelectorImpl getPhysicalDevice
> INFO: Detected physical device with serial ID e8fd5c98.
> {code}
> *Starting the container Nexus4.* is a wrong log output.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira