[arquillian-issues] [JBoss JIRA] (ARQ-1653) Drone use concurrent.ExecutorService without Context inheritance on Threads

Aslak Knutsen (JIRA) issues at jboss.org
Sun Feb 23 04:15:48 EST 2014


    [ https://issues.jboss.org/browse/ARQ-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12947089#comment-12947089 ] 

Aslak Knutsen commented on ARQ-1653:
------------------------------------

I have a patch in the works that fix it in Drone using a similar technique as used by the ServletProtocol; 
https://github.com/arquillian/arquillian-core/blob/master/container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/execution/RemoteTestExecuter.java#L136

Tho, I think a long term fix is to expose a ExecutorService service in Core that can handle this internally, to avoid leaking to much impl details into the extensions.
                
> Drone use concurrent.ExecutorService without Context inheritance on Threads 
> ----------------------------------------------------------------------------
>
>                 Key: ARQ-1653
>                 URL: https://issues.jboss.org/browse/ARQ-1653
>             Project: Arquillian
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Extension - Drone
>    Affects Versions: drone_1.2.3.Final, 1.1.3.Final
>            Reporter: Aslak Knutsen
>
> Context's in Arquillian are bound to ThreadLocals within their lifecycle. In Core 1.0.4.Final this was changed to use InheritableThreadLocal to fix an issue with the TestFramework not finding Core when executing multiple threads. This had some unforeseen consequences and in the end reverted in 1.1.3.Final. 
> Somewhere inbetween those versions, Drone started to use a Threaded WebDriver creation to allow timeout control. This is now failing, since the InstanceCallable is called on a 'empty' Thread.
> https://github.com/arquillian/arquillian-extension-drone/blob/master/drone-impl/src/main/java/org/jboss/arquillian/drone/impl/DroneInstanceCreator.java#L84

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the arquillian-issues mailing list