[arquillian-issues] [JBoss JIRA] (ARQ-1852) Move Warp's CommandService to Protocol

[Aslak Knutsen (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000821#comment-13000821 ] 

Aslak Knutsen commented on ARQ-1852:
------------------------------------

CommandService is part of Core already. Every Protocol has it's own implementation of it to allow InContainer to communicate with Client side: https://github.com/arquillian/arquillian-core/blob/master/container/test-spi/src/main/java/org/jboss/arquillian/container/test/spi/command/CommandService.java

E.g. the ServletCommandService from the Servlet Protocol: https://github.com/arquillian/arquillian-core/blob/master/protocols/servlet/src/main/java/org/jboss/arquillian/protocol/servlet/runner/ServletCommandService.java

?

> Move Warp's CommandService to Protocol
> --------------------------------------
>
>                 Key: ARQ-1852
>                 URL: https://issues.jboss.org/browse/ARQ-1852
>             Project: Arquillian
>          Issue Type: Enhancement
>          Components: Extension - Warp, Test Protocol SPIs and Implementation
>    Affects Versions: 1.1.5.Final
>            Reporter: Emond Papegaaij
>            Priority: Optional
>
> Warp provides a very nice SPI for running commands remotely. I would love to see this this SPI become part of the Protocol classes, making it available to all Arquillian code. I'm writing an extension, which needs to execute some code in the container, but is triggered on events fired on the client. Warp's CommandService would allow me to do this, but it only works in Warp tests, which my tests are not. Also, making the code part of Protocol should remove quite some duplication between Protocol and Warp's CommandService.



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)