[arquillian-issues] [JBoss JIRA] (ARQ-1852) Move Warp's CommandService to Protocol

[Emond Papegaaij (JIRA)]

    [ https://issues.jboss.org/browse/ARQ-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002023#comment-13002023 ] 

Emond Papegaaij commented on ARQ-1852:
--------------------------------------

We are running selenium test with Arquillian with custom Wicket integration. These test run on the server to be able to access the Wicket state from within the selenium test itself. In this setting, I would like these commands for two purposes: reporting and resource  management. The first I was able to solve with commands from the server to the client. But the second still remains open.

Opening a new browser and setting up the user session is quite expensive compared to the actual test cases so I want to pool browsers with active sessions. However, these need to be closed after the last case. Because Arquillian triggers AfterSuite after every case, I can't use this event in the container. I would like to send a command from the client on AfterSuite to close all open browsers.

In general, I think the ability to send commands from the client to the container can be useful in many other cases. From what I've seen in Warp's code, is that they implemented a separate servlet filter to implement this. A lot of code is duplicated between SevletProtocol and warp, including for example the code to get the right URL, causing bugs like ARQ-1592.

> Move Warp's CommandService to Protocol
> --------------------------------------
>
>                 Key: ARQ-1852
>                 URL: https://issues.jboss.org/browse/ARQ-1852
>             Project: Arquillian
>          Issue Type: Enhancement
>          Components: Extension - Warp, Test Protocol SPIs and Implementation
>    Affects Versions: 1.1.5.Final
>            Reporter: Emond Papegaaij
>            Priority: Optional
>
> Warp provides a very nice SPI for running commands remotely. I would love to see this this SPI become part of the Protocol classes, making it available to all Arquillian code. I'm writing an extension, which needs to execute some code in the container, but is triggered on events fired on the client. Warp's CommandService would allow me to do this, but it only works in Warp tests, which my tests are not. Also, making the code part of Protocol should remove quite some duplication between Protocol and Warp's CommandService.



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)