From issues at jboss.org Wed Jan 3 11:15:00 2018 From: issues at jboss.org (Charles Tian (JIRA)) Date: Wed, 3 Jan 2018 11:15:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2162) New release for wlp-managed container (with support for multi-app verification before test app deployment) In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509068#comment-13509068 ] Charles Tian commented on ARQ-2162: ----------------------------------- One more thing: with the release of OpenLiberty late last year, could we change the names of our WLP containers from {{arquillian-wlp-*-8.5}} to {{arquillian-liberty-*}} ? We want to indicate to users that these containers are available for both OpenLiberty and the WebSphere Liberty Profile. We would also like to remove any association with a specific version of Liberty, as we expect these containers be compatible with our releases of Liberty in the foreseeable future. > New release for wlp-managed container (with support for multi-app verification before test app deployment) > ---------------------------------------------------------------------------------------------------------- > > Key: ARQ-2162 > URL: https://issues.jboss.org/browse/ARQ-2162 > Project: Arquillian > Issue Type: Release > Components: WebSphere Containers > Reporter: Charles Tian > Assignee: Aslak Knutsen > > I'm a developer at IBM currently working on some updates for the Arquillian WLP managed container. I have some improvements which I'm planning to push out in the next couple of weeks. > Once these changed get reviewed and merged, could we make a new release for the WLP managed container on Maven Central? The current version is 1.0.0.Beta2 and was released almost three years ago (Jan. 2015). Since then, there have been many updates made to the container (including the changes that I will be providing) that are not part of any release. -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Wed Jan 3 11:15:00 2018 From: issues at jboss.org (Charles Tian (JIRA)) Date: Wed, 3 Jan 2018 11:15:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2162) New release for wlp-managed container (with support for multi-app verification before test app deployment) In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509068#comment-13509068 ] Charles Tian edited comment on ARQ-2162 at 1/3/18 11:14 AM: ------------------------------------------------------------ One more thing: with the release of OpenLiberty late last year, could we change the names of our WLP containers from {{arquillian-wlp-\*-8.5}} to {{arquillian-liberty-\*}} ? We want to indicate to users that these containers are available for both OpenLiberty and the WebSphere Liberty Profile. We would also like to remove any association with a specific version of Liberty, as we expect these containers be compatible with our releases of Liberty in the foreseeable future. was (Author: chyt): One more thing: with the release of OpenLiberty late last year, could we change the names of our WLP containers from {{arquillian-wlp-*-8.5}} to {{arquillian-liberty-*}} ? We want to indicate to users that these containers are available for both OpenLiberty and the WebSphere Liberty Profile. We would also like to remove any association with a specific version of Liberty, as we expect these containers be compatible with our releases of Liberty in the foreseeable future. > New release for wlp-managed container (with support for multi-app verification before test app deployment) > ---------------------------------------------------------------------------------------------------------- > > Key: ARQ-2162 > URL: https://issues.jboss.org/browse/ARQ-2162 > Project: Arquillian > Issue Type: Release > Components: WebSphere Containers > Reporter: Charles Tian > Assignee: Aslak Knutsen > > I'm a developer at IBM currently working on some updates for the Arquillian WLP managed container. I have some improvements which I'm planning to push out in the next couple of weeks. > Once these changed get reviewed and merged, could we make a new release for the WLP managed container on Maven Central? The current version is 1.0.0.Beta2 and was released almost three years ago (Jan. 2015). Since then, there have been many updates made to the container (including the changes that I will be providing) that are not part of any release. -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Wed Jan 3 11:16:00 2018 From: issues at jboss.org (Charles Tian (JIRA)) Date: Wed, 3 Jan 2018 11:16:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2162) New release for wlp-managed container (with support for multi-app verification before test app deployment) In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509068#comment-13509068 ] Charles Tian edited comment on ARQ-2162 at 1/3/18 11:15 AM: ------------------------------------------------------------ One more thing: with the release of OpenLiberty late last year, could we change the names of our WLP containers from {{arquillian-wlp\-\*\-8.5}} to {{arquillian-liberty\-\*}} ? We want to indicate to users that these containers are available for both OpenLiberty and the WebSphere Liberty Profile. We would also like to remove any association with a specific version of Liberty, as we expect these containers be compatible with our releases of Liberty in the foreseeable future. was (Author: chyt): One more thing: with the release of OpenLiberty late last year, could we change the names of our WLP containers from {{arquillian-wlp-\*-8.5}} to {{arquillian-liberty-\*}} ? We want to indicate to users that these containers are available for both OpenLiberty and the WebSphere Liberty Profile. We would also like to remove any association with a specific version of Liberty, as we expect these containers be compatible with our releases of Liberty in the foreseeable future. > New release for wlp-managed container (with support for multi-app verification before test app deployment) > ---------------------------------------------------------------------------------------------------------- > > Key: ARQ-2162 > URL: https://issues.jboss.org/browse/ARQ-2162 > Project: Arquillian > Issue Type: Release > Components: WebSphere Containers > Reporter: Charles Tian > Assignee: Aslak Knutsen > > I'm a developer at IBM currently working on some updates for the Arquillian WLP managed container. I have some improvements which I'm planning to push out in the next couple of weeks. > Once these changed get reviewed and merged, could we make a new release for the WLP managed container on Maven Central? The current version is 1.0.0.Beta2 and was released almost three years ago (Jan. 2015). Since then, there have been many updates made to the container (including the changes that I will be providing) that are not part of any release. -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Wed Jan 17 11:04:00 2018 From: issues at jboss.org (Dipak Pawar (JIRA)) Date: Wed, 17 Jan 2018 11:04:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2169) Already Exported/Exploded directory should delete if exists before exploding/exportin In-Reply-To: References: Message-ID: Dipak Pawar created ARQ-2169: -------------------------------- Summary: Already Exported/Exploded directory should delete if exists before exploding/exportin Key: ARQ-2169 URL: https://issues.jboss.org/browse/ARQ-2169 Project: Arquillian Issue Type: Bug Affects Versions: 1.2.0.Final Reporter: Dipak Pawar Running deploymentExportExploded= true after deploymentExportExploded = false or vice versa without mvn clean throws illegal argument exception -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Wed Jan 17 11:04:01 2018 From: issues at jboss.org (Dipak Pawar (JIRA)) Date: Wed, 17 Jan 2018 11:04:01 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2169) Already Exported/Exploded directory should delete if exists before exploding/exporting In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dipak Pawar updated ARQ-2169: ----------------------------- Summary: Already Exported/Exploded directory should delete if exists before exploding/exporting (was: Already Exported/Exploded directory should delete if exists before exploding/exportin ) > Already Exported/Exploded directory should delete if exists before exploding/exporting > ---------------------------------------------------------------------------------------- > > Key: ARQ-2169 > URL: https://issues.jboss.org/browse/ARQ-2169 > Project: Arquillian > Issue Type: Bug > Affects Versions: 1.2.0.Final > Reporter: Dipak Pawar > > Running deploymentExportExploded= true after deploymentExportExploded = false or vice versa without mvn clean throws illegal argument exception -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Wed Jan 17 11:04:01 2018 From: issues at jboss.org (Dipak Pawar (JIRA)) Date: Wed, 17 Jan 2018 11:04:01 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2169) Already Exported/Exploded directory should delete if exists before exploding/exporting In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dipak Pawar reassigned ARQ-2169: -------------------------------- Assignee: Dipak Pawar > Already Exported/Exploded directory should delete if exists before exploding/exporting > ---------------------------------------------------------------------------------------- > > Key: ARQ-2169 > URL: https://issues.jboss.org/browse/ARQ-2169 > Project: Arquillian > Issue Type: Bug > Affects Versions: 1.2.0.Final > Reporter: Dipak Pawar > Assignee: Dipak Pawar > > Running deploymentExportExploded= true after deploymentExportExploded = false or vice versa without mvn clean throws illegal argument exception -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Wed Jan 17 11:40:01 2018 From: issues at jboss.org (Matous Jobanek (JIRA)) Date: Wed, 17 Jan 2018 11:40:01 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2066) Support for JUnit 5 In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13520300#comment-13520300 ] Matous Jobanek commented on ARQ-2066: ------------------------------------- For more information about the progress see this GitHub issue: https://github.com/arquillian/arquillian-core/issues/137 TLDR: As JUnit5 doesn't provide enough SPI points to hook in, then (for now) it's not possible to implement Arquillian JUnit 5 engine or extension. > Support for JUnit 5 > ------------------- > > Key: ARQ-2066 > URL: https://issues.jboss.org/browse/ARQ-2066 > Project: Arquillian > Issue Type: Feature Request > Reporter: Tobias Stadler > > The final relase of JUnit 5 is scheduled for Q1 2017. It would be nice if Arquillian would support it then. -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Fri Jan 19 12:55:00 2018 From: issues at jboss.org (kostd kostd (JIRA)) Date: Fri, 19 Jan 2018 12:55:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2170) RulesEnricher doubles each test enrichment In-Reply-To: References: Message-ID: kostd kostd created ARQ-2170: -------------------------------- Summary: RulesEnricher doubles each test enrichment Key: ARQ-2170 URL: https://issues.jboss.org/browse/ARQ-2170 Project: Arquillian Issue Type: Bug Components: core Environment: arquillian-junit-core-1.1.11.Final (all versions affected) Reporter: kostd kostd RulesEnricher created in ARQ-1954 1. RulesEnricher is not implementor of TestEnricher, so it cannot be overrided through LoadableExtension. 2. RulesEnricher#enrichRulesAndTestInstance adds into collection toEnrich test instance: {code} toEnrich.add(event.getTestInstance()); {code} https://github.com/arquillian/arquillian-core/blob/master/junit/core/src/main/java/org/jboss/arquillian/junit/RulesEnricher.java So, if MyTest have`nt field rules, will be only one MyTest enrichment. If MyTest contains one or more test rule, will be two MyTest enrichments. Each testEnrichment of MyTest do a soap call to server to prepare data for test. It is very important to me, one or two soap call will happen. How can I change this behaviour? -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Fri Jan 19 13:02:00 2018 From: issues at jboss.org (kostd kostd (JIRA)) Date: Fri, 19 Jan 2018 13:02:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2170) RulesEnricher doubles each test enrichment In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13521570#comment-13521570 ] kostd kostd commented on ARQ-2170: ---------------------------------- Created arquillian-junit-core without testInstance toEnrich addition. Now only one enrichment, only one soap call, Rules works as usual. > RulesEnricher doubles each test enrichment > ------------------------------------------ > > Key: ARQ-2170 > URL: https://issues.jboss.org/browse/ARQ-2170 > Project: Arquillian > Issue Type: Bug > Components: core > Environment: arquillian-junit-core-1.1.11.Final (all versions affected) > Reporter: kostd kostd > > RulesEnricher created in ARQ-1954 > 1. RulesEnricher is not implementor of TestEnricher, so it cannot be overrided through LoadableExtension. > 2. RulesEnricher#enrichRulesAndTestInstance adds into collection toEnrich test instance: > {code} > toEnrich.add(event.getTestInstance()); > {code} > https://github.com/arquillian/arquillian-core/blob/master/junit/core/src/main/java/org/jboss/arquillian/junit/RulesEnricher.java > So, if MyTest have`nt field rules, will be only one MyTest enrichment. If MyTest contains one or more test rule, will be two MyTest enrichments. > Each testEnrichment of MyTest do a soap call to server to prepare data for test. It is very important to me, one or two soap call will happen. > How can I change this behaviour? -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Fri Jan 19 13:04:00 2018 From: issues at jboss.org (kostd kostd (JIRA)) Date: Fri, 19 Jan 2018 13:04:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2170) RulesEnricher doubles each test enrichment In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13521570#comment-13521570 ] kostd kostd edited comment on ARQ-2170 at 1/19/18 1:03 PM: ----------------------------------------------------------- Created arquillian-junit-core.jar without testInstance toEnrich addition. Now only one enrichment, only one soap call, Rules works as usual. was (Author: kostd): Created arquillian-junit-core without testInstance toEnrich addition. Now only one enrichment, only one soap call, Rules works as usual. > RulesEnricher doubles each test enrichment > ------------------------------------------ > > Key: ARQ-2170 > URL: https://issues.jboss.org/browse/ARQ-2170 > Project: Arquillian > Issue Type: Bug > Components: core > Environment: arquillian-junit-core-1.1.11.Final (all versions affected) > Reporter: kostd kostd > > RulesEnricher created in ARQ-1954 > 1. RulesEnricher is not implementor of TestEnricher, so it cannot be overrided through LoadableExtension. > 2. RulesEnricher#enrichRulesAndTestInstance adds into collection toEnrich test instance: > {code} > toEnrich.add(event.getTestInstance()); > {code} > https://github.com/arquillian/arquillian-core/blob/master/junit/core/src/main/java/org/jboss/arquillian/junit/RulesEnricher.java > So, if MyTest have`nt field rules, will be only one MyTest enrichment. If MyTest contains one or more test rule, will be two MyTest enrichments. > Each testEnrichment of MyTest do a soap call to server to prepare data for test. It is very important to me, one or two soap call will happen. > How can I change this behaviour? -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Mon Jan 22 10:08:00 2018 From: issues at jboss.org (Matous Jobanek (JIRA)) Date: Mon, 22 Jan 2018 10:08:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2171) @ClassRules should not be executed in container In-Reply-To: References: Message-ID: Matous Jobanek created ARQ-2171: ----------------------------------- Summary: @ClassRules should not be executed in container Key: ARQ-2171 URL: https://issues.jboss.org/browse/ARQ-2171 Project: Arquillian Issue Type: Bug Components: core Affects Versions: 1.2.0.Final Reporter: Matous Jobanek For the same reason why {{@Before/After Class}} methods are not invoked in a container (the state between {{@Test}} methods is not kept), the {{@ClassRules}} should be prevented from running there as well. Currently, they are executed on both sides - on client & in container -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Mon Jan 22 10:08:00 2018 From: issues at jboss.org (Matous Jobanek (JIRA)) Date: Mon, 22 Jan 2018 10:08:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2171) @ClassRules should not be executed in container In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matous Jobanek reassigned ARQ-2171: ----------------------------------- Assignee: Matous Jobanek > @ClassRules should not be executed in container > ----------------------------------------------- > > Key: ARQ-2171 > URL: https://issues.jboss.org/browse/ARQ-2171 > Project: Arquillian > Issue Type: Bug > Components: core > Affects Versions: 1.2.0.Final > Reporter: Matous Jobanek > Assignee: Matous Jobanek > > For the same reason why {{@Before/After Class}} methods are not invoked in a container (the state between {{@Test}} methods is not kept), the {{@ClassRules}} should be prevented from running there as well. > Currently, they are executed on both sides - on client & in container -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Mon Jan 22 10:08:00 2018 From: issues at jboss.org (Matous Jobanek (JIRA)) Date: Mon, 22 Jan 2018 10:08:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2171) @ClassRules should not be executed in container In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matous Jobanek updated ARQ-2171: -------------------------------- Git Pull Request: https://github.com/arquillian/arquillian-core/pull/156 > @ClassRules should not be executed in container > ----------------------------------------------- > > Key: ARQ-2171 > URL: https://issues.jboss.org/browse/ARQ-2171 > Project: Arquillian > Issue Type: Bug > Components: core > Affects Versions: 1.2.0.Final > Reporter: Matous Jobanek > Assignee: Matous Jobanek > > For the same reason why {{@Before/After Class}} methods are not invoked in a container (the state between {{@Test}} methods is not kept), the {{@ClassRules}} should be prevented from running there as well. > Currently, they are executed on both sides - on client & in container -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Mon Jan 22 14:05:00 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Mon, 22 Jan 2018 14:05:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2169) Already Exported/Exploded directory should delete if exists before exploding/exporting In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak updated ARQ-2169: -------------------------------- Component/s: Base Implementation > Already Exported/Exploded directory should delete if exists before exploding/exporting > ---------------------------------------------------------------------------------------- > > Key: ARQ-2169 > URL: https://issues.jboss.org/browse/ARQ-2169 > Project: Arquillian > Issue Type: Bug > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Dipak Pawar > Assignee: Dipak Pawar > > Running deploymentExportExploded= true after deploymentExportExploded = false or vice versa without mvn clean throws illegal argument exception -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Mon Jan 22 14:05:00 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Mon, 22 Jan 2018 14:05:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2169) Already Exported/Exploded directory should delete if exists before exploding/exporting In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak updated ARQ-2169: -------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/arquillian/arquillian-core/pull/152 > Already Exported/Exploded directory should delete if exists before exploding/exporting > ---------------------------------------------------------------------------------------- > > Key: ARQ-2169 > URL: https://issues.jboss.org/browse/ARQ-2169 > Project: Arquillian > Issue Type: Bug > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Dipak Pawar > Assignee: Dipak Pawar > > Running deploymentExportExploded= true after deploymentExportExploded = false or vice versa without mvn clean throws illegal argument exception -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Mon Jan 22 14:05:00 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Mon, 22 Jan 2018 14:05:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2169) Already Exported/Exploded directory should delete if exists before exploding/exporting In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak updated ARQ-2169: -------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > Already Exported/Exploded directory should delete if exists before exploding/exporting > ---------------------------------------------------------------------------------------- > > Key: ARQ-2169 > URL: https://issues.jboss.org/browse/ARQ-2169 > Project: Arquillian > Issue Type: Bug > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Dipak Pawar > Assignee: Dipak Pawar > > Running deploymentExportExploded= true after deploymentExportExploded = false or vice versa without mvn clean throws illegal argument exception -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Tue Jan 23 04:27:00 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Tue, 23 Jan 2018 04:27:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2172) Remove duplication in TestRunnerAdaptor In-Reply-To: References: Message-ID: Bartosz Majsak created ARQ-2172: ----------------------------------- Summary: Remove duplication in TestRunnerAdaptor Key: ARQ-2172 URL: https://issues.jboss.org/browse/ARQ-2172 Project: Arquillian Issue Type: Enhancement Components: Base Implementation Reporter: Bartosz Majsak The code of the TestRunnerAdaptor management is same in both JUnit runner and JUnit class rule. The same can be also applied to the logic that invokes the test method. I've moved the code to separated classes that are used by both implementations -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Tue Jan 23 04:28:01 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Tue, 23 Jan 2018 04:28:01 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2172) Remove duplication in TestRunnerAdaptor In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak reassigned ARQ-2172: ----------------------------------- Assignee: Matous Jobanek > Remove duplication in TestRunnerAdaptor > --------------------------------------- > > Key: ARQ-2172 > URL: https://issues.jboss.org/browse/ARQ-2172 > Project: Arquillian > Issue Type: Enhancement > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Bartosz Majsak > Assignee: Matous Jobanek > > The code of the TestRunnerAdaptor management is same in both JUnit runner and JUnit class rule. The same can be also applied to the logic that invokes the test method. > I've moved the code to separated classes that are used by both implementations -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Tue Jan 23 04:28:01 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Tue, 23 Jan 2018 04:28:01 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2172) Remove duplication in TestRunnerAdaptor In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak updated ARQ-2172: -------------------------------- Affects Version/s: 1.2.0.Final > Remove duplication in TestRunnerAdaptor > --------------------------------------- > > Key: ARQ-2172 > URL: https://issues.jboss.org/browse/ARQ-2172 > Project: Arquillian > Issue Type: Enhancement > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Bartosz Majsak > Assignee: Matous Jobanek > > The code of the TestRunnerAdaptor management is same in both JUnit runner and JUnit class rule. The same can be also applied to the logic that invokes the test method. > I've moved the code to separated classes that are used by both implementations -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Tue Jan 23 04:28:02 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Tue, 23 Jan 2018 04:28:02 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2172) Remove duplication in TestRunnerAdaptor In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak updated ARQ-2172: -------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/arquillian/arquillian-core/pull/155 > Remove duplication in TestRunnerAdaptor > --------------------------------------- > > Key: ARQ-2172 > URL: https://issues.jboss.org/browse/ARQ-2172 > Project: Arquillian > Issue Type: Enhancement > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Bartosz Majsak > Assignee: Matous Jobanek > > The code of the TestRunnerAdaptor management is same in both JUnit runner and JUnit class rule. The same can be also applied to the logic that invokes the test method. > I've moved the code to separated classes that are used by both implementations -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Tue Jan 23 04:28:03 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Tue, 23 Jan 2018 04:28:03 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2172) Remove duplication in TestRunnerAdaptor In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak updated ARQ-2172: -------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > Remove duplication in TestRunnerAdaptor > --------------------------------------- > > Key: ARQ-2172 > URL: https://issues.jboss.org/browse/ARQ-2172 > Project: Arquillian > Issue Type: Enhancement > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Bartosz Majsak > Assignee: Matous Jobanek > > The code of the TestRunnerAdaptor management is same in both JUnit runner and JUnit class rule. The same can be also applied to the logic that invokes the test method. > I've moved the code to separated classes that are used by both implementations -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Tue Jan 23 04:31:00 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Tue, 23 Jan 2018 04:31:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2171) @ClassRules should not be executed in container In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak updated ARQ-2171: -------------------------------- Status: Pull Request Sent (was: Open) > @ClassRules should not be executed in container > ----------------------------------------------- > > Key: ARQ-2171 > URL: https://issues.jboss.org/browse/ARQ-2171 > Project: Arquillian > Issue Type: Bug > Components: core > Affects Versions: 1.2.0.Final > Reporter: Matous Jobanek > Assignee: Matous Jobanek > > For the same reason why {{@Before/After Class}} methods are not invoked in a container (the state between {{@Test}} methods is not kept), the {{@ClassRules}} should be prevented from running there as well. > Currently, they are executed on both sides - on client & in container -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Wed Jan 24 06:39:00 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Wed, 24 Jan 2018 06:39:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2171) @ClassRules should not be executed in container In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak updated ARQ-2171: -------------------------------- Fix Version/s: 1.2.1.Final > @ClassRules should not be executed in container > ----------------------------------------------- > > Key: ARQ-2171 > URL: https://issues.jboss.org/browse/ARQ-2171 > Project: Arquillian > Issue Type: Bug > Components: core > Affects Versions: 1.2.0.Final > Reporter: Matous Jobanek > Assignee: Matous Jobanek > Fix For: 1.2.1.Final > > > For the same reason why {{@Before/After Class}} methods are not invoked in a container (the state between {{@Test}} methods is not kept), the {{@ClassRules}} should be prevented from running there as well. > Currently, they are executed on both sides - on client & in container -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Wed Jan 24 06:39:00 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Wed, 24 Jan 2018 06:39:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2171) @ClassRules should not be executed in container In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak updated ARQ-2171: -------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > @ClassRules should not be executed in container > ----------------------------------------------- > > Key: ARQ-2171 > URL: https://issues.jboss.org/browse/ARQ-2171 > Project: Arquillian > Issue Type: Bug > Components: core > Affects Versions: 1.2.0.Final > Reporter: Matous Jobanek > Assignee: Matous Jobanek > Fix For: 1.2.1.Final > > > For the same reason why {{@Before/After Class}} methods are not invoked in a container (the state between {{@Test}} methods is not kept), the {{@ClassRules}} should be prevented from running there as well. > Currently, they are executed on both sides - on client & in container -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Wed Jan 24 06:39:00 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Wed, 24 Jan 2018 06:39:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2172) Remove duplication in TestRunnerAdaptor In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak updated ARQ-2172: -------------------------------- Fix Version/s: 1.2.1.Final > Remove duplication in TestRunnerAdaptor > --------------------------------------- > > Key: ARQ-2172 > URL: https://issues.jboss.org/browse/ARQ-2172 > Project: Arquillian > Issue Type: Enhancement > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Bartosz Majsak > Assignee: Matous Jobanek > Fix For: 1.2.1.Final > > > The code of the TestRunnerAdaptor management is same in both JUnit runner and JUnit class rule. The same can be also applied to the logic that invokes the test method. > I've moved the code to separated classes that are used by both implementations -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Wed Jan 24 06:39:00 2018 From: issues at jboss.org (Bartosz Majsak (JIRA)) Date: Wed, 24 Jan 2018 06:39:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-2169) Already Exported/Exploded directory should delete if exists before exploding/exporting In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bartosz Majsak updated ARQ-2169: -------------------------------- Fix Version/s: 1.2.1.Final > Already Exported/Exploded directory should delete if exists before exploding/exporting > ---------------------------------------------------------------------------------------- > > Key: ARQ-2169 > URL: https://issues.jboss.org/browse/ARQ-2169 > Project: Arquillian > Issue Type: Bug > Components: Base Implementation > Affects Versions: 1.2.0.Final > Reporter: Dipak Pawar > Assignee: Dipak Pawar > Fix For: 1.2.1.Final > > > Running deploymentExportExploded= true after deploymentExportExploded = false or vice versa without mvn clean throws illegal argument exception -- This message was sent by Atlassian JIRA (v7.5.0#75005) From issues at jboss.org Wed Jan 24 09:36:00 2018 From: issues at jboss.org (Falko Modler (JIRA)) Date: Wed, 24 Jan 2018 09:36:00 -0500 (EST) Subject: [arquillian-issues] [JBoss JIRA] (ARQ-1318) Test Intitialisation Time Sensitive to Classpath Dependencies In-Reply-To: References: Message-ID: [ https://issues.jboss.org/browse/ARQ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13523105#comment-13523105 ] Falko Modler commented on ARQ-1318: ----------------------------------- This is still a problem. I ended up caching the jarfiles created by {{ArquillianDeploymentAppender}} and {{JUnitDeploymentAppender}} *persistently* (as files in {{target}}) which saves ~2 seconds runtime which is especially useful when running a test repeatedly in Eclipse. The classpath in question is pretty large, containing several JBoss EAP 6.4 BOMs. > Test Intitialisation Time Sensitive to Classpath Dependencies > ------------------------------------------------------------- > > Key: ARQ-1318 > URL: https://issues.jboss.org/browse/ARQ-1318 > Project: Arquillian > Issue Type: Enhancement > Affects Versions: 1.0.3.Final > Environment: Fully patched Windows 7 64 bit OS. JDK 7.0_13 (x86). CPU i7 X940, 8GiB RAM, SSD storage. > Reporter: Chris Lowe > Attachments: arquillian-tutorial.zip > > > My test is making use of JBoss AS7 remote deployment and takes 11+ seconds before any output is received by the AS instance. Test initialisation times appear to be sensitive to the number of classpath dependencies. Of this time: > 2.5 seconds is spent loading auxiliary archives; > 8 seconds is spent making the final internal in-memory deployment before sending a byte buffer over to AS7. > Inclusion of Arquillian persistence along with JMeter (which has many transitive dependencies) results in tests shipping with an arquillian-persistence.jar that is 9MiB in size. This JAR file is produced and compressed on the fly as part of the test EAR construction. The jar files are compressed again when added to the final EAR. > My typical usage scenario is to run a test from Eclipse which spawns a JVM each time so test runs are from standing start (little hotspot optimisation). > Some of the generated Arquillian jars include dependencies like log4j and slf4j which will be available in the target server. As far as I can tell, I have no control over this process. > It would be ideal if I could create an Arquillian module in AS7 to eliminate the need to ship Arquillian run time classes entirely. -- This message was sent by Atlassian JIRA (v7.5.0#75005)